Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/609845/?format=api
{ "id": 609845, "url": "http://patchwork.ozlabs.org/api/patches/609845/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/a17942d94a295a0db7ef205060b97313289b1640.1460517387.git.brian@walsh.ws/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<a17942d94a295a0db7ef205060b97313289b1640.1460517387.git.brian@walsh.ws>", "list_archive_url": null, "date": "2016-04-13T03:22:30", "name": "[v2,1/2] e1000e: Cleanup consistency in ret_val variable usage", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "32c228ee02b5d4f3db131e46054471bf9a980e67", "submitter": { "id": 68336, "url": "http://patchwork.ozlabs.org/api/people/68336/?format=api", "name": "Brian Walsh", "email": "brian@walsh.ws" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/a17942d94a295a0db7ef205060b97313289b1640.1460517387.git.brian@walsh.ws/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/609845/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/609845/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 3ql8S15Nyrz9sdm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Apr 2016 13:29:36 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0392795D0D;\n\tWed, 13 Apr 2016 03:29:36 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hWvVmV55R49k; Wed, 13 Apr 2016 03:29:34 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D8E3995CE6;\n\tWed, 13 Apr 2016 03:29:34 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id EB91C1C1EB2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Apr 2016 03:29:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E6F0B33417\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Apr 2016 03:29:33 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Z3YmHmDGeK3i for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Apr 2016 03:29:32 +0000 (UTC)", "from mail-yw0-f173.google.com (mail-yw0-f173.google.com\n\t[209.85.161.173])\n\tby silver.osuosl.org (Postfix) with ESMTPS id AB4122E457\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Apr 2016 03:29:32 +0000 (UTC)", "by mail-yw0-f173.google.com with SMTP id t10so52493940ywa.0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 12 Apr 2016 20:29:32 -0700 (PDT)", "from hobbes.lan20.walshnetwork.net\n\t([2606:a000:4b40:8c01:c4a9:e7a0:24:9c26])\n\tby smtp.gmail.com with ESMTPSA id\n\tt201sm19545685ywe.45.2016.04.12.20.22.32\n\tfor <intel-wired-lan@lists.osuosl.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 12 Apr 2016 20:22:32 -0700 (PDT)", "from localhost.lan20.walshnetwork.net ([127.0.0.1]\n\thelo=hobbes.lan20.walshnetwork.net)\n\tby hobbes.lan20.walshnetwork.net with esmtp (Exim 4.84_2)\n\t(envelope-from <brian@walsh.ws>) id 1aqBNw-0004IH-0i\n\tfor intel-wired-lan@lists.osuosl.org; Tue, 12 Apr 2016 23:22:32 -0400" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=walsh.ws header.i=@walsh.ws header.b=llhKAW6V;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:06:58 by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=walsh.ws; s=google; \n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=TNFix4FVul0iO4NDoP0C5y5p7NrOUocSUF7nuPRD808=;\n\tb=llhKAW6VDiv8x/nyNfobSG227eRutNM/FydxSGY/twx3LANWe4J5Xz/w9nSC+biceC\n\tr+Cpg81cMPvARbUSpYw7q8wKt/mCkZD3Urk6QjFd6MapYzKMDIn5cWeE9KwO+nMCRDQW\n\tHsO1rjlsIG7x2bvh4/o3rEI7IZEW9Be2r6igk=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=TNFix4FVul0iO4NDoP0C5y5p7NrOUocSUF7nuPRD808=;\n\tb=LCt/VDcKPf8JVFUJO+Ug0ox0ermFE6E34QyARbwqW99i4LWuG56kP/rGD8YgZPUxD5\n\tfE3LF5Q0rL5ixxp3S9P6zLf8FR2akuNbvofbBJIQEGymbWI3z5wH1Oe1DTOJ0yoEUqIy\n\tQ/cNkjTYoSurTVbAlB+Vxm+V2slmiRILmvQWvygETlTv6HW54Hk34V8g+vGjXHy+pfqf\n\tO7RWRuUGQM2YGbTCnAXA46WTKJTCsYI55gyscWUXAFicLMqXtogf6GVRuh0RFTqsh0pX\n\tmsjqOf1zrpZup3H7GURuCj0g6P/3433qxpRZht15HKCA6OWK5CLAlv7CXUBysqoQSZdy\n\taUpg==", "X-Gm-Message-State": "AOPr4FXBQIUxOkOcgjt0VlwxoWG4UcIYseu5K31OUj3M4hVWzDbDCSipTx+FaZ3SMWS18A==", "X-Received": "by 10.37.28.193 with SMTP id c184mr3758429ybc.88.1460517753391; \n\tTue, 12 Apr 2016 20:22:33 -0700 (PDT)", "From": "Brian Walsh <brian@walsh.ws>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 12 Apr 2016 23:22:30 -0400", "Message-Id": "<a17942d94a295a0db7ef205060b97313289b1640.1460517387.git.brian@walsh.ws>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1455662685-7231-1-git-send-email-brian@walsh.ws>", "References": "<1455662685-7231-1-git-send-email-brian@walsh.ws>", "Subject": "[Intel-wired-lan] [PATCH v2 1/2] e1000e: Cleanup consistency in\n\tret_val variable usage", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Fixed the file to use a consistent ret_val for return value checking.\n\nSigned-off-by: Brian Walsh <brian@walsh.ws>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 9b4ec13..370b0dc 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -3368,12 +3368,12 @@ static int e1000e_write_uc_addr_list(struct net_device *netdev)\n \t\t * combining\n \t\t */\n \t\tnetdev_for_each_uc_addr(ha, netdev) {\n-\t\t\tint rval;\n+\t\t\tint ret_val;\n \n \t\t\tif (!rar_entries)\n \t\t\t\tbreak;\n-\t\t\trval = hw->mac.ops.rar_set(hw, ha->addr, rar_entries--);\n-\t\t\tif (rval < 0)\n+\t\t\tret_val = hw->mac.ops.rar_set(hw, ha->addr, rar_entries--);\n+\t\t\tif (ret_val < 0)\n \t\t\t\treturn -ENOMEM;\n \t\t\tcount++;\n \t\t}\n@@ -6965,7 +6965,7 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \tint bars, i, err, pci_using_dac;\n \tu16 eeprom_data = 0;\n \tu16 eeprom_apme_mask = E1000_EEPROM_APME;\n-\ts32 rval = 0;\n+\ts32 ret_val = 0;\n \n \tif (ei->flags2 & FLAG2_DISABLE_ASPM_L0S)\n \t\taspm_disable_flag = PCIE_LINK_STATE_L0S;\n@@ -7200,18 +7200,18 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t} else if (adapter->flags & FLAG_APME_IN_CTRL3) {\n \t\tif (adapter->flags & FLAG_APME_CHECK_PORT_B &&\n \t\t (adapter->hw.bus.func == 1))\n-\t\t\trval = e1000_read_nvm(&adapter->hw,\n+\t\t\tret_val = e1000_read_nvm(&adapter->hw,\n \t\t\t\t\t NVM_INIT_CONTROL3_PORT_B,\n \t\t\t\t\t 1, &eeprom_data);\n \t\telse\n-\t\t\trval = e1000_read_nvm(&adapter->hw,\n+\t\t\tret_val = e1000_read_nvm(&adapter->hw,\n \t\t\t\t\t NVM_INIT_CONTROL3_PORT_A,\n \t\t\t\t\t 1, &eeprom_data);\n \t}\n \n \t/* fetch WoL from EEPROM */\n-\tif (rval)\n-\t\te_dbg(\"NVM read error getting WoL initial values: %d\\n\", rval);\n+\tif (ret_val)\n+\t\te_dbg(\"NVM read error getting WoL initial values: %d\\n\", ret_val);\n \telse if (eeprom_data & eeprom_apme_mask)\n \t\tadapter->eeprom_wol |= E1000_WUFC_MAG;\n \n@@ -7231,10 +7231,10 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t\tdevice_wakeup_enable(&pdev->dev);\n \n \t/* save off EEPROM version number */\n-\trval = e1000_read_nvm(&adapter->hw, 5, 1, &adapter->eeprom_vers);\n+\tret_val = e1000_read_nvm(&adapter->hw, 5, 1, &adapter->eeprom_vers);\n \n-\tif (rval) {\n-\t\te_dbg(\"NVM read error getting EEPROM version: %d\\n\", rval);\n+\tif (ret_val) {\n+\t\te_dbg(\"NVM read error getting EEPROM version: %d\\n\", ret_val);\n \t\tadapter->eeprom_vers = 0;\n \t}\n \n", "prefixes": [ "v2", "1/2" ] }