Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/609820/?format=api
{ "id": 609820, "url": "http://patchwork.ozlabs.org/api/patches/609820/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1460475052-6348-14-git-send-email-harshitha.ramamurthy@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1460475052-6348-14-git-send-email-harshitha.ramamurthy@intel.com>", "list_archive_url": null, "date": "2016-04-12T15:30:52", "name": "[next,S33,13/13] i40evf: Add driver support for promiscuous mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5ab4a98c8582904473078f89e9e7628a0c4f7cb9", "submitter": { "id": 68642, "url": "http://patchwork.ozlabs.org/api/people/68642/?format=api", "name": "Harshitha Ramamurthy", "email": "harshitha.ramamurthy@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1460475052-6348-14-git-send-email-harshitha.ramamurthy@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/609820/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/609820/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 3ql3K42TtKz9sRZ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Apr 2016 09:38:16 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id A237D33236;\n\tTue, 12 Apr 2016 23:38:15 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id px6-SG0IGseo; Tue, 12 Apr 2016 23:38:10 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 86E623324D;\n\tTue, 12 Apr 2016 23:38:09 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id C71931C0E44\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 12 Apr 2016 23:38:07 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id BCB413304A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 12 Apr 2016 23:38:07 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id au4HsdFUyLra for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 12 Apr 2016 23:38:03 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8F153332CA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 12 Apr 2016 23:38:01 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP; 12 Apr 2016 16:36:31 -0700", "from harshitha-linux1.jf.intel.com ([10.166.45.81])\n\tby orsmga002.jf.intel.com with ESMTP; 12 Apr 2016 16:36:30 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,476,1455004800\"; d=\"scan'208\";a=\"953677420\"", "From": "Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 12 Apr 2016 08:30:52 -0700", "Message-Id": "<1460475052-6348-14-git-send-email-harshitha.ramamurthy@intel.com>", "X-Mailer": "git-send-email 2.4.3", "In-Reply-To": "<1460475052-6348-1-git-send-email-harshitha.ramamurthy@intel.com>", "References": "<1460475052-6348-1-git-send-email-harshitha.ramamurthy@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S33 13/13] i40evf: Add driver support\n\tfor promiscuous mode", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Anjali Singhai Jain <anjali.singhai@intel.com>\n\nAdd necessary Linux Ethernet driver support for promiscuous mode\noperation. Add a flag so the VF knows it is in promiscuous mode\nand two state flags to discreetly track multicast and unicast\npromiscuous states.\n\nSigned-off-by: Anjali Singhai Jain <anjali.singhai@intel.com>\nSigned-off-by: Greg Rose <gregory.v.rose@intel.com>\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nChange-Id: Ib2f2dc7a7582304fec90fc917ebb7ded21ba1de4\n---\nTesting Hints : Test using\nip link set dev eXX promisc on/off\non the vf\n\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 14 +++++++-------\n drivers/net/ethernet/intel/i40evf/i40evf.h | 3 +++\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 19 +++++++++++++++++++\n drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c | 11 +++++++++++\n 4 files changed, 40 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 33224ac..5be10cf 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1489,13 +1489,13 @@ static int i40e_vc_config_promiscuous_mode_msg(struct i40e_vf *vf,\n \t\t\t\t\t\t\t NULL);\n \t} else if (i40e_getnum_vf_vsi_vlan_filters(vsi)) {\n \t\tlist_for_each_entry(f, &vsi->mac_filter_list, list) {\n-\t\t\tif (f->vlan >= 0 && f->vlan <= I40E_MAX_VLANID)\n-\t\t\t\taq_ret = i40e_aq_set_vsi_mc_promisc_on_vlan\n-\t\t\t\t\t\t\t\t (hw,\n-\t\t\t\t\t\t\t\t vsi->seid,\n-\t\t\t\t\t\t\t\t allmulti,\n-\t\t\t\t\t\t\t\t f->vlan,\n-\t\t\t\t\t\t\t\t NULL);\n+\t\t\tif (f->vlan < 0 || f->vlan > I40E_MAX_VLANID)\n+\t\t\t\tcontinue;\n+\t\t\taq_ret = i40e_aq_set_vsi_mc_promisc_on_vlan(hw,\n+\t\t\t\t\t\t\t\t vsi->seid,\n+\t\t\t\t\t\t\t\t allmulti,\n+\t\t\t\t\t\t\t\t f->vlan,\n+\t\t\t\t\t\t\t\t NULL);\n \t\t\taq_err = pf->hw.aq.asq_last_status;\n \t\t\tif (aq_ret) {\n \t\t\t\tdev_err(&pf->pdev->dev,\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf.h b/drivers/net/ethernet/intel/i40evf/i40evf.h\nindex 63f7aae..3b8075f 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf.h\n@@ -220,6 +220,7 @@ struct i40evf_adapter {\n #define I40EVF_FLAG_WB_ON_ITR_CAPABLE\t\tBIT(11)\n #define I40EVF_FLAG_OUTER_UDP_CSUM_CAPABLE\tBIT(12)\n #define I40EVF_FLAG_ADDR_SET_BY_PF\t\tBIT(13)\n+#define I40EVF_FLAG_PROMISC_ON\t\t\t BIT(15)\n /* duplicates for common code */\n #define I40E_FLAG_FDIR_ATR_ENABLED\t\t 0\n #define I40E_FLAG_DCB_ENABLED\t\t\t 0\n@@ -244,6 +245,8 @@ struct i40evf_adapter {\n #define I40EVF_FLAG_AQ_SET_HENA\t\t\tBIT(12)\n #define I40EVF_FLAG_AQ_SET_RSS_KEY\t\tBIT(13)\n #define I40EVF_FLAG_AQ_SET_RSS_LUT\t\tBIT(14)\n+#define I40EVF_FLAG_AQ_REQUEST_PROMISC\t\tBIT(15)\n+#define I40EVF_FLAG_AQ_RELEASE_PROMISC\t\tBIT(16)\n \n \t/* OS defined structs */\n \tstruct net_device *netdev;\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex af53159..d1c4afd 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -943,6 +943,14 @@ static void i40evf_set_rx_mode(struct net_device *netdev)\n bottom_of_search_loop:\n \t\tcontinue;\n \t}\n+\n+\tif (netdev->flags & IFF_PROMISC &&\n+\t !(adapter->flags & I40EVF_FLAG_PROMISC_ON))\n+\t\tadapter->aq_required |= I40EVF_FLAG_AQ_REQUEST_PROMISC;\n+\telse if (!(netdev->flags & IFF_PROMISC) &&\n+\t\t adapter->flags & I40EVF_FLAG_PROMISC_ON)\n+\t\tadapter->aq_required |= I40EVF_FLAG_AQ_RELEASE_PROMISC;\n+\n \tclear_bit(__I40EVF_IN_CRITICAL_TASK, &adapter->crit_section);\n }\n \n@@ -1622,6 +1630,17 @@ static void i40evf_watchdog_task(struct work_struct *work)\n \t\tgoto watchdog_done;\n \t}\n \n+\tif (adapter->aq_required & I40EVF_FLAG_AQ_REQUEST_PROMISC) {\n+\t\ti40evf_set_promiscuous(adapter, I40E_FLAG_VF_UNICAST_PROMISC |\n+\t\t\t\t I40E_FLAG_VF_MULTICAST_PROMISC);\n+\t\tgoto watchdog_done;\n+\t}\n+\n+\tif (adapter->aq_required & I40EVF_FLAG_AQ_RELEASE_PROMISC) {\n+\t\ti40evf_set_promiscuous(adapter, 0);\n+\t\tgoto watchdog_done;\n+\t}\n+\n \tif (adapter->state == __I40EVF_RUNNING)\n \t\ti40evf_request_stats(adapter);\n watchdog_done:\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\nindex e62c56b..ba7fbc0 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n@@ -652,6 +652,17 @@ void i40evf_set_promiscuous(struct i40evf_adapter *adapter, int flags)\n \t\t\tadapter->current_op);\n \t\treturn;\n \t}\n+\n+\tif (flags) {\n+\t\tadapter->flags |= I40EVF_FLAG_PROMISC_ON;\n+\t\tadapter->aq_required &= ~I40EVF_FLAG_AQ_REQUEST_PROMISC;\n+\t\tdev_info(&adapter->pdev->dev, \"Entering promiscuous mode\\n\");\n+\t} else {\n+\t\tadapter->flags &= ~I40EVF_FLAG_PROMISC_ON;\n+\t\tadapter->aq_required &= ~I40EVF_FLAG_AQ_RELEASE_PROMISC;\n+\t\tdev_info(&adapter->pdev->dev, \"Leaving promiscuous mode\\n\");\n+\t}\n+\n \tadapter->current_op = I40E_VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE;\n \tvpi.vsi_id = adapter->vsi_res->vsi_id;\n \tvpi.flags = flags;\n", "prefixes": [ "next", "S33", "13/13" ] }