Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/607597/?format=api
{ "id": 607597, "url": "http://patchwork.ozlabs.org/api/patches/607597/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160407174350.39412.3975.stgit@mdrustad-wks.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160407174350.39412.3975.stgit@mdrustad-wks.jf.intel.com>", "list_archive_url": null, "date": "2016-04-07T17:43:50", "name": "ixgbe: Add register wait for slow links", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "98ae387a1fa3b41382e5659fe5abca50ebffcc12", "submitter": { "id": 13252, "url": "http://patchwork.ozlabs.org/api/people/13252/?format=api", "name": "Rustad, Mark D", "email": "mark.d.rustad@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160407174350.39412.3975.stgit@mdrustad-wks.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/607597/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/607597/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 3qgqhV71pgz9sdm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Apr 2016 03:43:54 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 19A84849BF;\n\tThu, 7 Apr 2016 17:43:54 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mDjw3J2hwHFX; Thu, 7 Apr 2016 17:43:53 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7B70F816DE;\n\tThu, 7 Apr 2016 17:43:53 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id BE3681C11AF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Apr 2016 17:43:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B8FFC824DA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Apr 2016 17:43:51 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id oc2dIh+FWYtm for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Apr 2016 17:43:51 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1FE97816DE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Apr 2016 17:43:51 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP; 07 Apr 2016 10:43:51 -0700", "from mdrustad-wks.jf.intel.com ([134.134.3.71])\n\tby orsmga001.jf.intel.com with ESMTP; 07 Apr 2016 10:43:50 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,449,1455004800\"; d=\"scan'208\";a=\"927710984\"", "From": "Mark D Rustad <mark.d.rustad@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 07 Apr 2016 10:43:50 -0700", "Message-ID": "<20160407174350.39412.3975.stgit@mdrustad-wks.jf.intel.com>", "User-Agent": "StGit/unknown-version", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Add register wait for slow links", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Use a new register to wait for previous register writes to complete\nbefore issuing a register read. This is needed when slower links\nare in use.\n\nSigned-off-by: Mark Rustad <mark.d.rustad@intel.com>\n---\nTesting-hints:\n- Test that x550em_a devices operate at lower speeds without complaint\n- Test that x550em_a devices do not suffer throughput loss with fast links\n- Test that X550EM_x, X550 and other devices operate normally\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 21 +++++++++++++++++++++\n drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 1 +\n 2 files changed, 22 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex cf95f8098f1f..bb21186d5b50 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -370,6 +370,27 @@ u32 ixgbe_read_reg(struct ixgbe_hw *hw, u32 reg)\n \n \tif (ixgbe_removed(reg_addr))\n \t\treturn IXGBE_FAILED_READ_REG;\n+\tif (unlikely(hw->phy.nw_mng_if_sel &\n+\t\t IXGBE_NW_MNG_IF_SEL_ENABLE_10_100M)) {\n+\t\tstruct ixgbe_adapter *adapter;\n+\t\tint i;\n+\n+\t\tfor (i = 0; i < 200; ++i) {\n+\t\t\tvalue = readl(reg_addr + IXGBE_MAC_SGMII_BUSY);\n+\t\t\tif (likely(!value))\n+\t\t\t\tgoto writes_completed;\n+\t\t\tif (value == IXGBE_FAILED_READ_REG) {\n+\t\t\t\tixgbe_remove_adapter(hw);\n+\t\t\t\treturn IXGBE_FAILED_READ_REG;\n+\t\t\t}\n+\t\t\tudelay(5);\n+\t\t}\n+\n+\t\tadapter = hw->back;\n+\t\te_warn(hw, \"register writes incomplete %08x\\n\", value);\n+\t}\n+\n+writes_completed:\n \tvalue = readl(reg_addr + reg);\n \tif (unlikely(value == IXGBE_FAILED_READ_REG))\n \t\tixgbe_check_remove(hw, reg);\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\nindex af43b0c9c6c4..1ba2c21d4a2b 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\n@@ -1130,6 +1130,7 @@ struct ixgbe_thermal_sensor_data {\n #define IXGBE_XPCSS 0x04290\n #define IXGBE_MFLCN 0x04294\n #define IXGBE_SERDESC 0x04298\n+#define IXGBE_MAC_SGMII_BUSY 0x04298\n #define IXGBE_MACS 0x0429C\n #define IXGBE_AUTOC 0x042A0\n #define IXGBE_LINKS 0x042A4\n", "prefixes": [] }