Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/607448/?format=api
{ "id": 607448, "url": "http://patchwork.ozlabs.org/api/patches/607448/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1460042483-16169-3-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1460042483-16169-3-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-04-07T15:21:22", "name": "[v1,3/4] fm10k: fix fm10k_add_ethtool_stats to zero memory", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "928ecc65e4e7ad7082bc45040184fb15914bbbc9", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1460042483-16169-3-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/607448/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/607448/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 3qgmXL3tByz9t3t\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Apr 2016 01:21:37 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DB02EC0175;\n\tThu, 7 Apr 2016 15:21:35 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CyMwHiFClr8L; Thu, 7 Apr 2016 15:21:35 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 18B02847B7;\n\tThu, 7 Apr 2016 15:21:29 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id BDA1F1C11AF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Apr 2016 15:21:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 91C138CD82\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Apr 2016 15:21:27 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id yvEf9e2VEKDb for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Apr 2016 15:21:26 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E8EDD86932\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Apr 2016 15:21:26 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP; 07 Apr 2016 08:21:25 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.173])\n\tby orsmga001.jf.intel.com with ESMTP; 07 Apr 2016 08:21:26 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,449,1455004800\"; d=\"scan'208\";a=\"927603920\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Thu, 7 Apr 2016 08:21:22 -0700", "Message-Id": "<1460042483-16169-3-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.8.1.102.ga49ec4a", "In-Reply-To": "<1460042483-16169-1-git-send-email-jacob.e.keller@intel.com>", "References": "<1460042483-16169-1-git-send-email-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [PATCH v1 3/4] fm10k: fix fm10k_add_ethtool_stats\n\tto zero memory", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The ethtool API does not guarantee zero'd memory, so we need to zero the\nstats we skip instead of just skipping them.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n\nNotes:\n Testing-hints:\n Ensure that the queue stats don't show random memory values, but always zero\n if they are unused.\n \n Unfortunately, somehow Dave Miller pulled an incorrect version of the original\n for this patch, so this is a follow-on fixup which brings back the bug fix.\n\n drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\nindex b4870b8ad0bd..9c0d87503977 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\n@@ -243,9 +243,10 @@ static void fm10k_add_ethtool_stats(u64 **data, void *pointer,\n \tunsigned int i;\n \tchar *p;\n \n-\t/* simply skip forward if we were not given a valid pointer */\n \tif (!pointer) {\n-\t\t*data += size;\n+\t\t/* memory is not zero allocated so we have to clear it */\n+\t\tfor (i = 0; i < size; i++)\n+\t\t\t*((*data)++) = 0;\n \t\treturn;\n \t}\n \n", "prefixes": [ "v1", "3/4" ] }