Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/606677/?format=api
{ "id": 606677, "url": "http://patchwork.ozlabs.org/api/patches/606677/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1459881004-13992-1-git-send-email-danielwa@cisco.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1459881004-13992-1-git-send-email-danielwa@cisco.com>", "list_archive_url": null, "date": "2016-04-05T18:30:03", "name": "[-v2] drivers: net: ethernet: intel: e1000e: fix ethtool autoneg off for non-copper", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "689b955e0771e4e229276292345f66ece2d137e2", "submitter": { "id": 67374, "url": "http://patchwork.ozlabs.org/api/people/67374/?format=api", "name": "Daniel Walker (danielwa)", "email": "danielwa@cisco.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1459881004-13992-1-git-send-email-danielwa@cisco.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/606677/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/606677/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 3qfdNg1Z5Gz9t3Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 6 Apr 2016 04:56:03 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 846E88C065;\n\tTue, 5 Apr 2016 18:56:02 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Bi4qA4DoUzwF; Tue, 5 Apr 2016 18:56:00 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 19A418788E;\n\tTue, 5 Apr 2016 18:55:59 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5409B1C10F5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 5 Apr 2016 18:30:08 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4BE1E8B65A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 5 Apr 2016 18:30:08 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kSso7A1GPASh for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 5 Apr 2016 18:30:07 +0000 (UTC)", "from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 6B5D18B019\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 5 Apr 2016 18:30:07 +0000 (UTC)", "from rcdn-core-12.cisco.com ([173.37.93.148])\n\tby rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Apr 2016 18:30:05 +0000", "from zorba.cisco.com ([10.24.33.135])\n\tby rcdn-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id\n\tu35IU3OV002155; Tue, 5 Apr 2016 18:30:04 GMT" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=cisco.com header.i=@cisco.com header.b=IxP4xWH/;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=1821; q=dns/txt; s=iport;\n\tt=1459881007; x=1461090607;\n\th=from:to:cc:subject:date:message-id;\n\tbh=jZUVzFLSwcgFEKc18KtQPUKn7hr8TAFFGOxNcKSK9/A=;\n\tb=IxP4xWH/8zBj0lfAKhjDDIWuhBVuIaQxXHZdfdVCkA3XArvA13Ye1gzl\n\t4O/SLqtcmdMPUyVyExLsiBgGS9Mh4azIgRFn+Wr2T170RVav8iu4ERCXh\n\t4suaHfDCipDdBsTrkJ5K01CBfgoWVxblgvq46pFlTdF5lqY6q6HeDAgVZ E=;", "X-IronPort-AV": "E=Sophos;i=\"5.24,445,1454976000\"; d=\"scan'208\";a=\"90346472\"", "From": "Daniel Walker <danielwa@cisco.com>", "To": "dima.ruinskiy@intel.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tJesse Brandeburg <jesse.brandeburg@intel.com>,\n\tShannon Nelson <shannon.nelson@intel.com>,\n\tCarolyn Wyborny <carolyn.wyborny@intel.com>,\n\tDon Skidmore <donald.c.skidmore@intel.com>,\n\tBruce Allan <bruce.w.allan@intel.com>,\n\tJohn Ronciak <john.ronciak@intel.com>,\n\tMitch Williams <mitch.a.williams@intel.com>", "Date": "Tue, 5 Apr 2016 11:30:03 -0700", "Message-Id": "<1459881004-13992-1-git-send-email-danielwa@cisco.com>", "X-Mailer": "git-send-email 2.5.0", "X-Auto-Response-Suppress": "DR, OOF, AutoReply", "X-Mailman-Approved-At": "Tue, 05 Apr 2016 18:55:55 +0000", "Cc": "netdev@vger.kernel.org, xe-kernel@external.cisco.com,\n\tlinux-kernel@vger.kernel.org, Steve Shih <sshih@cisco.com>,\n\tintel-wired-lan@lists.osuosl.org, Daniel Walker <dwalker@fifo99.com>", "Subject": "[Intel-wired-lan] [PATCH -v2] drivers: net: ethernet: intel:\n\te1000e: fix ethtool autoneg off for non-copper", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Steve Shih <sshih@cisco.com>\n\nThis patch fixes the issues for disabling auto-negotiation and forcing\nspeed and duplex settings for the non-copper media.\n\nFor non-copper media, e1000_get_settings should return ETH_TP_MDI_INVALID for\neth_tp_mdix_ctrl instead of ETH_TP_MDI_AUTO so subsequent e1000_set_settings\ncall would not fail with -EOPNOTSUPP.\n\ne1000_set_spd_dplx should not automatically turn autoneg back on for forced\n1000 Mbps full duplex settings for non-copper media.\n\nCc: xe-kernel@external.cisco.com\nCc: Daniel Walker <dwalker@fifo99.com>\nSigned-off-by: Steve Shih <sshih@cisco.com>\n---\n drivers/net/ethernet/intel/e1000e/ethtool.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c\nindex 6cab1f3..b6b8290 100644\n--- a/drivers/net/ethernet/intel/e1000e/ethtool.c\n+++ b/drivers/net/ethernet/intel/e1000e/ethtool.c\n@@ -201,6 +201,9 @@ static int e1000_get_settings(struct net_device *netdev,\n \telse\n \t\tecmd->eth_tp_mdix_ctrl = hw->phy.mdix;\n \n+\tif (hw->phy.media_type != e1000_media_type_copper)\n+\t\tecmd->eth_tp_mdix_ctrl = ETH_TP_MDI_INVALID;\n+\n \treturn 0;\n }\n \n@@ -236,8 +239,12 @@ static int e1000_set_spd_dplx(struct e1000_adapter *adapter, u32 spd, u8 dplx)\n \t\tmac->forced_speed_duplex = ADVERTISE_100_FULL;\n \t\tbreak;\n \tcase SPEED_1000 + DUPLEX_FULL:\n-\t\tmac->autoneg = 1;\n-\t\tadapter->hw.phy.autoneg_advertised = ADVERTISE_1000_FULL;\n+\t\tif (adapter->hw.phy.media_type == e1000_media_type_copper) {\n+\t\t\tmac->autoneg = 1;\n+\t\t\tadapter->hw.phy.autoneg_advertised =\n+\t\t\t\tADVERTISE_1000_FULL;\n+\t\t} else\n+\t\t\tmac->forced_speed_duplex = ADVERTISE_1000_FULL;\n \t\tbreak;\n \tcase SPEED_1000 + DUPLEX_HALF:\t/* not supported */\n \tdefault:\n", "prefixes": [ "-v2" ] }