Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/605075/?format=api
{ "id": 605075, "url": "http://patchwork.ozlabs.org/api/patches/605075/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1459552659-22959-4-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1459552659-22959-4-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-04-01T23:17:33", "name": "[v1,3/9] fm10k: correctly handle LPORT_MAP error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2fe8819ec81da5666d737c54844697dd147050e3", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1459552659-22959-4-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/605075/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/605075/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 3qcHNc3v3Xz9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Apr 2016 10:17:52 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id AF3E791F77;\n\tFri, 1 Apr 2016 23:17:51 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Oc5Q4W3MRyWg; Fri, 1 Apr 2016 23:17:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8F67B91F8A;\n\tFri, 1 Apr 2016 23:17:48 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2A1171C11DF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 23:17:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 26E659573F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 23:17:44 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JDwtUJEzlVYN for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 23:17:43 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id EDDE8956D2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 23:17:42 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga104.fm.intel.com with ESMTP; 01 Apr 2016 16:17:42 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.173])\n\tby fmsmga002.fm.intel.com with ESMTP; 01 Apr 2016 16:17:42 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,428,1455004800\"; d=\"scan'208\";a=\"949958938\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Fri, 1 Apr 2016 16:17:33 -0700", "Message-Id": "<1459552659-22959-4-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.8.0.rc1.177.g5628860", "In-Reply-To": "<1459552659-22959-1-git-send-email-jacob.e.keller@intel.com>", "References": "<1459552659-22959-1-git-send-email-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [PATCH v1 3/9] fm10k: correctly handle LPORT_MAP\n\terror", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Currently, any error responses from the switch manager after an\nLPORT_MAP request are silently ignored. At most the mailbox message will\nbe reported as an error. This can result in unexpected behavior when the\nswitch manager has configured a port with zero bandwidth. Add support\nfor reading the fm10k_swapi_error structure from LPORT_MAP responses.\n\nIf the message contains the necessary TLV and has a non-zero error code,\nreport link down, clear the dglort_map, and delay the next\nget_host_state call by a reasonable delay. Also log an error message\nindicating that the LPORT_MAP request failed.\n\nThe delay ensures preventing an interrupt storm on the switch manager,\nand reduces the number of mailbox messages we send in this scenario\ndrastically.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k.h | 1 +\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 31 +++++++++++++++++++++++++++-\n drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 2 ++\n drivers/net/ethernet/intel/fm10k/fm10k_pf.h | 2 ++\n 4 files changed, 35 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k.h b/drivers/net/ethernet/intel/fm10k/fm10k.h\nindex c21fa8699fc4..5efae40698cc 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k.h\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k.h\n@@ -330,6 +330,7 @@ struct fm10k_intfc {\n \tunsigned long last_reset;\n \tunsigned long link_down_event;\n \tbool host_ready;\n+\tbool lport_map_failed;\n \n \tu32 reta[FM10K_RETA_SIZE];\n \tu32 rssrk[FM10K_RSSRK_SIZE];\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex 29e9402c4352..9055681cf34d 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -1263,11 +1263,40 @@ static s32 fm10k_lport_map(struct fm10k_hw *hw, u32 **results,\n \tu32 dglort_map = hw->mac.dglort_map;\n \ts32 err;\n \n+\tinterface = container_of(hw, struct fm10k_intfc, hw);\n+\n+\terr = fm10k_msg_err_pf(hw, results, mbx);\n+\tif (!err && hw->swapi.status) {\n+\t\t/* force link down for a reasonable delay */\n+\t\tinterface->link_down_event = jiffies + (2 * HZ);\n+\t\tset_bit(__FM10K_LINK_DOWN, &interface->state);\n+\n+\t\t/* reset dglort_map back to no config */\n+\t\thw->mac.dglort_map = FM10K_DGLORTMAP_NONE;\n+\n+\t\tfm10k_service_event_schedule(interface);\n+\n+\t\t/* prevent overloading kernel message buffer */\n+\t\tif (interface->lport_map_failed)\n+\t\t\treturn 0;\n+\n+\t\tinterface->lport_map_failed = true;\n+\n+\t\tif (hw->swapi.status == FM10K_MSG_ERR_PEP_NOT_SCHEDULED)\n+\t\t\tdev_warn(&interface->pdev->dev,\n+\t\t\t\t \"cannot obtain link because the host interface is configured for a PCIe host interface bandwidth of zero\\n\");\n+\t\tdev_warn(&interface->pdev->dev,\n+\t\t\t \"request logical port map failed: %d\\n\",\n+\t\t\t hw->swapi.status);\n+\n+\t\treturn 0;\n+\t}\n+\n \terr = fm10k_msg_lport_map_pf(hw, results, mbx);\n \tif (err)\n \t\treturn err;\n \n-\tinterface = container_of(hw, struct fm10k_intfc, hw);\n+\tinterface->lport_map_failed = false;\n \n \t/* we need to reset if port count was just updated */\n \tif (dglort_map != hw->mac.dglort_map)\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\nindex c8e8ce5a8327..865f5c2da9d0 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n@@ -1620,6 +1620,8 @@ out:\n \n /* This structure defines the attibutes to be parsed below */\n const struct fm10k_tlv_attr fm10k_lport_map_msg_attr[] = {\n+\tFM10K_TLV_ATTR_LE_STRUCT(FM10K_PF_ATTR_ID_ERR,\n+\t\t\t\t sizeof(struct fm10k_swapi_error)),\n \tFM10K_TLV_ATTR_U32(FM10K_PF_ATTR_ID_LPORT_MAP),\n \tFM10K_TLV_ATTR_LAST\n };\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pf.h b/drivers/net/ethernet/intel/fm10k/fm10k_pf.h\nindex b78210d06213..d4a34657b861 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pf.h\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pf.h\n@@ -71,6 +71,8 @@ enum fm10k_pf_tlv_attr_id_v1 {\n #define FM10K_MSG_UPDATE_PVID_PVID_SHIFT\t16\n #define FM10K_MSG_UPDATE_PVID_PVID_SIZE\t\t16\n \n+#define FM10K_MSG_ERR_PEP_NOT_SCHEDULED\t280\n+\n /* The following data structures are overlayed directly onto TLV mailbox\n * messages, and must not break 4 byte alignment. Ensure the structures line\n * up correctly as per their TLV definition.\n", "prefixes": [ "v1", "3/9" ] }