Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/605072/?format=api
{ "id": 605072, "url": "http://patchwork.ozlabs.org/api/patches/605072/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1459552659-22959-3-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1459552659-22959-3-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-04-01T23:17:32", "name": "[v1,2/9] fm10k: Fix multicast mode sync issues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4a83bd675094fbbe4d60d0ca10910337822cfcdb", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1459552659-22959-3-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/605072/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/605072/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 3qcHNY6ch0z9ssP\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Apr 2016 10:17:49 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 18EAC91F94;\n\tFri, 1 Apr 2016 23:17:49 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id E-PGwsSIV1Or; Fri, 1 Apr 2016 23:17:46 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0864191F6A;\n\tFri, 1 Apr 2016 23:17:45 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id BBC3D1C11DF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 23:17:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B6ED995742\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 23:17:43 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1u92sekf13Ox for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 23:17:42 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D1C57956CB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 23:17:42 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga104.fm.intel.com with ESMTP; 01 Apr 2016 16:17:42 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.173])\n\tby fmsmga002.fm.intel.com with ESMTP; 01 Apr 2016 16:17:41 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,428,1455004800\"; d=\"scan'208\";a=\"949958935\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Fri, 1 Apr 2016 16:17:32 -0700", "Message-Id": "<1459552659-22959-3-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.8.0.rc1.177.g5628860", "In-Reply-To": "<1459552659-22959-1-git-send-email-jacob.e.keller@intel.com>", "References": "<1459552659-22959-1-git-send-email-jacob.e.keller@intel.com>", "Cc": "Ngai-Mint Kwan <ngai-mint.kwan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH v1 2/9] fm10k: Fix multicast mode sync\n\tissues", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Ngai-Mint Kwan <ngai-mint.kwan@intel.com>\n\nMulticast mode checking is no longer a requirement to perform unicast\nand multicast address syncs. Specifically, a device operating in\npromiscuous and/or all multicast mode is not excluded. The issue occurs\nwhen the netdev is pre-configured to either multicast mode and is\nenabled for the first time. The multicast-group table in the Switch\nManager will be missing obvious multicast entries associated to this\nnetdev.\n\nChanges were also made to disallow unicast and multicast syncs with\nVLAN 0. The Switch Manager considers VLAN 0 to be an invalid entry.\nRequests with VLAN 0 by the netdev are only generated when the driver is\nfreshly installed and the default VID is not set.\n\nSigned-off-by: Ngai-Mint Kwan <ngai-mint.kwan@intel.com>\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 20 +++++++-------------\n 1 file changed, 7 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\nindex 32778dda8c12..bf229d54c20c 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n@@ -877,7 +877,7 @@ static int __fm10k_uc_sync(struct net_device *dev,\n \t\treturn -EADDRNOTAVAIL;\n \n \t/* update table with current entries */\n-\tfor (vid = hw->mac.default_vid ? fm10k_find_next_vlan(interface, 0) : 0;\n+\tfor (vid = hw->mac.default_vid ? fm10k_find_next_vlan(interface, 0) : 1;\n \t vid < VLAN_N_VID;\n \t vid = fm10k_find_next_vlan(interface, vid)) {\n \t\terr = hw->mac.ops.update_uc_addr(hw, glort, addr,\n@@ -940,7 +940,7 @@ static int __fm10k_mc_sync(struct net_device *dev,\n \tu16 vid, glort = interface->glort;\n \n \t/* update table with current entries */\n-\tfor (vid = hw->mac.default_vid ? fm10k_find_next_vlan(interface, 0) : 0;\n+\tfor (vid = hw->mac.default_vid ? fm10k_find_next_vlan(interface, 0) : 1;\n \t vid < VLAN_N_VID;\n \t vid = fm10k_find_next_vlan(interface, vid)) {\n \t\thw->mac.ops.update_mc_addr(hw, glort, addr, vid, sync);\n@@ -995,11 +995,8 @@ static void fm10k_set_rx_mode(struct net_device *dev)\n \t}\n \n \t/* synchronize all of the addresses */\n-\tif (xcast_mode != FM10K_XCAST_MODE_PROMISC) {\n-\t\t__dev_uc_sync(dev, fm10k_uc_sync, fm10k_uc_unsync);\n-\t\tif (xcast_mode != FM10K_XCAST_MODE_ALLMULTI)\n-\t\t\t__dev_mc_sync(dev, fm10k_mc_sync, fm10k_mc_unsync);\n-\t}\n+\t__dev_uc_sync(dev, fm10k_uc_sync, fm10k_uc_unsync);\n+\t__dev_mc_sync(dev, fm10k_mc_sync, fm10k_mc_unsync);\n \n \tfm10k_mbx_unlock(interface);\n }\n@@ -1037,7 +1034,7 @@ void fm10k_restore_rx_state(struct fm10k_intfc *interface)\n \thw->mac.ops.update_vlan(hw, 0, 0, true);\n \n \t/* update table with current entries */\n-\tfor (vid = hw->mac.default_vid ? fm10k_find_next_vlan(interface, 0) : 0;\n+\tfor (vid = hw->mac.default_vid ? fm10k_find_next_vlan(interface, 0) : 1;\n \t vid < VLAN_N_VID;\n \t vid = fm10k_find_next_vlan(interface, vid)) {\n \t\thw->mac.ops.update_vlan(hw, vid, 0, true);\n@@ -1049,11 +1046,8 @@ void fm10k_restore_rx_state(struct fm10k_intfc *interface)\n \thw->mac.ops.update_xcast_mode(hw, glort, xcast_mode);\n \n \t/* synchronize all of the addresses */\n-\tif (xcast_mode != FM10K_XCAST_MODE_PROMISC) {\n-\t\t__dev_uc_sync(netdev, fm10k_uc_sync, fm10k_uc_unsync);\n-\t\tif (xcast_mode != FM10K_XCAST_MODE_ALLMULTI)\n-\t\t\t__dev_mc_sync(netdev, fm10k_mc_sync, fm10k_mc_unsync);\n-\t}\n+\t__dev_uc_sync(netdev, fm10k_uc_sync, fm10k_uc_unsync);\n+\t__dev_mc_sync(netdev, fm10k_mc_sync, fm10k_mc_unsync);\n \n \tfm10k_mbx_unlock(interface);\n \n", "prefixes": [ "v1", "2/9" ] }