Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/605071/?format=api
{ "id": 605071, "url": "http://patchwork.ozlabs.org/api/patches/605071/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1459552659-22959-8-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1459552659-22959-8-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-04-01T23:17:37", "name": "[v1,7/9] fm10k: use different name than FM10K_VLAN_CLEAR for override bit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3ca593d5403de9ba4cd5ebbc9cd09a3bef48185a", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1459552659-22959-8-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/605071/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/605071/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 3qcHNX6gd0z9t3c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Apr 2016 10:17:48 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4454D91F55;\n\tFri, 1 Apr 2016 23:17:48 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id NaXo88jQ87df; Fri, 1 Apr 2016 23:17:46 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 29E4391F73;\n\tFri, 1 Apr 2016 23:17:45 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id DEDF81C11DF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 23:17:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DB61795742\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 23:17:43 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kt0+PB9hq4UX for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 23:17:43 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6AC6F9573F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 23:17:43 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga104.fm.intel.com with ESMTP; 01 Apr 2016 16:17:42 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.173])\n\tby fmsmga002.fm.intel.com with ESMTP; 01 Apr 2016 16:17:42 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,428,1455004800\"; d=\"scan'208\";a=\"949958954\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Fri, 1 Apr 2016 16:17:37 -0700", "Message-Id": "<1459552659-22959-8-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.8.0.rc1.177.g5628860", "In-Reply-To": "<1459552659-22959-1-git-send-email-jacob.e.keller@intel.com>", "References": "<1459552659-22959-1-git-send-email-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [PATCH v1 7/9] fm10k: use different name than\n\tFM10K_VLAN_CLEAR for override bit", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Use a new #define FM10K_VLAN_OVERRIDE even though we're using the exact\nsame bit. The reason for this is clarity in the code, otherwise you can\nread FM10K_VLAN_CLEAR and think it should be removed. Also add a comment\nexplaining why the FM10K_VLAN_OVERRIDE bit is set.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 8 ++++++--\n drivers/net/ethernet/intel/fm10k/fm10k_type.h | 1 +\n drivers/net/ethernet/intel/fm10k/fm10k_vf.c | 2 +-\n 3 files changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\nindex ffe98056755b..88d5acf484d0 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n@@ -864,9 +864,13 @@ static s32 fm10k_iov_assign_default_mac_vlan_pf(struct fm10k_hw *hw,\n \tfm10k_write_reg(hw, FM10K_TQMAP(qmap_idx), 0);\n \tfm10k_write_reg(hw, FM10K_TXDCTL(vf_q_idx), 0);\n \n-\t/* determine correct default VLAN ID */\n+\t/* Determine correct default VLAN ID. The FM10K_VLAN_OVERRIDE bit is\n+\t * used here to indicate to the VF that it will not have privilege to\n+\t * write VLAN_TABLE. All policy is enforced on the PF but this allows\n+\t * the VF to correctly report errors to userspace rqeuests.\n+\t */\n \tif (vf_info->pf_vid)\n-\t\tvf_vid = vf_info->pf_vid | FM10K_VLAN_CLEAR;\n+\t\tvf_vid = vf_info->pf_vid | FM10K_VLAN_OVERRIDE;\n \telse\n \t\tvf_vid = vf_info->sw_vid;\n \ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_type.h b/drivers/net/ethernet/intel/fm10k/fm10k_type.h\nindex 995dceefec25..f3f37a49806e 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_type.h\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_type.h\n@@ -350,6 +350,7 @@ struct fm10k_hw;\n #define FM10K_VLAN_TABLE_VSI_MAX\t\t64\n #define FM10K_VLAN_LENGTH_SHIFT\t\t\t16\n #define FM10K_VLAN_CLEAR\t\t\tBIT(15)\n+#define FM10K_VLAN_OVERRIDE\t\t\tFM10K_VLAN_CLEAR\n #define FM10K_VLAN_ALL \\\n \t((FM10K_VLAN_TABLE_VID_MAX - 1) << FM10K_VLAN_LENGTH_SHIFT)\n \ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_vf.c b/drivers/net/ethernet/intel/fm10k/fm10k_vf.c\nindex 86c358c37d3f..801238dec624 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_vf.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_vf.c\n@@ -228,7 +228,7 @@ s32 fm10k_msg_mac_vlan_vf(struct fm10k_hw *hw, u32 **results,\n \n \tether_addr_copy(hw->mac.perm_addr, perm_addr);\n \thw->mac.default_vid = vid & (FM10K_VLAN_TABLE_VID_MAX - 1);\n-\thw->mac.vlan_override = !!(vid & FM10K_VLAN_CLEAR);\n+\thw->mac.vlan_override = !!(vid & FM10K_VLAN_OVERRIDE);\n \n \treturn 0;\n }\n", "prefixes": [ "v1", "7/9" ] }