Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/604969/?format=api
{ "id": 604969, "url": "http://patchwork.ozlabs.org/api/patches/604969/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1459508173-22777-7-git-send-email-harshitha.ramamurthy@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1459508173-22777-7-git-send-email-harshitha.ramamurthy@intel.com>", "list_archive_url": null, "date": "2016-04-01T10:56:06", "name": "[v3,next,S32,06/13] i40e/i40evf: Faster RX via avoiding fcoe", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "71b5a6d9d37f0d53eddb7c9b2a88634883fc0e99", "submitter": { "id": 68642, "url": "http://patchwork.ozlabs.org/api/people/68642/?format=api", "name": "Harshitha Ramamurthy", "email": "harshitha.ramamurthy@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1459508173-22777-7-git-send-email-harshitha.ramamurthy@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/604969/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/604969/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 3qc9jB1Xchz9sf6\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Apr 2016 06:01:50 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 83CBC958DC;\n\tFri, 1 Apr 2016 19:01:49 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9NW-u7npWzam; Fri, 1 Apr 2016 19:01:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 39C3795935;\n\tFri, 1 Apr 2016 19:01:48 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 15BA71BF9E4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 19:01:45 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1089E91F26\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 19:01:45 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lMHahd-Qmqfl for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 19:01:44 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id AC6D791F0E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Apr 2016 19:01:43 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga102.jf.intel.com with ESMTP; 01 Apr 2016 12:01:43 -0700", "from harshitha-linux1.jf.intel.com ([10.166.45.81])\n\tby fmsmga001.fm.intel.com with ESMTP; 01 Apr 2016 12:01:43 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,428,1455004800\"; d=\"scan'208\";a=\"936472993\"", "From": "Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 1 Apr 2016 03:56:06 -0700", "Message-Id": "<1459508173-22777-7-git-send-email-harshitha.ramamurthy@intel.com>", "X-Mailer": "git-send-email 2.4.3", "In-Reply-To": "<1459508173-22777-1-git-send-email-harshitha.ramamurthy@intel.com>", "References": "<1459508173-22777-1-git-send-email-harshitha.ramamurthy@intel.com>", "Subject": "[Intel-wired-lan] [v3 next PATCH S32 06/13] i40e/i40evf: Faster RX\n\tvia avoiding fcoe", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nAs it turns out, calling into other files from hot path hurts\nperformance a lot. In this case the majority of the time we\ncall \"check fcoe\" and the packet is *not* fcoe, but this call\nwas taking 5% of our total cycles spent on receive.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nChange-ID: I080552c26e7060bc7b78504dc2763f6f0b3d8c76\n---\nTesting Hints: Make sure RX still works, and that\nperf top doesn't show i40e_handle_fcoe_status.\n\n drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 12 +-----------\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 8 ++++++--\n drivers/net/ethernet/intel/i40e/i40e_txrx.h | 10 ++++++++++\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 4 +++-\n drivers/net/ethernet/intel/i40evf/i40e_txrx.h | 10 ++++++++++\n 5 files changed, 30 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c\nindex 92d2208..58e6c15 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c\n@@ -1,7 +1,7 @@\n /*******************************************************************************\n *\n * Intel Ethernet Controller XL710 Family Linux Driver\n- * Copyright(c) 2013 - 2015 Intel Corporation.\n+ * Copyright(c) 2013 - 2016 Intel Corporation.\n *\n * This program is free software; you can redistribute it and/or modify it\n * under the terms and conditions of the GNU General Public License,\n@@ -38,16 +38,6 @@\n #include \"i40e_fcoe.h\"\n \n /**\n- * i40e_rx_is_fcoe - returns true if the rx packet type is FCoE\n- * @ptype: the packet type field from rx descriptor write-back\n- **/\n-static inline bool i40e_rx_is_fcoe(u16 ptype)\n-{\n-\treturn (ptype >= I40E_RX_PTYPE_L2_FCOE_PAY3) &&\n-\t (ptype <= I40E_RX_PTYPE_L2_FCOE_VFT_FCOTHER);\n-}\n-\n-/**\n * i40e_fcoe_sof_is_class2 - returns true if this is a FC Class 2 SOF\n * @sof: the FCoE start of frame delimiter\n **/\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex f4e4d3d..29ffed2 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -1703,7 +1703,9 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, const int budget)\n \t\t\t ? le16_to_cpu(rx_desc->wb.qword0.lo_dword.l2tag1)\n \t\t\t : 0;\n #ifdef I40E_FCOE\n-\t\tif (!i40e_fcoe_handle_offload(rx_ring, rx_desc, skb)) {\n+\t\tif (unlikely(\n+\t\t i40e_rx_is_fcoe(rx_ptype) &&\n+\t\t !i40e_fcoe_handle_offload(rx_ring, rx_desc, skb))) {\n \t\t\tdev_kfree_skb_any(skb);\n \t\t\tcontinue;\n \t\t}\n@@ -1834,7 +1836,9 @@ static int i40e_clean_rx_irq_1buf(struct i40e_ring *rx_ring, int budget)\n \t\t\t ? le16_to_cpu(rx_desc->wb.qword0.lo_dword.l2tag1)\n \t\t\t : 0;\n #ifdef I40E_FCOE\n-\t\tif (!i40e_fcoe_handle_offload(rx_ring, rx_desc, skb)) {\n+\t\tif (unlikely(\n+\t\t i40e_rx_is_fcoe(rx_ptype) &&\n+\t\t !i40e_fcoe_handle_offload(rx_ring, rx_desc, skb))) {\n \t\t\tdev_kfree_skb_any(skb);\n \t\t\tcontinue;\n \t\t}\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.h b/drivers/net/ethernet/intel/i40e/i40e_txrx.h\nindex 681e9bc..4b08d47 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.h\n@@ -448,4 +448,14 @@ static inline bool i40e_chk_linearize(struct sk_buff *skb, int count)\n \n \treturn __i40e_chk_linearize(skb);\n }\n+\n+/**\n+ * i40e_rx_is_fcoe - returns true if the rx packet type is FCoE\n+ * @ptype: the packet type field from rx descriptor write-back\n+ **/\n+static inline bool i40e_rx_is_fcoe(u16 ptype)\n+{\n+\treturn (ptype >= I40E_RX_PTYPE_L2_FCOE_PAY3) &&\n+\t (ptype <= I40E_RX_PTYPE_L2_FCOE_VFT_FCOTHER);\n+}\n #endif /* _I40E_TXRX_H_ */\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex ec1f447..0c912a4 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -1160,7 +1160,9 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, const int budget)\n \t\t\t ? le16_to_cpu(rx_desc->wb.qword0.lo_dword.l2tag1)\n \t\t\t : 0;\n #ifdef I40E_FCOE\n-\t\tif (!i40e_fcoe_handle_offload(rx_ring, rx_desc, skb)) {\n+\t\tif (unlikely(\n+\t\t i40e_rx_is_fcoe(rx_ptype) &&\n+\t\t !i40e_fcoe_handle_offload(rx_ring, rx_desc, skb))) {\n \t\t\tdev_kfree_skb_any(skb);\n \t\t\tcontinue;\n \t\t}\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.h b/drivers/net/ethernet/intel/i40evf/i40e_txrx.h\nindex 6cf1169..92deb97 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.h\n@@ -430,4 +430,14 @@ static inline bool i40e_chk_linearize(struct sk_buff *skb, int count)\n \n \treturn __i40evf_chk_linearize(skb);\n }\n+\n+/**\n+ * i40e_rx_is_fcoe - returns true if the rx packet type is FCoE\n+ * @ptype: the packet type field from rx descriptor write-back\n+ **/\n+static inline bool i40e_rx_is_fcoe(u16 ptype)\n+{\n+\treturn (ptype >= I40E_RX_PTYPE_L2_FCOE_PAY3) &&\n+\t (ptype <= I40E_RX_PTYPE_L2_FCOE_VFT_FCOTHER);\n+}\n #endif /* _I40E_TXRX_H_ */\n", "prefixes": [ "v3", "next", "S32", "06/13" ] }