Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/602597/?format=api
{ "id": 602597, "url": "http://patchwork.ozlabs.org/api/patches/602597/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1459163845-28035-10-git-send-email-harshitha.ramamurthy@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1459163845-28035-10-git-send-email-harshitha.ramamurthy@intel.com>", "list_archive_url": null, "date": "2016-03-28T11:17:20", "name": "[next,S32,09/14] i40e: Move NVM variable out of AQ struct", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "e9066a37be13e916d750c7ceb9ea4e7f320d5975", "submitter": { "id": 68642, "url": "http://patchwork.ozlabs.org/api/people/68642/?format=api", "name": "Harshitha Ramamurthy", "email": "harshitha.ramamurthy@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1459163845-28035-10-git-send-email-harshitha.ramamurthy@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/602597/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/602597/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 3qYkMV1Rx4z9s9k\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Mar 2016 06:23:02 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DAAE188474;\n\tMon, 28 Mar 2016 19:23:01 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6T73hxykci9l; Mon, 28 Mar 2016 19:23:00 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0A41988720;\n\tMon, 28 Mar 2016 19:22:57 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1D7621BFC8C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Mar 2016 19:22:55 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1A7E58B6F7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Mar 2016 19:22:55 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CtWw9K+pK8Ly for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Mar 2016 19:22:51 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8BE9E8B76B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Mar 2016 19:22:51 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP; 28 Mar 2016 12:22:51 -0700", "from harshitha-linux1.jf.intel.com ([10.166.45.81])\n\tby orsmga002.jf.intel.com with ESMTP; 28 Mar 2016 12:22:51 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,408,1455004800\"; d=\"scan'208\";a=\"943132227\"", "From": "Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 28 Mar 2016 04:17:20 -0700", "Message-Id": "<1459163845-28035-10-git-send-email-harshitha.ramamurthy@intel.com>", "X-Mailer": "git-send-email 2.4.3", "In-Reply-To": "<1459163845-28035-1-git-send-email-harshitha.ramamurthy@intel.com>", "References": "<1459163845-28035-1-git-send-email-harshitha.ramamurthy@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S32 09/14] i40e: Move NVM variable\n\tout of AQ struct", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Shannon Nelson <shannon.nelson@intel.com>\n\nThe NVM update status info should stay collected together, not\nspread across different structs.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@intel.com>\nChange-ID: Ic16f9e9fd79945d865bb7226184c889884585025\n---\nTesting Hints :\n\tCompile code and run an NVM update\n\n drivers/net/ethernet/intel/i40e/i40e_adminq.c | 6 +++---\n drivers/net/ethernet/intel/i40e/i40e_adminq.h | 1 -\n drivers/net/ethernet/intel/i40e/i40e_nvm.c | 12 ++++++------\n drivers/net/ethernet/intel/i40e/i40e_type.h | 1 +\n drivers/net/ethernet/intel/i40evf/i40e_adminq.h | 1 -\n drivers/net/ethernet/intel/i40evf/i40e_type.h | 1 +\n 6 files changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.c b/drivers/net/ethernet/intel/i40e/i40e_adminq.c\nindex df8e2fd..e8278e1 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_adminq.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.c\n@@ -624,7 +624,7 @@ i40e_status i40e_init_adminq(struct i40e_hw *hw)\n \n \t/* pre-emptive resource lock release */\n \ti40e_aq_release_resource(hw, I40E_NVM_RESOURCE_ID, 0, NULL);\n-\thw->aq.nvm_release_on_done = false;\n+\thw->nvm_release_on_done = false;\n \thw->nvmupd_state = I40E_NVMUPD_STATE_INIT;\n \n \tret_code = i40e_aq_set_hmc_resource_profile(hw,\n@@ -1024,9 +1024,9 @@ i40e_status i40e_clean_arq_element(struct i40e_hw *hw,\n \thw->aq.arq.next_to_use = ntu;\n \n \tif (i40e_is_nvm_update_op(&e->desc)) {\n-\t\tif (hw->aq.nvm_release_on_done) {\n+\t\tif (hw->nvm_release_on_done) {\n \t\t\ti40e_release_nvm(hw);\n-\t\t\thw->aq.nvm_release_on_done = false;\n+\t\t\thw->nvm_release_on_done = false;\n \t\t}\n \n \t\tswitch (hw->nvmupd_state) {\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.h b/drivers/net/ethernet/intel/i40e/i40e_adminq.h\nindex 12fbbdd..d92aad3 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_adminq.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.h\n@@ -97,7 +97,6 @@ struct i40e_adminq_info {\n \tu32 fw_build; /* firmware build number */\n \tu16 api_maj_ver; /* api major version */\n \tu16 api_min_ver; /* api minor version */\n-\tbool nvm_release_on_done;\n \n \tstruct mutex asq_mutex; /* Send queue lock */\n \tstruct mutex arq_mutex; /* Receive queue lock */\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_nvm.c b/drivers/net/ethernet/intel/i40e/i40e_nvm.c\nindex 5730f80..1ae29ac 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_nvm.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_nvm.c\n@@ -696,7 +696,7 @@ i40e_status i40e_nvmupd_command(struct i40e_hw *hw,\n \ti40e_debug(hw, I40E_DEBUG_NVM, \"%s state %d nvm_release_on_hold %d cmd 0x%08x config 0x%08x offset 0x%08x data_size 0x%08x\\n\",\n \t\t i40e_nvm_update_state_str[upd_cmd],\n \t\t hw->nvmupd_state,\n-\t\t hw->aq.nvm_release_on_done,\n+\t\t hw->nvm_release_on_done,\n \t\t cmd->command, cmd->config, cmd->offset, cmd->data_size);\n \n \tif (upd_cmd == I40E_NVMUPD_INVALID) {\n@@ -799,7 +799,7 @@ static i40e_status i40e_nvmupd_state_init(struct i40e_hw *hw,\n \t\t\tif (status) {\n \t\t\t\ti40e_release_nvm(hw);\n \t\t\t} else {\n-\t\t\t\thw->aq.nvm_release_on_done = true;\n+\t\t\t\thw->nvm_release_on_done = true;\n \t\t\t\thw->nvmupd_state = I40E_NVMUPD_STATE_INIT_WAIT;\n \t\t\t}\n \t\t}\n@@ -815,7 +815,7 @@ static i40e_status i40e_nvmupd_state_init(struct i40e_hw *hw,\n \t\t\tif (status) {\n \t\t\t\ti40e_release_nvm(hw);\n \t\t\t} else {\n-\t\t\t\thw->aq.nvm_release_on_done = true;\n+\t\t\t\thw->nvm_release_on_done = true;\n \t\t\t\thw->nvmupd_state = I40E_NVMUPD_STATE_INIT_WAIT;\n \t\t\t}\n \t\t}\n@@ -849,7 +849,7 @@ static i40e_status i40e_nvmupd_state_init(struct i40e_hw *hw,\n \t\t\t\t -EIO;\n \t\t\t\ti40e_release_nvm(hw);\n \t\t\t} else {\n-\t\t\t\thw->aq.nvm_release_on_done = true;\n+\t\t\t\thw->nvm_release_on_done = true;\n \t\t\t\thw->nvmupd_state = I40E_NVMUPD_STATE_INIT_WAIT;\n \t\t\t}\n \t\t}\n@@ -953,7 +953,7 @@ retry:\n \t\t\t\t -EIO;\n \t\t\thw->nvmupd_state = I40E_NVMUPD_STATE_INIT;\n \t\t} else {\n-\t\t\thw->aq.nvm_release_on_done = true;\n+\t\t\thw->nvm_release_on_done = true;\n \t\t\thw->nvmupd_state = I40E_NVMUPD_STATE_INIT_WAIT;\n \t\t}\n \t\tbreak;\n@@ -980,7 +980,7 @@ retry:\n \t\t\t\t -EIO;\n \t\t\thw->nvmupd_state = I40E_NVMUPD_STATE_INIT;\n \t\t} else {\n-\t\t\thw->aq.nvm_release_on_done = true;\n+\t\t\thw->nvm_release_on_done = true;\n \t\t\thw->nvmupd_state = I40E_NVMUPD_STATE_INIT_WAIT;\n \t\t}\n \t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h\nindex 0a0baf7..11917e6 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_type.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_type.h\n@@ -548,6 +548,7 @@ struct i40e_hw {\n \tenum i40e_nvmupd_state nvmupd_state;\n \tstruct i40e_aq_desc nvm_wb_desc;\n \tstruct i40e_virt_mem nvm_buff;\n+\tbool nvm_release_on_done;\n \n \t/* HMC info */\n \tstruct i40e_hmc_info hmc; /* HMC info struct */\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_adminq.h b/drivers/net/ethernet/intel/i40evf/i40e_adminq.h\nindex a3eae5d..1f9b3b5 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_adminq.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_adminq.h\n@@ -97,7 +97,6 @@ struct i40e_adminq_info {\n \tu32 fw_build; /* firmware build number */\n \tu16 api_maj_ver; /* api major version */\n \tu16 api_min_ver; /* api minor version */\n-\tbool nvm_release_on_done;\n \n \tstruct mutex asq_mutex; /* Send queue lock */\n \tstruct mutex arq_mutex; /* Receive queue lock */\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_type.h b/drivers/net/ethernet/intel/i40evf/i40e_type.h\nindex 301fe2b..d68e017 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_type.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_type.h\n@@ -522,6 +522,7 @@ struct i40e_hw {\n \tenum i40e_nvmupd_state nvmupd_state;\n \tstruct i40e_aq_desc nvm_wb_desc;\n \tstruct i40e_virt_mem nvm_buff;\n+\tbool nvm_release_on_done;\n \n \t/* HMC info */\n \tstruct i40e_hmc_info hmc; /* HMC info struct */\n", "prefixes": [ "next", "S32", "09/14" ] }