Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/602594/?format=api
{ "id": 602594, "url": "http://patchwork.ozlabs.org/api/patches/602594/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1459163845-28035-9-git-send-email-harshitha.ramamurthy@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1459163845-28035-9-git-send-email-harshitha.ramamurthy@intel.com>", "list_archive_url": null, "date": "2016-03-28T11:17:19", "name": "[next,S32,08/14] i40e: Restrict VF poll mode to only single function mode devices", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "45c78d0d2711a3e8d6e88d713c5b56bdbd5fe353", "submitter": { "id": 68642, "url": "http://patchwork.ozlabs.org/api/people/68642/?format=api", "name": "Harshitha Ramamurthy", "email": "harshitha.ramamurthy@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1459163845-28035-9-git-send-email-harshitha.ramamurthy@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/602594/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/602594/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 3qYkMT0Ydcz9sBM\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Mar 2016 06:23:01 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5878788868;\n\tMon, 28 Mar 2016 19:23:00 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TAnLUg0hMD3x; Mon, 28 Mar 2016 19:22:57 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 128CB88880;\n\tMon, 28 Mar 2016 19:22:56 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6A3431BFC8C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Mar 2016 19:22:53 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 68F8E8B7A4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Mar 2016 19:22:53 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id XdRcrjM5vfqJ for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Mar 2016 19:22:51 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 790688B749\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 28 Mar 2016 19:22:51 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP; 28 Mar 2016 12:22:51 -0700", "from harshitha-linux1.jf.intel.com ([10.166.45.81])\n\tby orsmga002.jf.intel.com with ESMTP; 28 Mar 2016 12:22:51 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,408,1455004800\"; d=\"scan'208\";a=\"943132226\"", "From": "Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 28 Mar 2016 04:17:19 -0700", "Message-Id": "<1459163845-28035-9-git-send-email-harshitha.ramamurthy@intel.com>", "X-Mailer": "git-send-email 2.4.3", "In-Reply-To": "<1459163845-28035-1-git-send-email-harshitha.ramamurthy@intel.com>", "References": "<1459163845-28035-1-git-send-email-harshitha.ramamurthy@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S32 08/14] i40e: Restrict VF poll\n\tmode to only single function mode devices", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Shannon Nelson <shannon.nelson@intel.com>\n\nThe VFs can request their queues to be set up into polling mode, rather\nthan interrupt mode, which works well for supporting things like DPDK,\nbut this should not be available when working in an multi-function\nsupport device.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@intel.com>\nChange-ID: Id36792e4e7422db8f2033336507211f68f14ff6f\n---\nTesting Hints:\n case 1:\n\tset up a DPDK VF in an NPAR environment\n\tthe VF polling request should be failed and a message logged\n case 2:\n\tset up a DPDK VF in an SFP environment\n\tthe VF polling request should succeed\n\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex fccfc36..fdc37ee 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1226,8 +1226,16 @@ static int i40e_vc_get_vf_resources_msg(struct i40e_vf *vf, u8 *msg)\n \t\t\t\tI40E_VIRTCHNL_VF_OFFLOAD_RSS_PCTYPE_V2;\n \t}\n \n-\tif (vf->driver_caps & I40E_VIRTCHNL_VF_OFFLOAD_RX_POLLING)\n+\tif (vf->driver_caps & I40E_VIRTCHNL_VF_OFFLOAD_RX_POLLING) {\n+\t\tif (pf->flags & I40E_FLAG_MFP_ENABLED) {\n+\t\t\tdev_err(&pf->pdev->dev,\n+\t\t\t\t\"VF %d requested polling mode: this feature is supported only when the device is running in single function per port (SFP) mode\\n\",\n+\t\t\t\t vf->vf_id);\n+\t\t\tret = I40E_ERR_PARAM;\n+\t\t\tgoto err;\n+\t\t}\n \t\tvfres->vf_offload_flags |= I40E_VIRTCHNL_VF_OFFLOAD_RX_POLLING;\n+\t}\n \n \tif (pf->flags & I40E_FLAG_WB_ON_ITR_CAPABLE) {\n \t\tif (vf->driver_caps & I40E_VIRTCHNL_VF_OFFLOAD_WB_ON_ITR)\n", "prefixes": [ "next", "S32", "08/14" ] }