Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/599725/?format=api
{ "id": 599725, "url": "http://patchwork.ozlabs.org/api/patches/599725/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160318230653.14801.86163.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160318230653.14801.86163.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2016-03-18T23:06:53", "name": "[next,2/2] igb: Fix sparse warning about passing __beXX into leXX_to_cpup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d2be2df8092d17b495f9fb1a6a506203f1488c08", "submitter": { "id": 67293, "url": "http://patchwork.ozlabs.org/api/people/67293/?format=api", "name": "Alexander Duyck", "email": "aduyck@mirantis.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160318230653.14801.86163.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/599725/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/599725/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 3qRgpW41M9z9s5Q\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 19 Mar 2016 10:06:59 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D45D633B14;\n\tFri, 18 Mar 2016 23:06:58 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lojQ7VZZQBPX; Fri, 18 Mar 2016 23:06:58 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1E8523220A;\n\tFri, 18 Mar 2016 23:06:58 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 068181BF9E4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Mar 2016 23:06:56 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 015B8A5914\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Mar 2016 23:06:56 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iaxXa1myHo9h for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Mar 2016 23:06:55 +0000 (UTC)", "from mail-pf0-f177.google.com (mail-pf0-f177.google.com\n\t[209.85.192.177])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 454809FA73\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Mar 2016 23:06:55 +0000 (UTC)", "by mail-pf0-f177.google.com with SMTP id u190so186093035pfb.3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Mar 2016 16:06:55 -0700 (PDT)", "from localhost.localdomain\n\t(static-50-53-29-36.bvtn.or.frontiernet.net. [50.53.29.36])\n\tby smtp.gmail.com with ESMTPSA id\n\tu64sm23357763pfa.86.2016.03.18.16.06.54\n\tfor <intel-wired-lan@lists.osuosl.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 18 Mar 2016 16:06:54 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mirantis.com header.i=@mirantis.com\n\theader.b=Pq9GdQqD; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com;\n\ts=google; \n\th=subject:from:to:date:message-id:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=t9UfQD81VJFge3Hsge6smHBr4a4xEgsdPz4OiPWHdwg=;\n\tb=Pq9GdQqDoNyp0t1J05G1qN8wfSyudSzWPb/cH9FvUQFeQtS1qqaCI6AzwQvtQAw4Ot\n\t96AUOZ7qE18MzpBX9ABsS4/t+N1gcsfLsjzAP/q43nJd8nUS5eKu0T+hafkGorhumXI1\n\t3+0pNdaORCWK0KapUP9/nLmFMGH/NQS1eQwEQ=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=t9UfQD81VJFge3Hsge6smHBr4a4xEgsdPz4OiPWHdwg=;\n\tb=asQED/oBq7Mbl03i+nav4cZvk/PDyqZxpb7N4o1WU4sjfLIAJ8oMS8z6QOQjEZrejF\n\tB21wMOu7/qsHc8kJ+sxGGiGseCgCcZAx8t0xAS9JmUM5oqc6g8XOI1dqKWBzT0CL9jQC\n\toJ0a4LuYfR65nrwuYbEOLXg9m5r4Qfye3y4WaJnhR180AQnkNcQBcEN3l/tYwIGHxHn/\n\t7aiv3uVXUMtnDaLoq0Yjnw3F5DnNZSt/IdNTNnGolimXrqJ5hPpzpY+CEkiHrDA/dFVe\n\tjrd8BUQZFENz1Dc6tqNM6vhTncsG2Zkv+/jfe6VSh9YU740Ycv4h8T1UsXYClY+f2iOE\n\tlUeQ==", "X-Gm-Message-State": "AD7BkJIlwLUky5wKv5Omrd479H/Nxr7W4RDe/Uf/LT/dhGKyHX65Qsg7fwEiMM+H94pcgCRd", "X-Received": "by 10.98.72.218 with SMTP id q87mr27602527pfi.117.1458342414834; \n\tFri, 18 Mar 2016 16:06:54 -0700 (PDT)", "From": "Alexander Duyck <aduyck@mirantis.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 18 Mar 2016 16:06:53 -0700", "Message-ID": "<20160318230653.14801.86163.stgit@localhost.localdomain>", "In-Reply-To": "<20160318230425.14801.87895.stgit@localhost.localdomain>", "References": "<20160318230425.14801.87895.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH 2/2] igb: Fix sparse warning about\n\tpassing __beXX into leXX_to_cpup", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "We were casting the addr as __beXX and then passing it into le32_to_cpu\nbecause the device expects the MAC address to be in network order even\nthough the register set is little endian. Instead of casting it as __beXX\nwe can just cast it as __leXX in order to maintain consistency since the\nregion of memory is already in little endian order as far as we are\nconcerned.\n\nSigned-off-by: Alexander Duyck <aduyck@mirantis.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 7f7e4a2a5fe2..f3fd43e1c4e8 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -7850,11 +7850,13 @@ static void igb_rar_set_qsel(struct igb_adapter *adapter, u8 *addr, u32 index,\n \tstruct e1000_hw *hw = &adapter->hw;\n \tu32 rar_low, rar_high;\n \n-\t/* HW expects these in little endian so we reverse the byte order\n-\t * from network order (big endian) to CPU endian\n+\t/* HW expects these to be in network order when they are plugged\n+\t * into the registers which are little endian. In order to guarantee\n+\t * that ordering we need to do an leXX_to_cpup here in order to be\n+\t * ready for the byteswap that occurs with writel\n \t */\n-\trar_low = le32_to_cpup((__be32 *)(addr));\n-\trar_high = le16_to_cpup((__be16 *)(addr + 4));\n+\trar_low = le32_to_cpup((__le32 *)(addr));\n+\trar_high = le16_to_cpup((__le16 *)(addr + 4));\n \n \t/* Indicate to hardware the Address is Valid. */\n \trar_high |= E1000_RAH_AV;\n", "prefixes": [ "next", "2/2" ] }