Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/599675/?format=api
{ "id": 599675, "url": "http://patchwork.ozlabs.org/api/patches/599675/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1458328696-135941-6-git-send-email-avinash.dayanand@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1458328696-135941-6-git-send-email-avinash.dayanand@intel.com>", "list_archive_url": null, "date": "2016-03-18T19:18:09", "name": "[next,S31,v4,05/12] i40e: Make VF resets more reliable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "06dd75e59ce88149548fd8c5d21354c29adf82cb", "submitter": { "id": 67689, "url": "http://patchwork.ozlabs.org/api/people/67689/?format=api", "name": "Dayanand, Avinash", "email": "avinash.dayanand@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1458328696-135941-6-git-send-email-avinash.dayanand@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/599675/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/599675/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 3qRc7Z0n20z9sBM\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 19 Mar 2016 07:21:30 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 541578B0A6;\n\tFri, 18 Mar 2016 20:21:29 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PMfEAQaKf7qK; Fri, 18 Mar 2016 20:21:27 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id CC8DCA61EE;\n\tFri, 18 Mar 2016 20:21:18 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 592431CF547\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Mar 2016 20:21:16 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4D488A6234\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Mar 2016 20:21:12 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tGuQeXTEDpA2 for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Mar 2016 20:20:58 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 56AA68AFE6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 Mar 2016 20:20:58 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga102.fm.intel.com with ESMTP; 18 Mar 2016 13:20:56 -0700", "from avi-linux1.jf.intel.com ([10.166.12.50])\n\tby fmsmga004.fm.intel.com with ESMTP; 18 Mar 2016 13:20:57 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,356,1455004800\"; d=\"scan'208\";a=\"69202010\"", "From": "Avinash Dayanand <avinash.dayanand@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 18 Mar 2016 12:18:09 -0700", "Message-Id": "<1458328696-135941-6-git-send-email-avinash.dayanand@intel.com>", "X-Mailer": "git-send-email 2.4.3", "In-Reply-To": "<1458328696-135941-1-git-send-email-avinash.dayanand@intel.com>", "References": "<1458328696-135941-1-git-send-email-avinash.dayanand@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S31 v4 05/12] i40e: Make VF resets\n\tmore reliable", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nClear the VFLR bit immediately after triggering a reset instead of\nwaiting until after cleanup is complete. Make sure to trigger a reset\nevery time, not just if the PF is up.\n\nThese changes fix a problem where VF resets would get lost by the PF,\npreventing the VF driver from initializing.\n\nTesting Hints: Do VF driver load/unload test with\nlots of VFs in the system.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-ID: I5945cf2884095b7b0554867c64df8617e71d9d29\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 80174de..66763c1 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -807,6 +807,10 @@ void i40e_reset_vf(struct i40e_vf *vf, bool flr)\n \t\twr32(hw, I40E_VPGEN_VFRTRIG(vf->vf_id), reg);\n \t\ti40e_flush(hw);\n \t}\n+\t/* clear the VFLR bit in GLGEN_VFLRSTAT */\n+\treg_idx = (hw->func_caps.vf_base_id + vf->vf_id) / 32;\n+\tbit_idx = (hw->func_caps.vf_base_id + vf->vf_id) % 32;\n+\twr32(hw, I40E_GLGEN_VFLRSTAT(reg_idx), BIT(bit_idx));\n \n \tif (i40e_quiesce_vf_pci(vf))\n \t\tdev_err(&pf->pdev->dev, \"VF %d PCI transactions stuck\\n\",\n@@ -857,10 +861,6 @@ complete_reset:\n \t/* tell the VF the reset is done */\n \twr32(hw, I40E_VFGEN_RSTAT1(vf->vf_id), I40E_VFR_VFACTIVE);\n \n-\t/* clear the VFLR bit in GLGEN_VFLRSTAT */\n-\treg_idx = (hw->func_caps.vf_base_id + vf->vf_id) / 32;\n-\tbit_idx = (hw->func_caps.vf_base_id + vf->vf_id) % 32;\n-\twr32(hw, I40E_GLGEN_VFLRSTAT(reg_idx), BIT(bit_idx));\n \ti40e_flush(hw);\n \tclear_bit(__I40E_VF_DISABLE, &pf->state);\n }\n@@ -2059,11 +2059,9 @@ int i40e_vc_process_vflr_event(struct i40e_pf *pf)\n \t\t/* read GLGEN_VFLRSTAT register to find out the flr VFs */\n \t\tvf = &pf->vf[vf_id];\n \t\treg = rd32(hw, I40E_GLGEN_VFLRSTAT(reg_idx));\n-\t\tif (reg & BIT(bit_idx)) {\n+\t\tif (reg & BIT(bit_idx))\n \t\t\t/* i40e_reset_vf will clear the bit in GLGEN_VFLRSTAT */\n-\t\t\tif (!test_bit(__I40E_DOWN, &pf->state))\n-\t\t\t\ti40e_reset_vf(vf, true);\n-\t\t}\n+\t\t\ti40e_reset_vf(vf, true);\n \t}\n \n \treturn 0;\n", "prefixes": [ "next", "S31", "v4", "05/12" ] }