Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/597216/?format=api
{ "id": 597216, "url": "http://patchwork.ozlabs.org/api/patches/597216/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160314180546.8397.53488.stgit@mdrustad-wks.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160314180546.8397.53488.stgit@mdrustad-wks.jf.intel.com>", "list_archive_url": null, "date": "2016-03-14T18:05:46", "name": "[V2,2/5] ixgbe: Change the lan_id and func fields to a u8 to avoid casts", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6f643de2b877eb5a6ca45a6670364a83e979317e", "submitter": { "id": 13252, "url": "http://patchwork.ozlabs.org/api/people/13252/?format=api", "name": "Rustad, Mark D", "email": "mark.d.rustad@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160314180546.8397.53488.stgit@mdrustad-wks.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/597216/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/597216/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 3qP5KN3dGSz9syq\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 15 Mar 2016 05:06:16 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 97D0390F97;\n\tMon, 14 Mar 2016 18:06:15 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nlO1QDwZ+EvL; Mon, 14 Mar 2016 18:06:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1B5BA90FC9;\n\tMon, 14 Mar 2016 18:06:13 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E61591C0BA9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Mar 2016 18:06:10 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9860895993\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Mar 2016 18:06:10 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ooHXZj6c9tRW for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Mar 2016 18:06:08 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 41EB795841\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Mar 2016 18:06:08 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga103.fm.intel.com with ESMTP; 14 Mar 2016 11:05:47 -0700", "from mdrustad-wks.jf.intel.com ([134.134.3.229])\n\tby fmsmga004.fm.intel.com with ESMTP; 14 Mar 2016 11:05:47 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,336,1455004800\"; d=\"scan'208\";a=\"66164991\"", "From": "Mark D Rustad <mark.d.rustad@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 14 Mar 2016 11:05:46 -0700", "Message-ID": "<20160314180546.8397.53488.stgit@mdrustad-wks.jf.intel.com>", "In-Reply-To": "<20160314180316.8397.65394.stgit@mdrustad-wks.jf.intel.com>", "References": "<20160314180316.8397.65394.stgit@mdrustad-wks.jf.intel.com>", "User-Agent": "StGit/unknown-version", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH V2 2/5] ixgbe: Change the lan_id and func\n\tfields to a u8 to avoid casts", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Since the lan_id and func fields only ever hold small values, make\nthem u8 to avoid casts used to silence warnings.\n\nSigned-off-by: Mark Rustad <mark.d.rustad@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 2 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 4 ++--\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 2 +-\n 3 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\nindex 8c7e78b21c4e..dfdb1149b6fd 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n@@ -3600,7 +3600,7 @@ s32 ixgbe_set_fw_drv_ver_generic(struct ixgbe_hw *hw, u8 maj, u8 min,\n \tfw_cmd.hdr.cmd = FW_CEM_CMD_DRIVER_INFO;\n \tfw_cmd.hdr.buf_len = FW_CEM_CMD_DRIVER_INFO_LEN;\n \tfw_cmd.hdr.cmd_or_resp.cmd_resv = FW_CEM_CMD_RESERVED;\n-\tfw_cmd.port_num = (u8)hw->bus.func;\n+\tfw_cmd.port_num = hw->bus.func;\n \tfw_cmd.ver_maj = maj;\n \tfw_cmd.ver_min = min;\n \tfw_cmd.ver_build = build;\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\nindex d02a0a3fa1d8..7ae4bbd26ad8 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\n@@ -3122,8 +3122,8 @@ struct ixgbe_bus_info {\n \tenum ixgbe_bus_width width;\n \tenum ixgbe_bus_type type;\n \n-\tu16 func;\n-\tu16 lan_id;\n+\tu8 func;\n+\tu8 lan_id;\n };\n \n /* Flow control parameters */\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex 9d3f765638cc..5affac123b75 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -862,7 +862,7 @@ static void ixgbe_disable_rx_x550(struct ixgbe_hw *hw)\n \t\tfw_cmd.hdr.cmd = FW_DISABLE_RXEN_CMD;\n \t\tfw_cmd.hdr.buf_len = FW_DISABLE_RXEN_LEN;\n \t\tfw_cmd.hdr.checksum = FW_DEFAULT_CHECKSUM;\n-\t\tfw_cmd.port_number = (u8)hw->bus.lan_id;\n+\t\tfw_cmd.port_number = hw->bus.lan_id;\n \n \t\tstatus = ixgbe_host_interface_command(hw, (u32 *)&fw_cmd,\n \t\t\t\t\tsizeof(struct ixgbe_hic_disable_rxen),\n", "prefixes": [ "V2", "2/5" ] }