Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/597212/?format=api
{ "id": 597212, "url": "http://patchwork.ozlabs.org/api/patches/597212/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160314180551.8397.27934.stgit@mdrustad-wks.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160314180551.8397.27934.stgit@mdrustad-wks.jf.intel.com>", "list_archive_url": null, "date": "2016-03-14T18:05:51", "name": "[V2,3/5] ixgbe: Correct length check for round up", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d24f69afd41e835d7850505fcb5832df2f195ea3", "submitter": { "id": 13252, "url": "http://patchwork.ozlabs.org/api/people/13252/?format=api", "name": "Rustad, Mark D", "email": "mark.d.rustad@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160314180551.8397.27934.stgit@mdrustad-wks.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/597212/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/597212/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 3qP5K45gz6z9sXQ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 15 Mar 2016 05:06:00 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id EF24A90F97;\n\tMon, 14 Mar 2016 18:05:59 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zOo393-nHcrx; Mon, 14 Mar 2016 18:05:59 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 685B190F88;\n\tMon, 14 Mar 2016 18:05:59 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id E24431C0BA9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Mar 2016 18:05:53 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DC27590F88\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Mar 2016 18:05:53 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wSa8cQ0Wtdlc for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Mar 2016 18:05:53 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4C51787BD9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 14 Mar 2016 18:05:53 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP; 14 Mar 2016 11:05:52 -0700", "from mdrustad-wks.jf.intel.com ([134.134.3.229])\n\tby FMSMGA003.fm.intel.com with ESMTP; 14 Mar 2016 11:05:52 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,336,1455004800\"; d=\"scan'208\";a=\"669409923\"", "From": "Mark D Rustad <mark.d.rustad@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 14 Mar 2016 11:05:51 -0700", "Message-ID": "<20160314180551.8397.27934.stgit@mdrustad-wks.jf.intel.com>", "In-Reply-To": "<20160314180316.8397.65394.stgit@mdrustad-wks.jf.intel.com>", "References": "<20160314180316.8397.65394.stgit@mdrustad-wks.jf.intel.com>", "User-Agent": "StGit/unknown-version", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH V2 3/5] ixgbe: Correct length check for\n\tround up", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The function ixgbe_host_interface_command actually uses a multiple\nof word sized buffer to do its business, but only checks against\nthe actual length passed in. This means that on read operations it\ncould be possible to modify locations beyond the length passed in.\nChange the check to round up in the same way, just to avoid any\npossible hazard.\n\nSigned-off-by: Mark Rustad <mark.d.rustad@intel.com>\n---\nChanges in V2:\n- Use round_up function instead of an open-coded one\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\nindex dfdb1149b6fd..a2ca9ef0daab 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n@@ -3557,7 +3557,7 @@ s32 ixgbe_host_interface_command(struct ixgbe_hw *hw, u32 *buffer,\n \tif (buf_len == 0)\n \t\treturn 0;\n \n-\tif (length < (buf_len + hdr_size)) {\n+\tif (length < round_up(buf_len, 4) + hdr_size) {\n \t\thw_dbg(hw, \"Buffer not large enough for reply message.\\n\");\n \t\treturn IXGBE_ERR_HOST_INTERFACE_COMMAND;\n \t}\n", "prefixes": [ "V2", "3/5" ] }