Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/595992/?format=api
{ "id": 595992, "url": "http://patchwork.ozlabs.org/api/patches/595992/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1457650791-100229-8-git-send-email-avinash.dayanand@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1457650791-100229-8-git-send-email-avinash.dayanand@intel.com>", "list_archive_url": null, "date": "2016-03-10T22:59:45", "name": "[next,S30,v3,07/13] i40e: Remove timer and task only if created", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2baf358d4d6bef326d07b3751e3cb64138944083", "submitter": { "id": 67689, "url": "http://patchwork.ozlabs.org/api/people/67689/?format=api", "name": "Dayanand, Avinash", "email": "avinash.dayanand@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1457650791-100229-8-git-send-email-avinash.dayanand@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/595992/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/595992/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id B2CC6140B0F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 11 Mar 2016 10:02:55 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 572B0A5DC4;\n\tThu, 10 Mar 2016 23:02:55 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id X523AO9nMAkW; Thu, 10 Mar 2016 23:02:53 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E269EA5ED6;\n\tThu, 10 Mar 2016 23:02:52 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 779871C11BA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Mar 2016 23:02:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 74389956D1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Mar 2016 23:02:49 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dHjbEkSwpGwp for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Mar 2016 23:02:48 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 30FD7956DE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Mar 2016 23:02:48 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga103.fm.intel.com with ESMTP; 10 Mar 2016 15:02:26 -0800", "from avi-linux1.jf.intel.com ([10.166.12.50])\n\tby orsmga003.jf.intel.com with ESMTP; 10 Mar 2016 15:02:26 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,317,1455004800\"; d=\"scan'208\";a=\"761961639\"", "From": "ajdayana <avinash.dayanand@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 10 Mar 2016 14:59:45 -0800", "Message-Id": "<1457650791-100229-8-git-send-email-avinash.dayanand@intel.com>", "X-Mailer": "git-send-email 2.4.3", "In-Reply-To": "<1457650791-100229-1-git-send-email-avinash.dayanand@intel.com>", "References": "<1457650791-100229-1-git-send-email-avinash.dayanand@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S30 v3 07/13] i40e: Remove timer and\n\ttask only if created", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Shannon Nelson <shannon.nelson@intel.com>\n\nIn some error scenarios, we may find ourselves trying to remove a\nnon-existent timer or worktask. This causes the kernel some bit\nof consternation, so don't do it.\n\nTesting Hints: Inject an error into the i40e_probe before these are\ncreated and see if you can get a clean remove.\n\nSigned-off-by: Nelson, Shannon <shannon.nelson@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 5d2dba2..298a73c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -11212,8 +11212,10 @@ static void i40e_remove(struct pci_dev *pdev)\n \t/* no more scheduling of any task */\n \tset_bit(__I40E_SUSPENDED, &pf->state);\n \tset_bit(__I40E_DOWN, &pf->state);\n-\tdel_timer_sync(&pf->service_timer);\n-\tcancel_work_sync(&pf->service_task);\n+\tif (pf->service_timer.data)\n+\t\tdel_timer_sync(&pf->service_timer);\n+\tif (pf->service_task.func)\n+\t\tcancel_work_sync(&pf->service_task);\n \n \tif (pf->flags & I40E_FLAG_SRIOV_ENABLED) {\n \t\ti40e_free_vfs(pf);\n", "prefixes": [ "next", "S30", "v3", "07/13" ] }