Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/595990/?format=api
{ "id": 595990, "url": "http://patchwork.ozlabs.org/api/patches/595990/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1457650791-100229-7-git-send-email-avinash.dayanand@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1457650791-100229-7-git-send-email-avinash.dayanand@intel.com>", "list_archive_url": null, "date": "2016-03-10T22:59:44", "name": "[next,S30,v3,06/13] i40e: Assure that adminq is alive in debug mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3515d3541e986a3f4466f5c83b8a9ea2761400f8", "submitter": { "id": 67689, "url": "http://patchwork.ozlabs.org/api/people/67689/?format=api", "name": "Dayanand, Avinash", "email": "avinash.dayanand@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1457650791-100229-7-git-send-email-avinash.dayanand@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/595990/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/595990/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 195851409C2\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 11 Mar 2016 10:02:55 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C571DA5E3A;\n\tThu, 10 Mar 2016 23:02:54 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HF2o8VdiImUe; Thu, 10 Mar 2016 23:02:52 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 91B4FA5E54;\n\tThu, 10 Mar 2016 23:02:52 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 087031C11BA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Mar 2016 23:02:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 042DFA5DD1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Mar 2016 23:02:49 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7iIjrwcy8kEh for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Mar 2016 23:02:48 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 31DD0A5DCE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Mar 2016 23:02:48 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga103.fm.intel.com with ESMTP; 10 Mar 2016 15:02:26 -0800", "from avi-linux1.jf.intel.com ([10.166.12.50])\n\tby orsmga003.jf.intel.com with ESMTP; 10 Mar 2016 15:02:26 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,317,1455004800\"; d=\"scan'208\";a=\"761961638\"", "From": "ajdayana <avinash.dayanand@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 10 Mar 2016 14:59:44 -0800", "Message-Id": "<1457650791-100229-7-git-send-email-avinash.dayanand@intel.com>", "X-Mailer": "git-send-email 2.4.3", "In-Reply-To": "<1457650791-100229-1-git-send-email-avinash.dayanand@intel.com>", "References": "<1457650791-100229-1-git-send-email-avinash.dayanand@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S30 v3 06/13] i40e: Assure that\n\tadminq is alive in debug mode", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Shannon Nelson <shannon.nelson@intel.com>\n\nWhen dropping into debug mode in a failed probe, make sure that\nthe AdminQ is left alive for possible hand debug of driver and\nfirmware states.\n\nMove the mutex_init calls earlier in probe so that if init fails,\nthe admin queue interface is still available for debugging purposes.\n\nTesting Hints:\nInject an error into the i40e_probe logic that puts the driver\ninto debug mode and try some debugfs commands that query the\nfirmware, such as \"dump switch\".\n\nSigned-off-by: Nelson, Shannon <shannon.nelson@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 13 ++++++-------\n 1 file changed, 6 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 260abd8..5d2dba2 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -10744,6 +10744,12 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \thw->bus.func = PCI_FUNC(pdev->devfn);\n \tpf->instance = pfs_found;\n \n+\t/* set up the locks for the AQ, do this only once in probe\n+\t * and destroy them only once in remove\n+\t */\n+\tmutex_init(&hw->aq.asq_mutex);\n+\tmutex_init(&hw->aq.arq_mutex);\n+\n \tif (debug != -1) {\n \t\tpf->msg_enable = pf->hw.debug_mask;\n \t\tpf->msg_enable = debug;\n@@ -10789,12 +10795,6 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t/* set up a default setting for link flow control */\n \tpf->hw.fc.requested_mode = I40E_FC_NONE;\n \n-\t/* set up the locks for the AQ, do this only once in probe\n-\t * and destroy them only once in remove\n-\t */\n-\tmutex_init(&hw->aq.asq_mutex);\n-\tmutex_init(&hw->aq.arq_mutex);\n-\n \terr = i40e_init_adminq(hw);\n \tif (err) {\n \t\tif (err == I40E_ERR_FIRMWARE_API_VERSION)\n@@ -11171,7 +11171,6 @@ err_init_lan_hmc:\n \tkfree(pf->qp_pile);\n err_sw_init:\n err_adminq_setup:\n-\t(void)i40e_shutdown_adminq(hw);\n err_pf_reset:\n \tiounmap(hw->hw_addr);\n err_ioremap:\n", "prefixes": [ "next", "S30", "v3", "06/13" ] }