Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/593097/?format=api
{ "id": 593097, "url": "http://patchwork.ozlabs.org/api/patches/593097/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1457372509-3135-2-git-send-email-sridhar.samudrala@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1457372509-3135-2-git-send-email-sridhar.samudrala@intel.com>", "list_archive_url": null, "date": "2016-03-07T17:41:48", "name": "[v2,net-next,2/3] net: ixgbe: Fix cls_u32 offload support for fields with masks.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "72ae3cf919e308e3386ecb6ebeaf0ecb2a355895", "submitter": { "id": 65219, "url": "http://patchwork.ozlabs.org/api/people/65219/?format=api", "name": "Samudrala, Sridhar", "email": "sridhar.samudrala@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1457372509-3135-2-git-send-email-sridhar.samudrala@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/593097/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/593097/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 2B3C6140307\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 8 Mar 2016 04:45:53 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 719553398B;\n\tMon, 7 Mar 2016 17:45:52 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id pnKXkSoqeVde; Mon, 7 Mar 2016 17:45:51 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7CE0531E5E;\n\tMon, 7 Mar 2016 17:45:51 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2846D1C1677\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 7 Mar 2016 17:45:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 23CECA6349\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 7 Mar 2016 17:45:51 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OqPieEAs6BL7 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 7 Mar 2016 17:45:50 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4E950A636A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 7 Mar 2016 17:45:50 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga102.fm.intel.com with ESMTP; 07 Mar 2016 09:45:49 -0800", "from unknown (HELO sri02.jf.intel.com) ([10.166.39.21])\n\tby fmsmga004.fm.intel.com with ESMTP; 07 Mar 2016 09:45:50 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.22,552,1449561600\"; d=\"scan'208\";a=\"61475942\"", "From": "Sridhar Samudrala <sridhar.samudrala@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, john.r.fastabend@intel.com,\n\tjeffrey.t.kirsher@intel.com", "Date": "Mon, 7 Mar 2016 09:41:48 -0800", "Message-Id": "<1457372509-3135-2-git-send-email-sridhar.samudrala@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1457372509-3135-1-git-send-email-sridhar.samudrala@intel.com>", "References": "<1457372509-3135-1-git-send-email-sridhar.samudrala@intel.com>", "Subject": "[Intel-wired-lan] [PATCH v2 net-next 2/3] net: ixgbe: Fix cls_u32\n\toffload support for fields with masks.", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Remove the incorrect check for mask in ixgbe_configure_clsu32 and\ndrop the 'mask' field that is not required in struct ixgbe_mat_field\n\nVerified with the following filters:\n\n #tc qdisc add dev p4p1 ingress\n #tc filter add dev p4p1 parent ffff: protocol ip prio 99 \\\n\thandle 800:0:1 u32 ht 800: \\\n\tmatch ip dst 10.0.0.1/8 match ip src 10.0.0.2/8 action drop\n #tc filter add dev p4p1 parent ffff: protocol ip prio 99 \\\n\thandle 800:0:2 u32 ht 800: \\\n\tmatch ip dst 11.0.0.1/16 match ip src 11.0.0.2/16 action drop\n #tc filter add dev p4p1 parent ffff: protocol ip prio 99 \\\n\thandle 800:0:3 u32 ht 800: \\\n\tmatch ip dst 12.0.0.1/24 match ip src 12.0.0.2/24 action drop\n #tc filter add dev p4p1 parent ffff: protocol ip prio 99 \\\n\thandle 800:0:4 u32 ht 800: \\\n\tmatch ip dst 13.0.0.1/32 match ip src 13.0.0.2/32 action drop\n\nSigned-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +--\n drivers/net/ethernet/intel/ixgbe/ixgbe_model.h | 9 ++++-----\n 2 files changed, 5 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 10ccd96..c520f98 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -8348,8 +8348,7 @@ static int ixgbe_configure_clsu32(struct ixgbe_adapter *adapter,\n \t\tint j;\n \n \t\tfor (j = 0; field_ptr[j].val; j++) {\n-\t\t\tif (field_ptr[j].off == off &&\n-\t\t\t field_ptr[j].mask == m) {\n+\t\t\tif (field_ptr[j].off == off) {\n \t\t\t\tfield_ptr[j].val(input, &mask, val, m);\n \t\t\t\tinput->filter.formatted.flow_type |=\n \t\t\t\t\tfield_ptr[j].type;\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_model.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_model.h\nindex ce48872..61f7290 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_model.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_model.h\n@@ -32,7 +32,6 @@\n \n struct ixgbe_mat_field {\n \tunsigned int off;\n-\tunsigned int mask;\n \tint (*val)(struct ixgbe_fdir_filter *input,\n \t\t union ixgbe_atr_input *mask,\n \t\t u32 val, u32 m);\n@@ -58,9 +57,9 @@ static inline int ixgbe_mat_prgm_dip(struct ixgbe_fdir_filter *input,\n }\n \n static struct ixgbe_mat_field ixgbe_ipv4_fields[] = {\n-\t{ .off = 12, .mask = -1, .val = ixgbe_mat_prgm_sip,\n+\t{ .off = 12, .val = ixgbe_mat_prgm_sip,\n \t .type = IXGBE_ATR_FLOW_TYPE_IPV4},\n-\t{ .off = 16, .mask = -1, .val = ixgbe_mat_prgm_dip,\n+\t{ .off = 16, .val = ixgbe_mat_prgm_dip,\n \t .type = IXGBE_ATR_FLOW_TYPE_IPV4},\n \t{ .val = NULL } /* terminal node */\n };\n@@ -84,9 +83,9 @@ static inline int ixgbe_mat_prgm_dport(struct ixgbe_fdir_filter *input,\n };\n \n static struct ixgbe_mat_field ixgbe_tcp_fields[] = {\n-\t{.off = 0, .mask = 0xffff, .val = ixgbe_mat_prgm_sport,\n+\t{.off = 0, .val = ixgbe_mat_prgm_sport,\n \t .type = IXGBE_ATR_FLOW_TYPE_TCPV4},\n-\t{.off = 2, .mask = 0xffff, .val = ixgbe_mat_prgm_dport,\n+\t{.off = 2, .val = ixgbe_mat_prgm_dport,\n \t .type = IXGBE_ATR_FLOW_TYPE_TCPV4},\n \t{ .val = NULL } /* terminal node */\n };\n", "prefixes": [ "v2", "net-next", "2/3" ] }