Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/591151/?format=api
{ "id": 591151, "url": "http://patchwork.ozlabs.org/api/patches/591151/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160302211608.2124.80148.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160302211608.2124.80148.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2016-03-02T21:16:08", "name": "[net,2/2] e1000: Double Tx descriptors needed check for 82544", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3fa63774365c89f69a40a45e48ef11f7642d4c3a", "submitter": { "id": 67293, "url": "http://patchwork.ozlabs.org/api/people/67293/?format=api", "name": "Alexander Duyck", "email": "aduyck@mirantis.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160302211608.2124.80148.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/591151/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/591151/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 791EA1414D6\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 3 Mar 2016 09:26:55 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C0BE6A6530;\n\tWed, 2 Mar 2016 22:26:54 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4agOSIVJ4_Uf; Wed, 2 Mar 2016 22:26:54 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3F512A63F8;\n\tWed, 2 Mar 2016 22:26:54 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 53F381C16AF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Mar 2016 22:26:53 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4F3F69234C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Mar 2016 22:26:53 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hhjkezNjhK8Y for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Mar 2016 22:26:52 +0000 (UTC)", "from mail-pf0-f171.google.com (mail-pf0-f171.google.com\n\t[209.85.192.171])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 99625921E7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Mar 2016 22:26:52 +0000 (UTC)", "by mail-pf0-f171.google.com with SMTP id 124so1907939pfg.0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 02 Mar 2016 14:26:52 -0800 (PST)", "from localhost.localdomain ([64.124.158.100])\n\tby smtp.gmail.com with ESMTPSA id\n\tv7sm1468942pfa.80.2016.03.02.14.26.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 02 Mar 2016 14:26:51 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mirantis.com header.i=@mirantis.com\n\theader.b=BBtFNL60; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com;\n\ts=google; \n\th=subject:from:to:date:message-id:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=LxRzur4rQtSoOzvRSDI/B2Ik2RVPAoO+fngVcG3kPf8=;\n\tb=BBtFNL60SWbZJH7SUX4ciJk0h8Pq4GEA640njFDeG+F00o2zk5RHHge/9pgn4m2IP8\n\tIPBNtzzAb4tM2Fs1vc3QkSrj60pcUhqoQARl43GAFrRJRZSDnwDTRnm9Z9JcgWSxVUyX\n\td5oHVbbGmFSZMJeM2O0S8T0n8WFzGI1dOx6xM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=LxRzur4rQtSoOzvRSDI/B2Ik2RVPAoO+fngVcG3kPf8=;\n\tb=jIYSYSPJjjPG6u5bKolERbBPUzvQYg3sr8b8l27oKPIqzCbJH/0eXRZY4cu7BIgAPo\n\tshtb66bAhv5MMaP2jsl+nGiS+9HlV3bY++ojYtV0UBDMuyZgUZr5a3PsO4V340Z1In+Q\n\tq1bzD3TMzgITcSfVNQleUFf23SSY+svnRP2IILrh/p4+piYcAdbEk2p4UGu+TABpbm8K\n\tsgiz1YG9nSZYFpV85jafuKjCv4k2hFJfIDGg6neV1MU5ICSJ1RbVVOakoz6lXH6bWXVX\n\toNCo0+KsHvbXLuAN9f2xV01ZMs22PmpKYu2SW8xgz3mMoB5C1/QC91DorJ2ihmsBgzzp\n\t4hpg==", "X-Gm-Message-State": "AD7BkJL7NPeXhWyX+HaiyskMC8hck14PG4e7oqWzp6HPSdFevhBAL2Xp9qQxlhPaKO061hhw", "X-Received": "by 10.98.18.28 with SMTP id a28mr9112441pfj.145.1456957612337;\n\tWed, 02 Mar 2016 14:26:52 -0800 (PST)", "From": "Alexander Duyck <aduyck@mirantis.com>", "To": "netdev@vger.kernel.org, jogreene@redhat.com,\n\tintel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com,\n\tsassmann@redhat.com", "Date": "Wed, 02 Mar 2016 16:16:08 -0500", "Message-ID": "<20160302211608.2124.80148.stgit@localhost.localdomain>", "In-Reply-To": "<20160302205129.2124.67042.stgit@localhost.localdomain>", "References": "<20160302205129.2124.67042.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net PATCH 2/2] e1000: Double Tx descriptors\n\tneeded check for 82544", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The 82544 has code that adds one additional descriptor per data buffer.\nHowever we weren't taking that into acount when determining the descriptors\nneeded for the next transmit at the end of the xmit_frame path.\n\nThis change takes that into account by doubling the number of descriptors\nneeded for the 82544 so that we can avoid a potential issue where we could\nhang the Tx ring by loading frames with xmit_more enabled and then stopping\nthe ring without writing the tail.\n\nIn addition it adds a few more descriptors to account for some additional\nworkarounds that have been added over time.\n\nSigned-off-by: Alexander Duyck <aduyck@mirantis.com>\n---\n drivers/net/ethernet/intel/e1000/e1000_main.c | 19 ++++++++++++++++++-\n 1 file changed, 18 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c\nindex d213fb4..ae90d4f 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_main.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c\n@@ -3256,12 +3256,29 @@ static netdev_tx_t e1000_xmit_frame(struct sk_buff *skb,\n \t\t\t nr_frags, mss);\n \n \tif (count) {\n+\t\t/* The descriptors needed is higher than other Intel drivers\n+\t\t * due to a number of workarounds. The breakdown is below:\n+\t\t * Data descriptors: MAX_SKB_FRAGS + 1\n+\t\t * Context Descriptor: 1\n+\t\t * Keep head from touching tail: 2\n+\t\t * Workarounds: 3\n+\t\t */\n+\t\tint desc_needed = MAX_SKB_FRAGS + 7;\n+\n \t\tnetdev_sent_queue(netdev, skb->len);\n \t\tskb_tx_timestamp(skb);\n \n \t\te1000_tx_queue(adapter, tx_ring, tx_flags, count);\n+\n+\t\t/* 82544 potentially requires twice as many data descriptors\n+\t\t * in order to guarantee buffers don't end on evenly-aligned\n+\t\t * dwords\n+\t\t */\n+\t\tif (adapter->pcix_82544)\n+\t\t\tdesc_needed += MAX_SKB_FRAGS + 1;\n+\n \t\t/* Make sure there is space in the ring for the next send. */\n-\t\te1000_maybe_stop_tx(netdev, tx_ring, MAX_SKB_FRAGS + 2);\n+\t\te1000_maybe_stop_tx(netdev, tx_ring, desc_needed);\n \n \t\tif (!skb->xmit_more ||\n \t\t netif_xmit_stopped(netdev_get_tx_queue(netdev, 0))) {\n", "prefixes": [ "net", "2/2" ] }