Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/591150/?format=api
{ "id": 591150, "url": "http://patchwork.ozlabs.org/api/patches/591150/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160302211601.2124.64160.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160302211601.2124.64160.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2016-03-02T21:16:01", "name": "[net,1/2] e1000: Do not overestimate descriptor counts in Tx pre-check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4a55de4ac30cd70caf065e3861ba08434264ec43", "submitter": { "id": 67293, "url": "http://patchwork.ozlabs.org/api/people/67293/?format=api", "name": "Alexander Duyck", "email": "aduyck@mirantis.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160302211601.2124.64160.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/591150/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/591150/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 39D171414D7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 3 Mar 2016 09:26:50 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 78330A653F;\n\tWed, 2 Mar 2016 22:26:49 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8BuRPdip_SoF; Wed, 2 Mar 2016 22:26:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 02E64A63F8;\n\tWed, 2 Mar 2016 22:26:48 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id B0C151C16AF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Mar 2016 22:26:46 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AB4ED95B21\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Mar 2016 22:26:46 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3jWUc14kSk2f for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Mar 2016 22:26:46 +0000 (UTC)", "from mail-pf0-f175.google.com (mail-pf0-f175.google.com\n\t[209.85.192.175])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 2F6AC95AA9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Mar 2016 22:26:46 +0000 (UTC)", "by mail-pf0-f175.google.com with SMTP id 63so1833183pfe.3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 02 Mar 2016 14:26:46 -0800 (PST)", "from localhost.localdomain ([64.124.158.100])\n\tby smtp.gmail.com with ESMTPSA id\n\txa9sm55382310pab.44.2016.03.02.14.26.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 02 Mar 2016 14:26:45 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mirantis.com header.i=@mirantis.com\n\theader.b=ap9CBMHL; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com;\n\ts=google; \n\th=subject:from:to:date:message-id:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=M6aJ3k2HKPMtSbzTfjsJ22/s5hVEFH3BUKpFbxxEkCE=;\n\tb=ap9CBMHLUZjypBr3F7StVgSISZ2ZQjenzadMxdTGJsSzxPfyLlVR5dgOE2nouEEsKq\n\tF9QEte2BESGxhHAxgoLDP17TQGRBcWR5szEabS212ikx3uVF6+HxKUMr37fA/JH2dckx\n\tG67anqlI90/FbIsSr4PQpFxXzxgMZmRkdKd+A=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=M6aJ3k2HKPMtSbzTfjsJ22/s5hVEFH3BUKpFbxxEkCE=;\n\tb=OsubZXt6wSP4RovzSonWnIA+gX5ocE96kZ5dfp47BeYAJ86MiGW2TNRr3s82A+zNx0\n\tLiELdJtGY06ZplqsSJXeV237euBJb6J4W0kyZqySf2oVFYqtynQSIbzLgV7ShtsKiPgu\n\tpMFeCdEscS5vVo+DKmlgBcT9niZZf+LWj//0MqId/xc16KIIJ/ZCDCje1mjFJJPmTc1b\n\thyPcwsGi5BxmRbJdYUxIUTFcQLihItMyxQG+uKXk51WBcNIQe5v8CCxUrOFl2ZzMmzjE\n\tnh9qC4maXg8umxfi2ez2mWCXSwgBsa+MkJ2dnBRxfUiZWEvnLDUg75XbAzAXkB6OBnSD\n\tPd4w==", "X-Gm-Message-State": "AD7BkJKSLgblE8DKEokOcUcv4ZNP7SrDE85jozu9tMmqzuMJ2JZEcQT392DCJTPxudC024lt", "X-Received": "by 10.98.72.8 with SMTP id v8mr26320884pfa.62.1456957605925;\n\tWed, 02 Mar 2016 14:26:45 -0800 (PST)", "From": "Alexander Duyck <aduyck@mirantis.com>", "To": "netdev@vger.kernel.org, jogreene@redhat.com,\n\tintel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com,\n\tsassmann@redhat.com", "Date": "Wed, 02 Mar 2016 16:16:01 -0500", "Message-ID": "<20160302211601.2124.64160.stgit@localhost.localdomain>", "In-Reply-To": "<20160302205129.2124.67042.stgit@localhost.localdomain>", "References": "<20160302205129.2124.67042.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net PATCH 1/2] e1000: Do not overestimate\n\tdescriptor counts in Tx pre-check", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The current code path is capable of grossly overestimating the number of\ndescriptors needed to transmit a new frame. This specifically occurs if\nthe skb contains a number of 4K pages. The issue is that the logic for\ndetermining the descriptors needed is ((S) >> (X)) + 1. When X is 12 it\nmeans that we were indicating that we required 2 descriptors for each 4K\npage when we only needed one.\n\nThis change corrects this by instead adding (1 << (X)) - 1 to the S value\ninstead of adding 1 after the fact. This way we get an accurate descriptor\nneeded count as we are essentially doing a DIV_ROUNDUP().\n\nReported-by: Ivan Suzdal <isuzdal@mirantis.com>\nSigned-off-by: Alexander Duyck <aduyck@mirantis.com>\n---\n drivers/net/ethernet/intel/e1000/e1000_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c\nindex 3fc7bde..d213fb4 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_main.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c\n@@ -3106,7 +3106,7 @@ static int e1000_maybe_stop_tx(struct net_device *netdev,\n \treturn __e1000_maybe_stop_tx(netdev, size);\n }\n \n-#define TXD_USE_COUNT(S, X) (((S) >> (X)) + 1)\n+#define TXD_USE_COUNT(S, X) (((S) + ((1 << (X)) - 1)) >> (X))\n static netdev_tx_t e1000_xmit_frame(struct sk_buff *skb,\n \t\t\t\t struct net_device *netdev)\n {\n", "prefixes": [ "net", "1/2" ] }