Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/590823/?format=api
{ "id": 590823, "url": "http://patchwork.ozlabs.org/api/patches/590823/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1456876935-4810-1-git-send-email-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1456876935-4810-1-git-send-email-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2016-03-02T00:02:15", "name": "i40evf: remove dead code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "739c06eda5e3f0ef36cdfbc29f04b2aebf8f3264", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1456876935-4810-1-git-send-email-jeffrey.t.kirsher@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/590823/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/590823/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 755F1140291\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 2 Mar 2016 11:02:21 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A1BBAA611D;\n\tWed, 2 Mar 2016 00:02:20 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5L0tPJcIsG4k; Wed, 2 Mar 2016 00:02:20 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4924885A96;\n\tWed, 2 Mar 2016 00:02:20 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 92A7D1CFB49\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Mar 2016 00:02:19 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8C73785A96\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Mar 2016 00:02:19 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id q4T4p_UHpWSg for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Mar 2016 00:02:18 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 04EA5A611A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Mar 2016 00:02:17 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP; 01 Mar 2016 16:02:18 -0800", "from rsbell-mobl2.amr.corp.intel.com (HELO\n\tjtkirshe-mobl.amr.corp.intel.com) ([10.252.140.15])\n\tby orsmga001.jf.intel.com with ESMTP; 01 Mar 2016 16:02:17 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.22,524,1449561600\"; d=\"scan'208\";a=\"898913988\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Tue, 1 Mar 2016 16:02:15 -0800", "Message-Id": "<1456876935-4810-1-git-send-email-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.5.0", "Cc": "Alan Cox <alan@linux.intel.com>", "Subject": "[Intel-wired-lan] [PATCH] i40evf: remove dead code", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alan Cox <alan@linux.intel.com>\n\nThe only error case is when the malloc fails, in which case the clean up\nloop does nothing at all, so remove it\n\nSigned-off-by: Alan Cox <alan@linux.intel.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 11 +----------\n 1 file changed, 1 insertion(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 66964eb..c1cb910 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -1506,7 +1506,7 @@ static int i40evf_alloc_q_vectors(struct i40evf_adapter *adapter)\n \tadapter->q_vectors = kcalloc(num_q_vectors, sizeof(*q_vector),\n \t\t\t\t GFP_KERNEL);\n \tif (!adapter->q_vectors)\n-\t\tgoto err_out;\n+\t\treturn -ENOMEM;\n \n \tfor (q_idx = 0; q_idx < num_q_vectors; q_idx++) {\n \t\tq_vector = &adapter->q_vectors[q_idx];\n@@ -1518,15 +1518,6 @@ static int i40evf_alloc_q_vectors(struct i40evf_adapter *adapter)\n \t}\n \n \treturn 0;\n-\n-err_out:\n-\twhile (q_idx) {\n-\t\tq_idx--;\n-\t\tq_vector = &adapter->q_vectors[q_idx];\n-\t\tnetif_napi_del(&q_vector->napi);\n-\t}\n-\tkfree(adapter->q_vectors);\n-\treturn -ENOMEM;\n }\n \n /**\n", "prefixes": [] }