Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/584649/?format=api
{ "id": 584649, "url": "http://patchwork.ozlabs.org/api/patches/584649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/56C5A6BC.6030708@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<56C5A6BC.6030708@gmail.com>", "list_archive_url": null, "date": "2016-02-18T11:10:52", "name": "[next] igb: allow setting MAC address on i211 using a device tree blob V5", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e37ae184e1a3e07a76dcbcdf02af07edbbf93825", "submitter": { "id": 68213, "url": "http://patchwork.ozlabs.org/api/people/68213/?format=api", "name": "John Holland", "email": "jotihojr@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/56C5A6BC.6030708@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/584649/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/584649/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 278851402A0\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 18 Feb 2016 22:11:01 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6AF0595A60;\n\tThu, 18 Feb 2016 11:11:00 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HfDBXtuxhpkg; Thu, 18 Feb 2016 11:10:59 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 693A0959A6;\n\tThu, 18 Feb 2016 11:10:59 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2A0461C1209\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 Feb 2016 11:10:58 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 237EDA58AE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 Feb 2016 11:10:58 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id q7bKm06qgrv8 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 Feb 2016 11:10:56 +0000 (UTC)", "from mail-wm0-f45.google.com (mail-wm0-f45.google.com\n\t[74.125.82.45])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 696E1A56E5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 Feb 2016 11:10:55 +0000 (UTC)", "by mail-wm0-f45.google.com with SMTP id g62so20046020wme.0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 Feb 2016 03:10:55 -0800 (PST)", "from [10.0.2.46] (3qpe.de. [5.158.129.220])\n\tby smtp.googlemail.com with ESMTPSA id\n\tei9sm6017465wjd.40.2016.02.18.03.10.53\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tThu, 18 Feb 2016 03:10:53 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=M5GJQXnd;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=to:from:subject:message-id:date:user-agent:mime-version\n\t:content-type:content-transfer-encoding;\n\tbh=FP3kX5xvvyXoDD8dUcSJ/fPQqZk+MmtfZM/zoD8lQ8w=;\n\tb=M5GJQXndylK2yXp67HBVg1lqhQUBaCw0R9yinBtrHAWghHidkrNYU6CR+zJnsUpx/X\n\tu9aC1CjxJiRuidWHiZ7MeA2GsDaOAI9/wvVekYKtzukFPCk9/wc96FQ5fpJh7H68Ip7E\n\tqrRr6nfMB4/jxPZxA4/Hta5Epe/i1vYtyGT+eqUwO43WhzZSB7wR7xvpeKySWJnOAoMH\n\tH4Po3prvLhHL4MG01HJp9WeMXABAABOx4q6sZG5LKx5L8I2h1wPFbTCm6lqg1lZjVfeX\n\tmyJXeekVeKsVidr29mLNr3mz3WXytXy00nGo7AxMl8K65TUOwjjkQy5LC1XomsGISaMw\n\t8vkg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:to:from:subject:message-id:date:user-agent\n\t:mime-version:content-type:content-transfer-encoding;\n\tbh=FP3kX5xvvyXoDD8dUcSJ/fPQqZk+MmtfZM/zoD8lQ8w=;\n\tb=bQ+/OfTeSuDXox8QnGfGujU8zekWiU/NEpKXZtQgY8myhCTKnek6UG2zRrMvDR3gBE\n\tPb3wA8e34RiCjljwN0bN9uRUCnDOb0mD99UIhEidQ9wCETGlSkS8NuXbT7HQZw/h215t\n\tZlBEdNRFmLgRNLXFY7FaNKWd1pZTf0OKiaggwt968wuuu6Aalobe5Q2lHBXvJ0/6DtOv\n\tG5A19yivTDBF5XJCbneGWqps6fEmHiZxfCLZ5Ew3I50g+jIg2b7cKwCOKKTPBPOtykkm\n\t0PbQkKpXxOPyMpkzW+0jYryAb6WgJ0hQMNDzRgoJrai8W/m3dUtd1ulT6VsS+8ahd4Cw\n\tEFkg==", "X-Gm-Message-State": "AG10YORqvKiGVNXCVRYCCrKKnco8j3un26c1IouJW2MXZ1NGIgFtqohq8s+JyVnw6uveyw==", "X-Received": "by 10.194.133.1 with SMTP id oy1mr6756474wjb.119.1455793854004; \n\tThu, 18 Feb 2016 03:10:54 -0800 (PST)", "To": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "From": "John Holland <jotihojr@gmail.com>", "Message-ID": "<56C5A6BC.6030708@gmail.com>", "Date": "Thu, 18 Feb 2016 12:10:52 +0100", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101\n\tThunderbird/38.5.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next] igb: allow setting MAC address on i211\n\tusing a device tree blob V5", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Transfer-Encoding": "7bit", "Content-Type": "text/plain; charset=\"us-ascii\"; Format=\"flowed\"", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Hello,\n\nThe Intel i211 LOM PCIe Ethernet controllers' iNVM operates as an OTP\nand has no external EEPROM interface [1]. The following allows the\ndriver to pickup the MAC address from a device tree blob when CONFIG_OF\nhas been enabled.\n\n[1] \nhttp://www.intel.com/content/www/us/en/embedded/products/networking/i211-ethernet-controller-datasheet.html\n\nChanges V2\n- Restrict searching for compatible devices to current pci device.\n\nChanges V3\n- Add device tree binding documentation.\n\nChanges V4\n- Rebase patch.\n\nChanges V5\n- Use eth_platform_get_mac_address() to resolve MAC specified in a dtb.\n- Remove now invalid device tree binding documentation specified in V3\n und V4.\n\nSigned-off-by: John Holland<jotihojr@gmail.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c \nb/drivers/net/ethernet/intel/igb/igb_main.c\nindex a98f418..d3e8228 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -50,6 +50,7 @@\n #include <linux/aer.h>\n #include <linux/prefetch.h>\n #include <linux/pm_runtime.h>\n+#include <linux/etherdevice.h>\n #ifdef CONFIG_IGB_DCA\n #include <linux/dca.h>\n #endif\n@@ -2507,9 +2508,11 @@ static int igb_probe(struct pci_dev *pdev, const \nstruct pci_device_id *ent)\n break;\n }\n\n- /* copy the MAC address out of the NVM */\n- if (hw->mac.ops.read_mac_addr(hw))\n- dev_err(&pdev->dev, \"NVM Read Error\\n\");\n+ if (eth_platform_get_mac_address(&pdev->dev, hw->mac.addr)) {\n+ /* copy the MAC address out of the NVM */\n+ if (hw->mac.ops.read_mac_addr(hw))\n+ dev_err(&pdev->dev, \"NVM Read Error\\n\");\n+ }\n\n memcpy(netdev->dev_addr, hw->mac.addr, netdev->addr_len);\n", "prefixes": [ "next" ] }