Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/584323/?format=api
{ "id": 584323, "url": "http://patchwork.ozlabs.org/api/patches/584323/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160217190256.10339.83791.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160217190256.10339.83791.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2016-02-17T19:02:56", "name": "[next,3/4] i40e/i40evf: Move Tx checksum closer to TSO", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "143f32bcfb60e4c2d90e6f74c5d2c2e3fcd241f4", "submitter": { "id": 67293, "url": "http://patchwork.ozlabs.org/api/people/67293/?format=api", "name": "Alexander Duyck", "email": "aduyck@mirantis.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160217190256.10339.83791.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/584323/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/584323/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id CB79B140271\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 18 Feb 2016 06:03:00 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2C9EEA5EC8;\n\tWed, 17 Feb 2016 19:03:00 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zU2u84Bz9M2w; Wed, 17 Feb 2016 19:02:59 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 63D66A5E88;\n\tWed, 17 Feb 2016 19:02:59 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id AE1AE1C0BC2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Feb 2016 19:02:58 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id AA8D29219D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Feb 2016 19:02:58 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YvaXgZ9kK3FS for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Feb 2016 19:02:58 +0000 (UTC)", "from mail-pf0-f170.google.com (mail-pf0-f170.google.com\n\t[209.85.192.170])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 067E392180\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Feb 2016 19:02:58 +0000 (UTC)", "by mail-pf0-f170.google.com with SMTP id c10so16672477pfc.2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Feb 2016 11:02:58 -0800 (PST)", "from localhost.localdomain\n\t(static-50-53-29-36.bvtn.or.frontiernet.net. [50.53.29.36])\n\tby smtp.gmail.com with ESMTPSA id\n\tfa3sm4294955pab.45.2016.02.17.11.02.56\n\tfor <intel-wired-lan@lists.osuosl.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 17 Feb 2016 11:02:57 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mirantis.com header.i=@mirantis.com\n\theader.b=Lx+NBEjN; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com;\n\ts=google; \n\th=subject:from:to:date:message-id:in-reply-to:references:user-agent\n\t:mime-version:content-type:content-transfer-encoding;\n\tbh=o1Ol2/TKVGleTwqzNGIT00+WibXKsGAIRh1lHRjT5ZE=;\n\tb=Lx+NBEjNuaSwVM+F08NxIccge+BJRanNHx7GiHyfzu+FiiMvncEnjoNQamt7tLXgKd\n\ti0Ns68W5diwgfj33m+gD/oMDGnNCWLHMiDf+27JM+xI0EFktdPWOCHKILSYDUf7bR+bX\n\tECTzU50oRiWwnVpbmgEumjrCeeGMTPExlMd24=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-type\n\t:content-transfer-encoding;\n\tbh=o1Ol2/TKVGleTwqzNGIT00+WibXKsGAIRh1lHRjT5ZE=;\n\tb=jQzeFbcFxBI4EOmi2qfSR/EP4QX7c8ujj3PBOMoDssWpp9C63qEzQeOMrJDZJRnWgA\n\tWbtRGc914jOZnsBF6PGKA416PBB/KvixlAa+xP02SFPNMfqIalIM2nMtD3baPxF41D2k\n\tOptngL7Ei8BoefofIaAK5XkudLALDuuTcIadwunt5yHJf6OpS+gL5c4bxzE7OPYFK1Sr\n\toSkQEovP43vU1NXOAyCva1KA95cEglRm7w5MyhXa5pLjNPc0Y32HxL3PjhjWfcOtrIXd\n\tzlOa/AvvRfPYUFC0FrLDQ6jXwmmbUfuXXU0np7IXVrPlbExGDvjXmhw58K7KZMVt9g3w\n\tKxkw==", "X-Gm-Message-State": "AG10YOTdo3TbSlwz+EbNtG7pf7CE+RSp42uzNgxJABu7a96N7aqssA8HuFUyHwh/t1/zUGbr", "X-Received": "by 10.98.42.8 with SMTP id q8mr4329005pfq.13.1455735777764;\n\tWed, 17 Feb 2016 11:02:57 -0800 (PST)", "From": "Alexander Duyck <aduyck@mirantis.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 17 Feb 2016 11:02:56 -0800", "Message-ID": "<20160217190256.10339.83791.stgit@localhost.localdomain>", "In-Reply-To": "<20160217185838.10339.68543.stgit@localhost.localdomain>", "References": "<20160217185838.10339.68543.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH 3/4] i40e/i40evf: Move Tx checksum\n\tcloser to TSO", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "On all of the other Intel drivers we place checksum close to TSO as they\nhave a significant amount in common and it can help to reduce the decision\ntree for how to handle the frame as the first check in TSO is to see if\nchecksumming is offloaded, and if it is not we can skip _BOTH_ TSO and Tx\nchecksum offload based on a single check.\n\nSigned-off-by: Alexander Duyck <aduyck@mirantis.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 12 ++++++------\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 10 +++++-----\n 2 files changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex 5123646a895f..cb52f39d514a 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -2929,6 +2929,12 @@ static netdev_tx_t i40e_xmit_frame_ring(struct sk_buff *skb,\n \telse if (tso)\n \t\ttx_flags |= I40E_TX_FLAGS_TSO;\n \n+\t/* Always offload the checksum, since it's in the data descriptor */\n+\ttso = i40e_tx_enable_csum(skb, &tx_flags, &td_cmd, &td_offset,\n+\t\t\t\t tx_ring, &cd_tunneling);\n+\tif (tso < 0)\n+\t\tgoto out_drop;\n+\n \ttsyn = i40e_tsyn(tx_ring, skb, tx_flags, &cd_type_cmd_tso_mss);\n \n \tif (tsyn)\n@@ -2939,12 +2945,6 @@ static netdev_tx_t i40e_xmit_frame_ring(struct sk_buff *skb,\n \t/* always enable CRC insertion offload */\n \ttd_cmd |= I40E_TX_DESC_CMD_ICRC;\n \n-\t/* Always offload the checksum, since it's in the data descriptor */\n-\ttso = i40e_tx_enable_csum(skb, &tx_flags, &td_cmd, &td_offset,\n-\t\t\t\t tx_ring, &cd_tunneling);\n-\tif (tso < 0)\n-\t\tgoto out_drop;\n-\n \ti40e_create_tx_ctx(tx_ring, cd_type_cmd_tso_mss,\n \t\t\t cd_tunneling, cd_l2tag2);\n \ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex 1dd1cc12304b..686a95fe48bd 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -2146,17 +2146,17 @@ static netdev_tx_t i40e_xmit_frame_ring(struct sk_buff *skb,\n \telse if (tso)\n \t\ttx_flags |= I40E_TX_FLAGS_TSO;\n \n-\tskb_tx_timestamp(skb);\n-\n-\t/* always enable CRC insertion offload */\n-\ttd_cmd |= I40E_TX_DESC_CMD_ICRC;\n-\n \t/* Always offload the checksum, since it's in the data descriptor */\n \ttso = i40e_tx_enable_csum(skb, &tx_flags, &td_cmd, &td_offset,\n \t\t\t\t tx_ring, &cd_tunneling);\n \tif (tso < 0)\n \t\tgoto out_drop;\n \n+\tskb_tx_timestamp(skb);\n+\n+\t/* always enable CRC insertion offload */\n+\ttd_cmd |= I40E_TX_DESC_CMD_ICRC;\n+\n \ti40e_create_tx_ctx(tx_ring, cd_type_cmd_tso_mss,\n \t\t\t cd_tunneling, cd_l2tag2);\n \n", "prefixes": [ "next", "3/4" ] }