Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/583954/?format=api
{ "id": 583954, "url": "http://patchwork.ozlabs.org/api/patches/583954/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1455694465-1226-1-git-send-email-doron.shikmoni@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1455694465-1226-1-git-send-email-doron.shikmoni@gmail.com>", "list_archive_url": null, "date": "2016-02-17T07:34:25", "name": "igb: Garbled output for \"ethtool -m\"", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e2c2417f3dfb5eb6e87a3ba745c01d2ebf9ca4ec", "submitter": { "id": 67295, "url": "http://patchwork.ozlabs.org/api/people/67295/?format=api", "name": "Doron Shikmoni", "email": "doron.shikmoni@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1455694465-1226-1-git-send-email-doron.shikmoni@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/583954/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/583954/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 773221402A1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Feb 2016 18:37:23 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B53E792248;\n\tWed, 17 Feb 2016 07:37:22 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Z-ewokg7F6oJ; Wed, 17 Feb 2016 07:37:22 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 20B4D91FCA;\n\tWed, 17 Feb 2016 07:37:22 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id DB86A1BF972\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Feb 2016 07:37:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D060F26131\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Feb 2016 07:37:20 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bzt0PuZMkfwX for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Feb 2016 07:37:20 +0000 (UTC)", "from mail-wm0-f45.google.com (mail-wm0-f45.google.com\n\t[74.125.82.45])\n\tby silver.osuosl.org (Postfix) with ESMTPS id B671B2359A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Feb 2016 07:37:19 +0000 (UTC)", "by mail-wm0-f45.google.com with SMTP id c200so198597057wme.0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Feb 2016 23:37:19 -0800 (PST)", "from localhost.localdomain ([77.125.133.49])\n\tby smtp.gmail.com with ESMTPSA id\n\tq129sm1686380wmd.14.2016.02.16.23.37.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 16 Feb 2016 23:37:17 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=VAcO36w7;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:cc:subject:date:message-id;\n\tbh=bevtlOQJ5klm8x1KfAD3BOpm4GrZ5fwMdWUXlIlP9gs=;\n\tb=VAcO36w73Um75BTwAFxVHhnq/MzhyYexp0x0zvoxfYXkRdMidT+3bsjGm4S9gBNZdN\n\tbDcCMeNBfTZPGs4+aiYFdmjmQm18zeqmMR2zwjNHGh/ukQF10nzA6Jz9DPaDSxfwJ8OK\n\tB3Kqd+yyiHm/40/KYj5FsrD+VoN4Tt6g7jUcT/0JrePeFsdDVnhKoWYqaBJHLqA73TaY\n\tzt8YSeLH7Nufs5qBmPho4VQ/lRePupdi1QDZwFcAlnBXqYxUrYKCqRQvgLo7a9YLo6uc\n\tb/O0Yi8QV2mChLBITfWYKtbf9159TyNMpP0cC4FjCXMkf/JUE2qoZbf24rP1KYWerhEL\n\t+32A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=bevtlOQJ5klm8x1KfAD3BOpm4GrZ5fwMdWUXlIlP9gs=;\n\tb=OM1kRNPrEuojSklelJopXgQa7LQcXbqAX3PDyZtIiTGxmhL88UEj9cfqe3dgBUt+71\n\tqSCUznfW6lAFWIN04ihYJtaUr0HazOhCijJcvNtjZAi/QUJAW9bx6OAxmuUicKqeRFVD\n\tWreJs4ICEQbAjjRbIY7z0zlY/X7dPeQrlOYnJKrckiBEj3zKHUWAwXExXZ3kj1YprKqk\n\tk7z8XZ/xmQI68e72Awup2o3aV+Q4GYMNe7QNQU4JCQg46aFF3WVXyaSsBahnA1QsMj4e\n\ttq6Z/9r/tUombfSVxXo+mbcIMejbeBAhCVE5NysD6A2QusOykeMGhJ4sjsb3Ti4rbEkD\n\tB9Pg==", "X-Gm-Message-State": "AG10YOTvPE+0IB3h7Zzk4uMZf34kp0xLzeF1a3Yy8R54H0QL27O+9y9y+cAQ08QTGZ6Vow==", "X-Received": "by 10.28.65.193 with SMTP id o184mr22568345wma.15.1455694638222; \n\tTue, 16 Feb 2016 23:37:18 -0800 (PST)", "From": "Doron Shikmoni <doron.shikmoni@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 17 Feb 2016 09:34:25 +0200", "Message-Id": "<1455694465-1226-1-git-send-email-doron.shikmoni@gmail.com>", "X-Mailer": "git-send-email 1.7.10.4", "Cc": "netdev@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] igb: Garbled output for \"ethtool -m\"", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Hello,\n\nGarbled output for \"ethtool -m ethX\", in igb-driven NICs with module /\nplugin EEPROM (i.e. SFP information). Each output data byte appears\nduplicated.\n\nIn igb_ethtool.c, igb_get_module_eeprom() is reading the EEPROM via i2c;\nthe eeprom offset for each word that's read via igb_read_phy_reg_i2c()\nwas passed in #words, whereas it needs to be a byte offset.\nThis patches fixes the bug.\n\nSigned-off-by: Doron Shikmoni <doron.shikmoni@gmail.com>\n---\n drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c\nindex 1d329f1..7bcc0e1e 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c\n@@ -2831,7 +2831,7 @@ static int igb_get_module_eeprom(struct net_device *netdev,\n \n \t/* Read EEPROM block, SFF-8079/SFF-8472, word at a time */\n \tfor (i = 0; i < last_word - first_word + 1; i++) {\n-\t\tstatus = igb_read_phy_reg_i2c(hw, first_word + i, &dataword[i]);\n+\t\tstatus = igb_read_phy_reg_i2c(hw, (first_word + i) * 2, &dataword[i]);\n \t\tif (status) {\n \t\t\t/* Error occurred while reading module */\n \t\t\tkfree(dataword);\n", "prefixes": [] }