Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/583778/?format=api
{ "id": 583778, "url": "http://patchwork.ozlabs.org/api/patches/583778/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1455668365-30782-2-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1455668365-30782-2-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-02-17T00:19:25", "name": "[2/2] fm10k: Avoid crashing the kernel", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": false, "hash": "6a2423d05134fd8e570880272405d6a1e0fe7ef0", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1455668365-30782-2-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/583778/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/583778/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id B29F71401E7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Feb 2016 11:19:32 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id EA69892269;\n\tWed, 17 Feb 2016 00:19:31 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ZWdEYWLx5n5a; Wed, 17 Feb 2016 00:19:29 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A5BA8921B3;\n\tWed, 17 Feb 2016 00:19:29 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 094C31C1619\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Feb 2016 00:19:28 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 04C19954C8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Feb 2016 00:19:28 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kkhO46KMpsPQ for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Feb 2016 00:19:27 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9DE19953B0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Feb 2016 00:19:27 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga102.fm.intel.com with ESMTP; 16 Feb 2016 16:19:27 -0800", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.65])\n\tby orsmga002.jf.intel.com with ESMTP; 16 Feb 2016 16:19:27 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.22,457,1449561600\"; d=\"scan'208\";a=\"913758297\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Tue, 16 Feb 2016 16:19:25 -0800", "Message-Id": "<1455668365-30782-2-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.7.0.236.gda096a0.dirty", "In-Reply-To": "<1455668365-30782-1-git-send-email-jacob.e.keller@intel.com>", "References": "<1455668365-30782-1-git-send-email-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [PATCH 2/2] fm10k: Avoid crashing the kernel", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Use BUILD_BUG_ON() instead of BUG_ON() where appropriate to get a compile\nerror rather than crash the kernel.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\nI checked this works against allmodconfig, and defconfig. Note that\nonly allmodconfig seems to break the use of BUILD_BUG_ON in the latter\ncase, so I added a comment to indicate this. Sorry for the failures\nearlier.\n\n drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\nindex a1342be34be4..0b0531417835 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\n@@ -468,7 +468,7 @@ static void fm10k_get_reg_q(struct fm10k_hw *hw, u32 *buff, int i)\n \tbuff[idx++] = fm10k_read_reg(hw, FM10K_TX_SGLORT(i));\n \tbuff[idx++] = fm10k_read_reg(hw, FM10K_PFVTCTL(i));\n \n-\tBUG_ON(idx != FM10K_REGS_LEN_Q);\n+\tBUILD_BUG_ON(idx != FM10K_REGS_LEN_Q);\n }\n \n /* If function above adds more registers this define needs to be updated */\n@@ -484,6 +484,9 @@ static void fm10k_get_reg_vsi(struct fm10k_hw *hw, u32 *buff, int i)\n \tfor (j = 0; j < 32; j++)\n \t\tbuff[idx++] = fm10k_read_reg(hw, FM10K_RETA(i, j));\n \n+\t/* Unfortunately some kernel configurations prevent us from using\n+\t * BUILD_BUG_ON here, notably allmodconfig.\n+\t */\n \tBUG_ON(idx != FM10K_REGS_LEN_VSI);\n }\n \n", "prefixes": [ "2/2" ] }