Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/583152/?format=api
{ "id": 583152, "url": "http://patchwork.ozlabs.org/api/patches/583152/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1455407836-7188-1-git-send-email-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1455407836-7188-1-git-send-email-colin.king@canonical.com>", "list_archive_url": null, "date": "2016-02-13T23:57:16", "name": "i40e: remove redundant check on vsi->active_vlans", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7e9eb7bca9acf3cb5d87511166ca8f70d95122b2", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1455407836-7188-1-git-send-email-colin.king@canonical.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/583152/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/583152/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id A545B1402BC\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 16 Feb 2016 16:13:21 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DD078954C2;\n\tTue, 16 Feb 2016 05:13:20 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LEXd6h-sP-EL; Tue, 16 Feb 2016 05:13:19 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C7F4C94FEF;\n\tTue, 16 Feb 2016 05:13:19 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 40D5E1C107C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 13 Feb 2016 23:57:23 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 38E1991DF7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 13 Feb 2016 23:57:23 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id vr9XrFkTeVpk for <intel-wired-lan@lists.osuosl.org>;\n\tSat, 13 Feb 2016 23:57:21 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 51C0E91DF6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 13 Feb 2016 23:57:21 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1aUk3x-0002TS-8D; Sat, 13 Feb 2016 23:57:17 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tJesse Brandeburg <jesse.brandeburg@intel.com>,\n\tShannon Nelson <shannon.nelson@intel.com>,\n\tCarolyn Wyborny <carolyn.wyborny@intel.com>,\n\tDon Skidmore <donald.c.skidmore@intel.com>,\n\tBruce Allan <bruce.w.allan@intel.com>,\n\tJohn Ronciak <john.ronciak@intel.com>,\n\tMitch Williams <mitch.a.williams@intel.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Sat, 13 Feb 2016 23:57:16 +0000", "Message-Id": "<1455407836-7188-1-git-send-email-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.7.0", "X-Mailman-Approved-At": "Tue, 16 Feb 2016 05:13:18 +0000", "Cc": "linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] i40e: remove redundant check on\n\tvsi->active_vlans", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nactive_vlans is an unsigned long array, hence a null check on this\narray is superfluous and can be removed.\n\nDetected with static analysis by smatch:\n\ndrivers/net/ethernet/intel/i40e/i40e_debugfs.c:386\n i40e_dbg_dump_vsi_seid() warn: this array is probably\n non-NULL. 'vsi->active_vlans'\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\nindex 10744a6..aba28be 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n@@ -383,9 +383,8 @@ static void i40e_dbg_dump_vsi_seid(struct i40e_pf *pf, int seid)\n \t\tdev_info(&pf->pdev->dev,\n \t\t\t \" netdev: name = %s\\n\",\n \t\t\t vsi->netdev->name);\n-\tif (vsi->active_vlans)\n-\t\tdev_info(&pf->pdev->dev,\n-\t\t\t \" vlgrp: & = %p\\n\", vsi->active_vlans);\n+\tdev_info(&pf->pdev->dev,\n+\t\t \" vlgrp: & = %p\\n\", vsi->active_vlans);\n \tdev_info(&pf->pdev->dev,\n \t\t \" netdev_registered = %i, current_netdev_flags = 0x%04x, state = %li flags = 0x%08lx\\n\",\n \t\t vsi->netdev_registered,\n", "prefixes": [] }