Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/579077/?format=api
{ "id": 579077, "url": "http://patchwork.ozlabs.org/api/patches/579077/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1454611679-17424-4-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1454611679-17424-4-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-02-04T18:47:57", "name": "[4/6] fm10k: print error message when stop_hw fails", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ac64212bc56964f61e326f9b93687af42ca3146d", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1454611679-17424-4-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/579077/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/579077/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 08B1A140C04\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 5 Feb 2016 05:48:32 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2AAD092294;\n\tThu, 4 Feb 2016 18:48:31 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3A94dDyF3fgL; Thu, 4 Feb 2016 18:48:29 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8B00F9222C;\n\tThu, 4 Feb 2016 18:48:29 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0767E1C0FC2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Feb 2016 18:48:28 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0312595694\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Feb 2016 18:48:28 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PQ9ps7xcAxW5 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Feb 2016 18:48:27 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 92B4C956B8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Feb 2016 18:48:27 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP; 04 Feb 2016 10:48:27 -0800", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.65])\n\tby fmsmga001.fm.intel.com with ESMTP; 04 Feb 2016 10:48:28 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.22,396,1449561600\"; d=\"scan'208\";a=\"896511427\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Thu, 4 Feb 2016 10:47:57 -0800", "Message-Id": "<1454611679-17424-4-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.7.0.236.gda096a0.dirty", "In-Reply-To": "<1454611679-17424-1-git-send-email-jacob.e.keller@intel.com>", "References": "<1454611679-17424-1-git-send-email-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [PATCH 4/6] fm10k: print error message when\n\tstop_hw fails", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "fm10k_stop_hw_generic calls fm10k_disable_queues_generic, which may\nreturn an error code indicating that the queues were not stopped within\nthe time limit. Notify the user by displaying a message in the kernel\nmessage ring, in a similar way to how we notify the user when reset_hw\nfails. There isn't much we can do to recover from this error, so\ncurrently nothing else is done.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex ed1f8cf39508..3c7c819ac8d9 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -1656,6 +1656,7 @@ void fm10k_down(struct fm10k_intfc *interface)\n {\n \tstruct net_device *netdev = interface->netdev;\n \tstruct fm10k_hw *hw = &interface->hw;\n+\tint err;\n \n \t/* signal that we are down to the interrupt handler and service task */\n \tset_bit(__FM10K_DOWN, &interface->state);\n@@ -1680,7 +1681,9 @@ void fm10k_down(struct fm10k_intfc *interface)\n \tfm10k_update_stats(interface);\n \n \t/* Disable DMA engine for Tx/Rx */\n-\thw->mac.ops.stop_hw(hw);\n+\terr = hw->mac.ops.stop_hw(hw);\n+\tif (err)\n+\t\tdev_err(&interface->pdev->dev, \"stop_hw failed: %d\\n\", err);\n \n \t/* free any buffers still on the rings */\n \tfm10k_clean_all_tx_rings(interface);\n", "prefixes": [ "4/6" ] }