Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/579075/?format=api
{ "id": 579075, "url": "http://patchwork.ozlabs.org/api/patches/579075/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1454611679-17424-1-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1454611679-17424-1-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-02-04T18:47:54", "name": "[1/6] fm10k: prevent null pointer dereference of msix_entries table", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "405f0d6f13e40ebc5510d406fd34f5bb378e4472", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1454611679-17424-1-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/579075/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/579075/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id ED432140325\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 5 Feb 2016 05:48:32 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8EC2E92247;\n\tThu, 4 Feb 2016 18:48:31 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id evcdHw7KzUqm; Thu, 4 Feb 2016 18:48:29 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5279C920CC;\n\tThu, 4 Feb 2016 18:48:29 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id D652E1C0FC2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Feb 2016 18:48:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id CF468956D6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Feb 2016 18:48:27 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wWAG40C76l4V for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Feb 2016 18:48:27 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1E4F495694\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Feb 2016 18:48:27 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP; 04 Feb 2016 10:48:26 -0800", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.65])\n\tby fmsmga001.fm.intel.com with ESMTP; 04 Feb 2016 10:48:27 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.22,396,1449561600\"; d=\"scan'208\";a=\"896511414\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Thu, 4 Feb 2016 10:47:54 -0800", "Message-Id": "<1454611679-17424-1-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.7.0.236.gda096a0.dirty", "Subject": "[Intel-wired-lan] [PATCH 1/6] fm10k: prevent null pointer\n\tdereference of msix_entries table", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "According to the C standard dereferencing a variable before it is\nchecked invokes undefined behavior, and thus compilers are free to\nassume the check for NULL isn't necessary. Prevent this by re-ordering\nthe NULL check of msix_entries in fm10k_free_mbx_irq.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex 6190a81b7c32..8c23fb3df572 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -1143,14 +1143,16 @@ static irqreturn_t fm10k_msix_mbx_pf(int __always_unused irq, void *data)\n \n void fm10k_mbx_free_irq(struct fm10k_intfc *interface)\n {\n-\tstruct msix_entry *entry = &interface->msix_entries[FM10K_MBX_VECTOR];\n \tstruct fm10k_hw *hw = &interface->hw;\n+\tstruct msix_entry *entry;\n \tint itr_reg;\n \n \t/* no mailbox IRQ to free if MSI-X is not enabled */\n \tif (!interface->msix_entries)\n \t\treturn;\n \n+\tentry = &interface->msix_entries[FM10K_MBX_VECTOR];\n+\n \t/* disconnect the mailbox */\n \thw->mbx.ops.disconnect(hw, &hw->mbx);\n \n", "prefixes": [ "1/6" ] }