Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/577769/?format=api
{ "id": 577769, "url": "http://patchwork.ozlabs.org/api/patches/577769/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1454487652-1545-6-git-send-email-sassmann@kpanic.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1454487652-1545-6-git-send-email-sassmann@kpanic.de>", "list_archive_url": null, "date": "2016-02-03T08:20:51", "name": "[net-next,V2,5/6] e1000: call ndo_stop() instead of dev_close() when running offline selftest", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "75065df86ae5d85c049ee724df2e36e4afd88d63", "submitter": { "id": 7508, "url": "http://patchwork.ozlabs.org/api/people/7508/?format=api", "name": "Stefan Assmann", "email": "sassmann@kpanic.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1454487652-1545-6-git-send-email-sassmann@kpanic.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/577769/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/577769/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 617F6140B93\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 3 Feb 2016 19:21:56 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id AAF0533AB1;\n\tWed, 3 Feb 2016 08:21:55 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iPZJAOhQpiDf; Wed, 3 Feb 2016 08:21:52 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 93A2433AF1;\n\tWed, 3 Feb 2016 08:21:52 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3D70D1C07A5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Feb 2016 08:21:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 39D11884CD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Feb 2016 08:21:51 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YCKLfSWiNF+L for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Feb 2016 08:21:50 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id B7852881A6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Feb 2016 08:21:50 +0000 (UTC)", "from int-mx10.intmail.prod.int.phx2.redhat.com\n\t(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\tby mx1.redhat.com (Postfix) with ESMTPS id 52BED5A6C;\n\tWed, 3 Feb 2016 08:21:50 +0000 (UTC)", "from w541.redhat.com (ovpn-116-36.ams2.redhat.com [10.36.116.36])\n\tby int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id u138LeHu022540; Wed, 3 Feb 2016 03:21:49 -0500" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Stefan Assmann <sassmann@kpanic.de>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 3 Feb 2016 09:20:51 +0100", "Message-Id": "<1454487652-1545-6-git-send-email-sassmann@kpanic.de>", "In-Reply-To": "<1454487652-1545-1-git-send-email-sassmann@kpanic.de>", "References": "<1454487652-1545-1-git-send-email-sassmann@kpanic.de>", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.23", "Cc": "netdev@vger.kernel.org, davem@davemloft.net, sassmann@kpanic.de", "Subject": "[Intel-wired-lan] [PATCH net-next V2 5/6] e1000: call ndo_stop()\n\tinstead of dev_close() when running offline selftest", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Calling dev_close() causes IFF_UP to be cleared which will remove the\ninterfaces routes and some addresses. That's probably not what the user\nintended when running the offline selftest. Besides this does not happen\nif the interface is brought down before the test, so the current\nbehaviour is inconsistent.\nInstead call the net_device_ops ndo_stop function directly and avoid\ntouching IFF_UP at all.\n\nSigned-off-by: Stefan Assmann <sassmann@kpanic.de>\n---\n drivers/net/ethernet/intel/e1000/e1000.h | 2 ++\n drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 4 ++--\n drivers/net/ethernet/intel/e1000/e1000_main.c | 8 ++++----\n 3 files changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000.h b/drivers/net/ethernet/intel/e1000/e1000.h\nindex 98fe5a2..d7bdea7 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000.h\n+++ b/drivers/net/ethernet/intel/e1000/e1000.h\n@@ -358,6 +358,8 @@ struct net_device *e1000_get_hw_dev(struct e1000_hw *hw);\n extern char e1000_driver_name[];\n extern const char e1000_driver_version[];\n \n+int e1000_open(struct net_device *netdev);\n+int e1000_close(struct net_device *netdev);\n int e1000_up(struct e1000_adapter *adapter);\n void e1000_down(struct e1000_adapter *adapter);\n void e1000_reinit_locked(struct e1000_adapter *adapter);\ndiff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\nindex 83e557c..975eeb8 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\n@@ -1553,7 +1553,7 @@ static void e1000_diag_test(struct net_device *netdev,\n \n \t\tif (if_running)\n \t\t\t/* indicate we're in test mode */\n-\t\t\tdev_close(netdev);\n+\t\t\te1000_close(netdev);\n \t\telse\n \t\t\te1000_reset(adapter);\n \n@@ -1582,7 +1582,7 @@ static void e1000_diag_test(struct net_device *netdev,\n \t\te1000_reset(adapter);\n \t\tclear_bit(__E1000_TESTING, &adapter->flags);\n \t\tif (if_running)\n-\t\t\tdev_open(netdev);\n+\t\t\te1000_open(netdev);\n \t} else {\n \t\te_info(hw, \"online testing starting\\n\");\n \t\t/* Online tests */\ndiff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c\nindex 3fc7bde..6de0c7d 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_main.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c\n@@ -114,8 +114,8 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent);\n static void e1000_remove(struct pci_dev *pdev);\n static int e1000_alloc_queues(struct e1000_adapter *adapter);\n static int e1000_sw_init(struct e1000_adapter *adapter);\n-static int e1000_open(struct net_device *netdev);\n-static int e1000_close(struct net_device *netdev);\n+int e1000_open(struct net_device *netdev);\n+int e1000_close(struct net_device *netdev);\n static void e1000_configure_tx(struct e1000_adapter *adapter);\n static void e1000_configure_rx(struct e1000_adapter *adapter);\n static void e1000_setup_rctl(struct e1000_adapter *adapter);\n@@ -1360,7 +1360,7 @@ static int e1000_alloc_queues(struct e1000_adapter *adapter)\n * handler is registered with the OS, the watchdog task is started,\n * and the stack is notified that the interface is ready.\n **/\n-static int e1000_open(struct net_device *netdev)\n+int e1000_open(struct net_device *netdev)\n {\n \tstruct e1000_adapter *adapter = netdev_priv(netdev);\n \tstruct e1000_hw *hw = &adapter->hw;\n@@ -1437,7 +1437,7 @@ err_setup_tx:\n * needs to be disabled. A global MAC reset is issued to stop the\n * hardware, and all transmit and receive resources are freed.\n **/\n-static int e1000_close(struct net_device *netdev)\n+int e1000_close(struct net_device *netdev)\n {\n \tstruct e1000_adapter *adapter = netdev_priv(netdev);\n \tstruct e1000_hw *hw = &adapter->hw;\n", "prefixes": [ "net-next", "V2", "5/6" ] }