Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/577765/?format=api
{ "id": 577765, "url": "http://patchwork.ozlabs.org/api/patches/577765/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1454487652-1545-4-git-send-email-sassmann@kpanic.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1454487652-1545-4-git-send-email-sassmann@kpanic.de>", "list_archive_url": null, "date": "2016-02-03T08:20:49", "name": "[net-next,V2,3/6] ixgbevf: call ndo_stop() instead of dev_close() when running offline selftest", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5e83dd60af7f078b72ad8a3975d2f67f5fd2140b", "submitter": { "id": 7508, "url": "http://patchwork.ozlabs.org/api/people/7508/?format=api", "name": "Stefan Assmann", "email": "sassmann@kpanic.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1454487652-1545-4-git-send-email-sassmann@kpanic.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/577765/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/577765/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id A05D7140B93\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 3 Feb 2016 19:21:52 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E134933B2B;\n\tWed, 3 Feb 2016 08:21:51 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TSizsaubutYK; Wed, 3 Feb 2016 08:21:49 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 3580F33852;\n\tWed, 3 Feb 2016 08:21:49 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1703C1C07A5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Feb 2016 08:21:48 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 12964884CD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Feb 2016 08:21:48 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6XpmGiz-k9ZA for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Feb 2016 08:21:47 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 835CB881A6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Feb 2016 08:21:47 +0000 (UTC)", "from int-mx10.intmail.prod.int.phx2.redhat.com\n\t(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1F0877AE94;\n\tWed, 3 Feb 2016 08:21:47 +0000 (UTC)", "from w541.redhat.com (ovpn-116-36.ams2.redhat.com [10.36.116.36])\n\tby int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id u138LeHs022540; Wed, 3 Feb 2016 03:21:45 -0500" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Stefan Assmann <sassmann@kpanic.de>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 3 Feb 2016 09:20:49 +0100", "Message-Id": "<1454487652-1545-4-git-send-email-sassmann@kpanic.de>", "In-Reply-To": "<1454487652-1545-1-git-send-email-sassmann@kpanic.de>", "References": "<1454487652-1545-1-git-send-email-sassmann@kpanic.de>", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.23", "Cc": "netdev@vger.kernel.org, davem@davemloft.net, sassmann@kpanic.de", "Subject": "[Intel-wired-lan] [PATCH net-next V2 3/6] ixgbevf: call ndo_stop()\n\tinstead of dev_close() when running offline selftest", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Calling dev_close() causes IFF_UP to be cleared which will remove the\ninterfaces routes and some addresses. That's probably not what the user\nintended when running the offline selftest. Besides this does not happen\nif the interface is brought down before the test, so the current\nbehaviour is inconsistent.\nInstead call the net_device_ops ndo_stop function directly and avoid\ntouching IFF_UP at all.\n\nSigned-off-by: Stefan Assmann <sassmann@kpanic.de>\n---\n drivers/net/ethernet/intel/ixgbevf/ethtool.c | 4 ++--\n drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 2 ++\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++--\n 3 files changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ethtool.c b/drivers/net/ethernet/intel/ixgbevf/ethtool.c\nindex c48aef6..d7aa4b2 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ethtool.c\n@@ -680,7 +680,7 @@ static void ixgbevf_diag_test(struct net_device *netdev,\n \n \t\tif (if_running)\n \t\t\t/* indicate we're in test mode */\n-\t\t\tdev_close(netdev);\n+\t\t\tixgbevf_close(netdev);\n \t\telse\n \t\t\tixgbevf_reset(adapter);\n \n@@ -692,7 +692,7 @@ static void ixgbevf_diag_test(struct net_device *netdev,\n \n \t\tclear_bit(__IXGBEVF_TESTING, &adapter->state);\n \t\tif (if_running)\n-\t\t\tdev_open(netdev);\n+\t\t\tixgbevf_open(netdev);\n \t} else {\n \t\thw_dbg(&adapter->hw, \"online testing starting\\n\");\n \t\t/* Online tests */\ndiff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h\nindex 68ec7daa..991eeae 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h\n@@ -486,6 +486,8 @@ extern const struct ixgbe_mbx_operations ixgbevf_mbx_ops;\n extern const char ixgbevf_driver_name[];\n extern const char ixgbevf_driver_version[];\n \n+int ixgbevf_open(struct net_device *netdev);\n+int ixgbevf_close(struct net_device *netdev);\n void ixgbevf_up(struct ixgbevf_adapter *adapter);\n void ixgbevf_down(struct ixgbevf_adapter *adapter);\n void ixgbevf_reinit_locked(struct ixgbevf_adapter *adapter);\ndiff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex 3558f01..01f79fa 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -3122,7 +3122,7 @@ static void ixgbevf_free_all_rx_resources(struct ixgbevf_adapter *adapter)\n * handler is registered with the OS, the watchdog timer is started,\n * and the stack is notified that the interface is ready.\n **/\n-static int ixgbevf_open(struct net_device *netdev)\n+int ixgbevf_open(struct net_device *netdev)\n {\n \tstruct ixgbevf_adapter *adapter = netdev_priv(netdev);\n \tstruct ixgbe_hw *hw = &adapter->hw;\n@@ -3205,7 +3205,7 @@ err_setup_reset:\n * needs to be disabled. A global MAC reset is issued to stop the\n * hardware, and all transmit and receive resources are freed.\n **/\n-static int ixgbevf_close(struct net_device *netdev)\n+int ixgbevf_close(struct net_device *netdev)\n {\n \tstruct ixgbevf_adapter *adapter = netdev_priv(netdev);\n \n", "prefixes": [ "net-next", "V2", "3/6" ] }