Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/577762/?format=api
{ "id": 577762, "url": "http://patchwork.ozlabs.org/api/patches/577762/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1454487652-1545-2-git-send-email-sassmann@kpanic.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1454487652-1545-2-git-send-email-sassmann@kpanic.de>", "list_archive_url": null, "date": "2016-02-03T08:20:47", "name": "[net-next,V2,1/6] i40e: call ndo_stop() instead of dev_close() when running offline selftest", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8a652b3106e786e80cc1b1f4e91249601d174402", "submitter": { "id": 7508, "url": "http://patchwork.ozlabs.org/api/people/7508/?format=api", "name": "Stefan Assmann", "email": "sassmann@kpanic.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1454487652-1545-2-git-send-email-sassmann@kpanic.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/577762/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/577762/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 3C7F7140BEB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 3 Feb 2016 19:21:48 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 365E632D86;\n\tWed, 3 Feb 2016 08:21:48 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Uxv0SrljfL8z; Wed, 3 Feb 2016 08:21:46 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 730BF3308F;\n\tWed, 3 Feb 2016 08:21:46 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 08ECD1C07A5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Feb 2016 08:21:45 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 05004881A6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Feb 2016 08:21:45 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id u-cOhGq8DSCo for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Feb 2016 08:21:44 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 699B8884CD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Feb 2016 08:21:44 +0000 (UTC)", "from int-mx10.intmail.prod.int.phx2.redhat.com\n\t(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\tby mx1.redhat.com (Postfix) with ESMTPS id E92848E748;\n\tWed, 3 Feb 2016 08:21:43 +0000 (UTC)", "from w541.redhat.com (ovpn-116-36.ams2.redhat.com [10.36.116.36])\n\tby int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id u138LeHq022540; Wed, 3 Feb 2016 03:21:42 -0500" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Stefan Assmann <sassmann@kpanic.de>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 3 Feb 2016 09:20:47 +0100", "Message-Id": "<1454487652-1545-2-git-send-email-sassmann@kpanic.de>", "In-Reply-To": "<1454487652-1545-1-git-send-email-sassmann@kpanic.de>", "References": "<1454487652-1545-1-git-send-email-sassmann@kpanic.de>", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.23", "Cc": "netdev@vger.kernel.org, davem@davemloft.net, sassmann@kpanic.de", "Subject": "[Intel-wired-lan] [PATCH net-next V2 1/6] i40e: call ndo_stop()\n\tinstead of dev_close() when running offline selftest", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Calling dev_close() causes IFF_UP to be cleared which will remove the\ninterfaces routes and some addresses. That's probably not what the user\nintended when running the offline selftest. Besides this does not happen\nif the interface is brought down before the test, so the current\nbehaviour is inconsistent.\nInstead call the net_device_ops ndo_stop function directly and avoid\ntouching IFF_UP at all.\n\nSigned-off-by: Stefan Assmann <sassmann@kpanic.de>\n---\n drivers/net/ethernet/intel/i40e/i40e.h | 2 +-\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 ++--\n drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ----\n 3 files changed, 3 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex 68f2204..7e16c55 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -773,6 +773,7 @@ int i40e_vlan_rx_kill_vid(struct net_device *netdev,\n \t\t\t __always_unused __be16 proto, u16 vid);\n #endif\n int i40e_open(struct net_device *netdev);\n+int i40e_close(struct net_device *netdev);\n int i40e_vsi_open(struct i40e_vsi *vsi);\n void i40e_vlan_stripping_disable(struct i40e_vsi *vsi);\n int i40e_vsi_add_vlan(struct i40e_vsi *vsi, s16 vid);\n@@ -785,7 +786,6 @@ bool i40e_is_vsi_in_vlan(struct i40e_vsi *vsi);\n struct i40e_mac_filter *i40e_find_mac(struct i40e_vsi *vsi, u8 *macaddr,\n \t\t\t\t bool is_vf, bool is_netdev);\n #ifdef I40E_FCOE\n-int i40e_close(struct net_device *netdev);\n int i40e_setup_tc(struct net_device *netdev, u8 tc);\n void i40e_netpoll(struct net_device *netdev);\n int i40e_fcoe_enable(struct net_device *netdev);\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 29d5833..eeca530 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -1704,7 +1704,7 @@ static void i40e_diag_test(struct net_device *netdev,\n \t\t/* If the device is online then take it offline */\n \t\tif (if_running)\n \t\t\t/* indicate we're in test mode */\n-\t\t\tdev_close(netdev);\n+\t\t\ti40e_close(netdev);\n \t\telse\n \t\t\t/* This reset does not affect link - if it is\n \t\t\t * changed to a type of reset that does affect\n@@ -1733,7 +1733,7 @@ static void i40e_diag_test(struct net_device *netdev,\n \t\ti40e_do_reset(pf, BIT(__I40E_PF_RESET_REQUESTED));\n \n \t\tif (if_running)\n-\t\t\tdev_open(netdev);\n+\t\t\ti40e_open(netdev);\n \t} else {\n \t\t/* Online tests */\n \t\tnetif_info(pf, drv, netdev, \"online testing starting\\n\");\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 8f3b53e..39a1653 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -5459,11 +5459,7 @@ static void i40e_fdir_filter_exit(struct i40e_pf *pf)\n *\n * Returns 0, this is not allowed to fail\n **/\n-#ifdef I40E_FCOE\n int i40e_close(struct net_device *netdev)\n-#else\n-static int i40e_close(struct net_device *netdev)\n-#endif\n {\n \tstruct i40e_netdev_priv *np = netdev_priv(netdev);\n \tstruct i40e_vsi *vsi = np->vsi;\n", "prefixes": [ "net-next", "V2", "1/6" ] }