Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/575934/?format=api
{ "id": 575934, "url": "http://patchwork.ozlabs.org/api/patches/575934/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/56ABE3A8.4010602@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<56ABE3A8.4010602@gmail.com>", "list_archive_url": null, "date": "2016-01-29T22:11:52", "name": "[next] igb: allow setting MAC address on i211 using a device tree blob", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "f592bf6ef5b49d68ef64a576297f3932c17558cc", "submitter": { "id": 68213, "url": "http://patchwork.ozlabs.org/api/people/68213/?format=api", "name": "John Holland", "email": "jotihojr@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/56ABE3A8.4010602@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/575934/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/575934/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 55907140B99\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 30 Jan 2016 20:35:13 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4A6E391E53;\n\tSat, 30 Jan 2016 09:35:10 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OOSaXEVJzhJh; Sat, 30 Jan 2016 09:35:09 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 93F3991DE2;\n\tSat, 30 Jan 2016 09:35:09 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6F65D1C10D6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Jan 2016 22:11:56 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6A87C85262\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Jan 2016 22:11:56 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qfuawNpak3Ok for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Jan 2016 22:11:55 +0000 (UTC)", "from mail-wm0-f41.google.com (mail-wm0-f41.google.com\n\t[74.125.82.41])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 8DBC685259\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Jan 2016 22:11:55 +0000 (UTC)", "by mail-wm0-f41.google.com with SMTP id p63so86094389wmp.1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Jan 2016 14:11:55 -0800 (PST)", "from [10.0.2.46] (3qpe.de. [5.158.129.220])\n\tby smtp.googlemail.com with ESMTPSA id\n\tw8sm17503615wjx.21.2016.01.29.14.11.53\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tFri, 29 Jan 2016 14:11:53 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=mwWvP11n;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:subject:to:message-id:date:user-agent:mime-version\n\t:content-type:content-transfer-encoding;\n\tbh=ZkQmOM1tZX/rswNYAzrVx4btNlzK582D3RdUbmN1DJA=;\n\tb=mwWvP11n0P/AxIKOWuy3mEK/KnJKueVCG3Z2xO+1FnSRoGRY+rbMogoO4o0znrYyWT\n\tPvzVAaxtEyfs1rRz9nbCTWS/RWKX3nbENe6hSTDmye9CbXtdYH9R6dMYk572sm34BcTy\n\th4ciNlUz631X3NFVRoiZOk4zmOn4rC0wcHGg/OkvGkuy4cgGu3NjYdYrLJFUxyuzojOX\n\ttmdTVWqjdkcIMd3Mv3O4mvipbnFs6hYwr0NECOoQ3CS9L3Uwo6eZefIOpfaYCoPFdmWL\n\tJ2vOS5eHPO0uBqMTG3Tuo/evs5yA6fetIhH7O8fosmfAU4r5tdfMQ8cRvHZiz1osnZ9v\n\t6tVQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:subject:to:message-id:date:user-agent\n\t:mime-version:content-type:content-transfer-encoding;\n\tbh=ZkQmOM1tZX/rswNYAzrVx4btNlzK582D3RdUbmN1DJA=;\n\tb=bu2zy8lJcJoTOtfsGN2kHVszY9Xo4u9fLc8WaFCmklR11tZO5bAJsDxzhJlQixYZXa\n\tcPgLETOCAxy1VO8fhtwimH+YriT8QhFvIjxinRCC+aN6TXebCCeOtwzDz5/EYQ62PO6X\n\tXAxaDV8SILfs9NKkiER74nnuNJAtuit8nsw6jbMp4Dibd7W0FZFYt9TVPDS2QeSvh1IQ\n\t9PJFGcWqTWOCpfQnHueJ8erK/GNwcFf4iAcTHlAu6dOeN6C3dcA/kCTxOZEVFC6/AjEJ\n\ttWgo935XOb0U2vfpPvqBvkVUZT6F8ENiR074BUrLujlsSj3i9CQryefeK+/7L4We1QFY\n\tqmPA==", "X-Gm-Message-State": "AG10YOTh9nhQewCC82ayZCsYRrQOs5Gf+0VVpvl8B6fS4/F+wJ38eaKs1FAgF6bpYv3Kiw==", "X-Received": "by 10.28.7.72 with SMTP id 69mr11840439wmh.50.1454105514163;\n\tFri, 29 Jan 2016 14:11:54 -0800 (PST)", "From": "John Holland <jotihojr@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n\tjotihojr@gmail.com", "Message-ID": "<56ABE3A8.4010602@gmail.com>", "Date": "Fri, 29 Jan 2016 23:11:52 +0100", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101\n\tThunderbird/38.5.1", "MIME-Version": "1.0", "X-Mailman-Approved-At": "Sat, 30 Jan 2016 09:35:09 +0000", "Subject": "[Intel-wired-lan] [next] igb: allow setting MAC address on i211\n\tusing a device tree blob", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Transfer-Encoding": "7bit", "Content-Type": "text/plain; charset=\"us-ascii\"; Format=\"flowed\"", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The Intel i211 LOM pcie ethernet controllers' iNVM operates as an OTP \nand has no externel EEPROM interface [1]. The following allows the \ndriver to pickup the MAC address from a device tree blob when CONFIG_OF \nhas been enabled.\n\n[1] \nhttp://www.intel.com/content/www/us/en/embedded/products/networking/i211-ethernet-controller-datasheet.html\n\nSigned-off-by: John Holland <jotihojr@gmail.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 30 \n++++++++++++++++++++++++++++++\n 1 file changed, 30 insertions(+)\n\n if (!is_valid_ether_addr(netdev->dev_addr)) {", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c \nb/drivers/net/ethernet/intel/igb/igb_main.c\nindex 31e5f39..9c92443 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -56,6 +56,11 @@\n #include <linux/i2c.h>\n #include \"igb.h\"\n\n+#ifdef defined(CONFIG_OF)\n+#include <linux/of_net.h>\n+#include <linux/etherdevice.h>\n+#endif\n+\n #define MAJ 5\n #define MIN 3\n #define BUILD 0\n@@ -2217,6 +2222,26 @@ static s32 igb_init_i2c(struct igb_adapter *adapter)\n }\n\n /**\n+ * igb_read_mac_addr_dts - Read mac addres from the device tree blob.\n+ * @hw: pointer to the e1000 hardware structure\n+ **/\n+#ifdef defined(CONFIG_OF)\n+static void igb_read_mac_addr_dts(struct e1000_hw *hw)\n+{\n+ const u8 *mac;\n+ struct device_node *dn;\n+\n+ dn = of_find_compatible_node(NULL, NULL, \"intel,i211\");\n+ if (!dn)\n+ return;\n+\n+ mac = of_get_mac_address(dn);\n+ if (mac)\n+ ether_addr_copy(hw->mac.addr, mac);\n+}\n+#endif\n+\n+/**\n * igb_probe - Device Initialization Routine\n * @pdev: PCI device information struct\n * @ent: entry in igb_pci_tbl\n@@ -2420,6 +2445,11 @@ static int igb_probe(struct pci_dev *pdev, const \nstruct pci_device_id *ent)\n if (hw->mac.ops.read_mac_addr(hw))\n dev_err(&pdev->dev, \"NVM Read Error\\n\");\n\n+#ifdef defined(CONFIG_OF)\n+ if (!is_valid_ether_addr(hw->mac.addr))\n+ igb_read_mac_addr_dts(hw);\n+#endif\n+\n memcpy(netdev->dev_addr, hw->mac.addr, netdev->addr_len);\n\n", "prefixes": [ "next" ] }