Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/572950/?format=api
{ "id": 572950, "url": "http://patchwork.ozlabs.org/api/patches/572950/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1453677772-27075-1-git-send-email-jmaxwell37@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1453677772-27075-1-git-send-email-jmaxwell37@gmail.com>", "list_archive_url": null, "date": "2016-01-24T23:22:52", "name": "[net] igbvf: remove \"link is Up\" message when registering mcast address", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ec355f9b5ed613d9eb3ff0f8e632b67e2f570010", "submitter": { "id": 64029, "url": "http://patchwork.ozlabs.org/api/people/64029/?format=api", "name": "Jonathan Maxwell", "email": "jmaxwell37@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1453677772-27075-1-git-send-email-jmaxwell37@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/572950/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/572950/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 7D15514076B\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Jan 2016 09:42:58 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C12C29368F;\n\tMon, 25 Jan 2016 22:42:57 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Da+U3ZngMNaA; Mon, 25 Jan 2016 22:42:57 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 35F61930D8;\n\tMon, 25 Jan 2016 22:42:57 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 064541C172D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 24 Jan 2016 23:23:12 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id CB92425D35\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 24 Jan 2016 23:23:11 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gvCWHRJHMABy for <intel-wired-lan@lists.osuosl.org>;\n\tSun, 24 Jan 2016 23:23:10 +0000 (UTC)", "from mail-pf0-f169.google.com (mail-pf0-f169.google.com\n\t[209.85.192.169])\n\tby silver.osuosl.org (Postfix) with ESMTPS id D82D425FE4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 24 Jan 2016 23:23:10 +0000 (UTC)", "by mail-pf0-f169.google.com with SMTP id n128so71787871pfn.3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 24 Jan 2016 15:23:10 -0800 (PST)", "from dhcp-1-107.bne.redhat.com (110-175-8-199.static.tpgi.com.au.\n\t[110.175.8.199]) by smtp.gmail.com with ESMTPSA id\n\to75sm23813522pfi.17.2016.01.24.15.23.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 24 Jan 2016 15:23:09 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=tDWhcNcD;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:cc:subject:date:message-id;\n\tbh=4q6ng25SYPU3G536UP6r4BE0NSjEMke/Y1A5tcXSFrk=;\n\tb=tDWhcNcDIgbTkmMeiIMaGIBiO19sLGQbNyuAh+jZtl0osnT7f9IDQt51nMMr9Qgqua\n\tU8AZeEwKO93QfwlYat99bnNWMxu91pJ1BFedLL5b6k7WtoYMK8O1AwPM0zsZT9oaN2gJ\n\t0qaEgjePU/ALdPRcBw5/sQ0YW0G3zTBEjE9W/JB8O7+6N3Zuofn0XUk8GwSBSdoQzmmE\n\tzNKqEk+ArPmQQ2xm3Ozmq3k0dFBbR6RaGfupVNuZCA1GZK1VS9+VIh4ye1Wo+F9k4z8A\n\tN9I7+kR43zk6z5PBRl9UonFxf3Ab2rj80p5VQmKlcTFXL2VbgY7xdzAj/VHZYMx3BjQz\n\thKXQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=4q6ng25SYPU3G536UP6r4BE0NSjEMke/Y1A5tcXSFrk=;\n\tb=c1WPgS5ulq7ndjTUezbqCSd4QK7G+Jf5zbhOXZuJMkvPnhgl9XMLbzRafoLCJ71j6F\n\tXYvLntoGuu6Lq8J/Hx8yZurNK2RirA1UYKKHKDBsUUIXX03B4Nk2RZmN97+F0jr/hq4v\n\tEQVBK55a3Rdd5YxnPks+snpDEve/N7FOL728CQ106yU9MCxr9ki+n5DjY7/JHRtIJV5w\n\tOhDwdVGZOu8EH8R0IHx0TSiTeYNeX/Zh/7Cs3DxpX0CjFcfpwBDRmP12RvZfKOCvEE/S\n\togmGS3x59EeJ9qd2g5znaKLZtC8FT3hUpN6/71smi6eFHQKLVK++vH6q11rkPNaPa+Qg\n\t+XzQ==", "X-Gm-Message-State": "AG10YOTs/iEtad2WO8TvobWUo7r5McByrzFUhmeIjw9vgeopc+T4qM2rRNJpMh9iD7agPA==", "X-Received": "by 10.98.9.147 with SMTP id 19mr21655481pfj.163.1453677790587;\n\tSun, 24 Jan 2016 15:23:10 -0800 (PST)", "From": "Jon Maxwell <jmaxwell37@gmail.com>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Mon, 25 Jan 2016 10:22:52 +1100", "Message-Id": "<1453677772-27075-1-git-send-email-jmaxwell37@gmail.com>", "X-Mailer": "git-send-email 1.8.3.1", "X-Mailman-Approved-At": "Mon, 25 Jan 2016 22:42:56 +0000", "Cc": "vinschen@redhat.com, netdev@vger.kernel.org, jmaxwell@redhat.com,\n\tlinux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tJon Maxwell <jmaxwell37@gmail.com>, davem@davemloft.net", "Subject": "[Intel-wired-lan] [net] igbvf: remove \"link is Up\" message when\n\tregistering mcast address", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "A similar issue was addressed a few years ago in the following thread:\n\nhttp://www.spinics.net/lists/netdev/msg245877.html\n\nAt that time there were concerns that removing this statement may cause other\nside effects. However the submitter addressed those concerns. But the dialogue\nwent cold. We have a new case where a customers application is registering and \nun-registering multicast addresses every few seconds. This is leading to many \n\"Link is Up\" messages in the logs as a result of the \n\"netif_carrier_off(netdev)\" statement called by igbvf_msix_other(). Also on\nsome kernels it is interfering with the bonding driver causing it to failover \nand subsequently affecting connectivity.\n\nThe Sourgeforge driver does not make this call and is therefore not affected.\nIf there were any side effects I would expect that driver to also be affected.\nI have tested re-loading the igbvf driver and downing the adapter with the PF\nentity on the host where the VM has this patch. When I bring it back up again \nconnectivity is restored as expected. Therefore I request that this patch gets \nsubmitted. \n\nSigned-off-by: Jon Maxwell <jmaxwell37@gmail.com>\n---\n drivers/net/ethernet/intel/igbvf/netdev.c | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c\nindex 297af80..c2dfc22 100644\n--- a/drivers/net/ethernet/intel/igbvf/netdev.c\n+++ b/drivers/net/ethernet/intel/igbvf/netdev.c\n@@ -876,7 +876,6 @@ static irqreturn_t igbvf_msix_other(int irq, void *data)\n \n \tadapter->int_counter1++;\n \n-\tnetif_carrier_off(netdev);\n \thw->mac.get_link_status = 1;\n \tif (!test_bit(__IGBVF_DOWN, &adapter->state))\n \t\tmod_timer(&adapter->watchdog_timer, jiffies + 1);\n", "prefixes": [ "net" ] }