Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/572592/?format=api
{ "id": 572592, "url": "http://patchwork.ozlabs.org/api/patches/572592/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160125051722.12004.2954.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160125051722.12004.2954.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2016-01-25T05:17:22", "name": "[next,v3,10/15] i40e/i40evf: Clean-up Rx packet checksum handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "44d0aa7f7248b802d1eb4861b6c2d3152ccd1e34", "submitter": { "id": 67293, "url": "http://patchwork.ozlabs.org/api/people/67293/?format=api", "name": "Alexander Duyck", "email": "aduyck@mirantis.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160125051722.12004.2954.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/572592/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/572592/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 77BBB1402DD\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 25 Jan 2016 16:17:28 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6D9288C45E;\n\tMon, 25 Jan 2016 05:17:26 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PitDApSNJLEB; Mon, 25 Jan 2016 05:17:25 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 41CF08C435;\n\tMon, 25 Jan 2016 05:17:25 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 815121C107C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jan 2016 05:17:25 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7D05689E59\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jan 2016 05:17:25 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5LP902LTWAZE for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jan 2016 05:17:25 +0000 (UTC)", "from mail-pa0-f54.google.com (mail-pa0-f54.google.com\n\t[209.85.220.54])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id E6D5589E42\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jan 2016 05:17:24 +0000 (UTC)", "by mail-pa0-f54.google.com with SMTP id uo6so76350386pac.1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 24 Jan 2016 21:17:24 -0800 (PST)", "from localhost.localdomain\n\t(static-50-53-29-36.bvtn.or.frontiernet.net. [50.53.29.36])\n\tby smtp.gmail.com with ESMTPSA id\n\txr8sm24985277pab.26.2016.01.24.21.17.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 24 Jan 2016 21:17:24 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mirantis.com header.i=@mirantis.com\n\theader.b=js2D26wz; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com;\n\ts=google; \n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-type:content-transfer-encoding;\n\tbh=QFag+4IBT5rmFUqi3g2xQZa0k01XF2vFGK1dUBxnh1U=;\n\tb=js2D26wzB+Aa21nsv58hAP2WuuQDivZZO5uUjM93q2Br9JXfjydadOQxfEaKzrAzBg\n\tnyYAGaLvZpest+Rt7zwiAObZtIonFWEzFGLUnk1//rdlLbs7d01DSwbo3uPV0ON6o3Pt\n\tNbpGKsw0hnK+EgWiMZGhlDZYkr8KH2KhMMBvQ=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-type\n\t:content-transfer-encoding;\n\tbh=QFag+4IBT5rmFUqi3g2xQZa0k01XF2vFGK1dUBxnh1U=;\n\tb=IfXAbLqogOmbhgIl9V3Uz7713eszLIEI+qaq00tZP2Ipj9WTN6bC1vzMUXX5V4Vpcx\n\txYxjQWPhpaBWMGlKAwNwoerRO1RgotZ50Vd6iEZ7ZEmdYzzVOBQ+6kd9Fh1b3Rkrf4js\n\tPqrde1VAh1eORzpu9hPtbC1QPgXYD6Zc70sLIEz2uxI9Ce/AI4x2tb2Zp3PYYU2EaJlw\n\t+RLO5+88IyJ/zCxvGyY4Tm2J3zjsD7jhUlNb6ZpNq0fwCWAEHgR3TTjS3g67o+URYDRh\n\tEdU92ASxJuguMT+cKWARvU+0RrtLW6L52vbkG3KOUgrTczaiAsbrY5K++2cfmtLw/qf8\n\tb0Dg==", "X-Gm-Message-State": "AG10YOQBsEXL9xjRKZEkHbjhSBR84+H70rBCZ+ap/5UQlGYjqwcAcEuYC4S2N38L2oHfiLUY", "X-Received": "by 10.66.235.36 with SMTP id uj4mr23499603pac.85.1453699044642; \n\tSun, 24 Jan 2016 21:17:24 -0800 (PST)", "From": "Alexander Duyck <aduyck@mirantis.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Sun, 24 Jan 2016 21:17:22 -0800", "Message-ID": "<20160125051722.12004.2954.stgit@localhost.localdomain>", "In-Reply-To": "<20160125050602.12004.38884.stgit@localhost.localdomain>", "References": "<20160125050602.12004.38884.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH v3 10/15] i40e/i40evf: Clean-up Rx\n\tpacket checksum handling", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "This is mostly a minor clean-up for the Rx checksum path in order to avoid\nsome of the unnecessary conditional checks that were being applied.\n\nSigned-off-by: Alexander Duyck <aduyck@mirantis.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 23 ++++++++++-------------\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 23 ++++++++++-------------\n 2 files changed, 20 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex 094e0153c7c6..890d2f580434 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -1389,13 +1389,7 @@ static inline void i40e_rx_checksum(struct i40e_vsi *vsi,\n \t\t\t\t u16 rx_ptype)\n {\n \tstruct i40e_rx_ptype_decoded decoded = decode_rx_desc_ptype(rx_ptype);\n-\tbool ipv4 = false, ipv6 = false;\n-\tbool ipv4_tunnel, ipv6_tunnel;\n-\n-\tipv4_tunnel = (rx_ptype >= I40E_RX_PTYPE_GRENAT4_MAC_PAY3) &&\n-\t\t (rx_ptype <= I40E_RX_PTYPE_GRENAT4_MACVLAN_IPV6_ICMP_PAY4);\n-\tipv6_tunnel = (rx_ptype >= I40E_RX_PTYPE_GRENAT6_MAC_PAY3) &&\n-\t\t (rx_ptype <= I40E_RX_PTYPE_GRENAT6_MACVLAN_IPV6_ICMP_PAY4);\n+\tbool ipv4, ipv6, ipv4_tunnel, ipv6_tunnel;\n \n \tskb->ip_summed = CHECKSUM_NONE;\n \n@@ -1411,12 +1405,10 @@ static inline void i40e_rx_checksum(struct i40e_vsi *vsi,\n \tif (!(decoded.known && decoded.outer_ip))\n \t\treturn;\n \n-\tif (decoded.outer_ip == I40E_RX_PTYPE_OUTER_IP &&\n-\t decoded.outer_ip_ver == I40E_RX_PTYPE_OUTER_IPV4)\n-\t\tipv4 = true;\n-\telse if (decoded.outer_ip == I40E_RX_PTYPE_OUTER_IP &&\n-\t\t decoded.outer_ip_ver == I40E_RX_PTYPE_OUTER_IPV6)\n-\t\tipv6 = true;\n+\tipv4 = (decoded.outer_ip == I40E_RX_PTYPE_OUTER_IP) &&\n+\t (decoded.outer_ip_ver == I40E_RX_PTYPE_OUTER_IPV4);\n+\tipv6 = (decoded.outer_ip == I40E_RX_PTYPE_OUTER_IP) &&\n+\t (decoded.outer_ip_ver == I40E_RX_PTYPE_OUTER_IPV6);\n \n \tif (ipv4 &&\n \t (rx_error & (BIT(I40E_RX_DESC_ERROR_IPE_SHIFT) |\n@@ -1447,6 +1439,11 @@ static inline void i40e_rx_checksum(struct i40e_vsi *vsi,\n \t * inner checksum report CHECKSUM_UNNECESSARY.\n \t */\n \n+\tipv4_tunnel = (rx_ptype >= I40E_RX_PTYPE_GRENAT4_MAC_PAY3) &&\n+\t\t (rx_ptype <= I40E_RX_PTYPE_GRENAT4_MACVLAN_IPV6_ICMP_PAY4);\n+\tipv6_tunnel = (rx_ptype >= I40E_RX_PTYPE_GRENAT6_MAC_PAY3) &&\n+\t\t (rx_ptype <= I40E_RX_PTYPE_GRENAT6_MACVLAN_IPV6_ICMP_PAY4);\n+\n \tskb->ip_summed = CHECKSUM_UNNECESSARY;\n \tskb->csum_level = ipv4_tunnel || ipv6_tunnel;\n \ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex b8d7c7a29070..126b748c0ff1 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -861,13 +861,7 @@ static inline void i40e_rx_checksum(struct i40e_vsi *vsi,\n \t\t\t\t u16 rx_ptype)\n {\n \tstruct i40e_rx_ptype_decoded decoded = decode_rx_desc_ptype(rx_ptype);\n-\tbool ipv4 = false, ipv6 = false;\n-\tbool ipv4_tunnel, ipv6_tunnel;\n-\n-\tipv4_tunnel = (rx_ptype >= I40E_RX_PTYPE_GRENAT4_MAC_PAY3) &&\n-\t\t (rx_ptype <= I40E_RX_PTYPE_GRENAT4_MACVLAN_IPV6_ICMP_PAY4);\n-\tipv6_tunnel = (rx_ptype >= I40E_RX_PTYPE_GRENAT6_MAC_PAY3) &&\n-\t\t (rx_ptype <= I40E_RX_PTYPE_GRENAT6_MACVLAN_IPV6_ICMP_PAY4);\n+\tbool ipv4, ipv6, ipv4_tunnel, ipv6_tunnel;\n \n \tskb->ip_summed = CHECKSUM_NONE;\n \n@@ -883,12 +877,10 @@ static inline void i40e_rx_checksum(struct i40e_vsi *vsi,\n \tif (!(decoded.known && decoded.outer_ip))\n \t\treturn;\n \n-\tif (decoded.outer_ip == I40E_RX_PTYPE_OUTER_IP &&\n-\t decoded.outer_ip_ver == I40E_RX_PTYPE_OUTER_IPV4)\n-\t\tipv4 = true;\n-\telse if (decoded.outer_ip == I40E_RX_PTYPE_OUTER_IP &&\n-\t\t decoded.outer_ip_ver == I40E_RX_PTYPE_OUTER_IPV6)\n-\t\tipv6 = true;\n+\tipv4 = (decoded.outer_ip == I40E_RX_PTYPE_OUTER_IP) &&\n+\t (decoded.outer_ip_ver == I40E_RX_PTYPE_OUTER_IPV4);\n+\tipv6 = (decoded.outer_ip == I40E_RX_PTYPE_OUTER_IP) &&\n+\t (decoded.outer_ip_ver == I40E_RX_PTYPE_OUTER_IPV6);\n \n \tif (ipv4 &&\n \t (rx_error & (BIT(I40E_RX_DESC_ERROR_IPE_SHIFT) |\n@@ -919,6 +911,11 @@ static inline void i40e_rx_checksum(struct i40e_vsi *vsi,\n \t * inner checksum report CHECKSUM_UNNECESSARY.\n \t */\n \n+\tipv4_tunnel = (rx_ptype >= I40E_RX_PTYPE_GRENAT4_MAC_PAY3) &&\n+\t\t (rx_ptype <= I40E_RX_PTYPE_GRENAT4_MACVLAN_IPV6_ICMP_PAY4);\n+\tipv6_tunnel = (rx_ptype >= I40E_RX_PTYPE_GRENAT6_MAC_PAY3) &&\n+\t\t (rx_ptype <= I40E_RX_PTYPE_GRENAT6_MACVLAN_IPV6_ICMP_PAY4);\n+\n \tskb->ip_summed = CHECKSUM_UNNECESSARY;\n \tskb->csum_level = ipv4_tunnel || ipv6_tunnel;\n \n", "prefixes": [ "next", "v3", "10/15" ] }