Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/572582/?format=api
{ "id": 572582, "url": "http://patchwork.ozlabs.org/api/patches/572582/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160125051620.12004.2775.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160125051620.12004.2775.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2016-01-25T05:16:20", "name": "[next,v3,02/15] i40e/i40evf: Use u64 values instead of casting them in TSO function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "04d3fa5408596fb914ead7e0b2b521d74645e067", "submitter": { "id": 67293, "url": "http://patchwork.ozlabs.org/api/people/67293/?format=api", "name": "Alexander Duyck", "email": "aduyck@mirantis.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160125051620.12004.2775.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/572582/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/572582/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 254FD1402BF\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 25 Jan 2016 16:16:27 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 198B68C3E7;\n\tMon, 25 Jan 2016 05:16:25 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xsU-JFD8IWXD; Mon, 25 Jan 2016 05:16:24 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 613D18C363;\n\tMon, 25 Jan 2016 05:16:24 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4C3CA1C107C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jan 2016 05:16:25 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 46FF093055\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jan 2016 05:16:25 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id cpBq9fJKBU9J for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jan 2016 05:16:23 +0000 (UTC)", "from mail-pa0-f48.google.com (mail-pa0-f48.google.com\n\t[209.85.220.48])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id C5C7592CA3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jan 2016 05:16:23 +0000 (UTC)", "by mail-pa0-f48.google.com with SMTP id cy9so74892176pac.0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 24 Jan 2016 21:16:23 -0800 (PST)", "from localhost.localdomain\n\t(static-50-53-29-36.bvtn.or.frontiernet.net. [50.53.29.36])\n\tby smtp.gmail.com with ESMTPSA id\n\tr15sm24961611pfr.59.2016.01.24.21.16.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 24 Jan 2016 21:16:22 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mirantis.com header.i=@mirantis.com\n\theader.b=U9SMxDmr; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com;\n\ts=google; \n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-type:content-transfer-encoding;\n\tbh=QPLyLlSfk/DkiS1wjcKSirAVfzg1APxiYD/IyluL6gM=;\n\tb=U9SMxDmrJTPkqhpSEq5nVmz2dMcWVGGCr+opZTUgDcO2+/zv7ZW2T/RsDbe9rcU3Ug\n\tGP7gAYtvwzrubszDBJoe8wTblwrSUoCWlWp2ENbT2MjzJq/NEJGnQGjRcO9UIktuIC8E\n\t+SeeSLI1ZXPejWJ58Mc0+XYNamAaH5aMCBLvM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-type\n\t:content-transfer-encoding;\n\tbh=QPLyLlSfk/DkiS1wjcKSirAVfzg1APxiYD/IyluL6gM=;\n\tb=igvwC11K5Ga5MknxSpk9iZ21YrM0/bbhvN1tB32za9C+QLhHrDoVc1dLPwbiJddlV3\n\tbYiwCmGO3JCrKagSIQYhChUZHnO3qDEhNIO6DYXzKzbMYrCNs+/sCW4twHgibKUWqBZz\n\tFsxPZPuCpqFauyBJglIXgYeNKt0/pkITf/Gb/O4E3+q0aUr4mvI77Ropb1e42mhZL4mO\n\tWzxcVRBOOrtG/TWQsYDhNeAiRzxuv+rXhoJm8as4JqRyH7eHLosbIsJEqo1LYukcFPTl\n\tYMe93EZ9qtTufmiNwxhnHuPhaI5LFj9SaQ2DXl1+mhsm5uszL04HPdxSJ4nK+qPPVVyv\n\tmQHg==", "X-Gm-Message-State": "AG10YOTdSv4BGtECw11XD4Igs5fbytwjGe3D28l+J6scIHk66cacwQllCDaROfDaswvA/pqW", "X-Received": "by 10.66.255.97 with SMTP id ap1mr23075439pad.135.1453698983452; \n\tSun, 24 Jan 2016 21:16:23 -0800 (PST)", "From": "Alexander Duyck <aduyck@mirantis.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Sun, 24 Jan 2016 21:16:20 -0800", "Message-ID": "<20160125051620.12004.2775.stgit@localhost.localdomain>", "In-Reply-To": "<20160125050602.12004.38884.stgit@localhost.localdomain>", "References": "<20160125050602.12004.38884.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH v3 02/15] i40e/i40evf: Use u64 values\n\tinstead of casting them in TSO function", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Instead of casing u32 values to u64 it makes more sense to just start out\nwith u64 values in the first place. This way we don't need to create a\nmess with all of the casts needed to populate a 64b value.\n\nSigned-off-by: Alexander Duyck <aduyck@mirantis.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 9 ++++-----\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 9 ++++-----\n 2 files changed, 8 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex c92198e7f5bc..d201bedaca27 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -2267,7 +2267,7 @@ out:\n static int i40e_tso(struct i40e_ring *tx_ring, struct sk_buff *skb,\n \t\t u8 *hdr_len, u64 *cd_type_cmd_tso_mss)\n {\n-\tu32 cd_cmd, cd_tso_len, cd_mss;\n+\tu64 cd_cmd, cd_tso_len, cd_mss;\n \tstruct ipv6hdr *ipv6h;\n \tstruct tcphdr *tcph;\n \tstruct iphdr *iph;\n@@ -2309,10 +2309,9 @@ static int i40e_tso(struct i40e_ring *tx_ring, struct sk_buff *skb,\n \tcd_cmd = I40E_TX_CTX_DESC_TSO;\n \tcd_tso_len = skb->len - *hdr_len;\n \tcd_mss = skb_shinfo(skb)->gso_size;\n-\t*cd_type_cmd_tso_mss |= ((u64)cd_cmd << I40E_TXD_CTX_QW1_CMD_SHIFT) |\n-\t\t\t\t((u64)cd_tso_len <<\n-\t\t\t\t I40E_TXD_CTX_QW1_TSO_LEN_SHIFT) |\n-\t\t\t\t((u64)cd_mss << I40E_TXD_CTX_QW1_MSS_SHIFT);\n+\t*cd_type_cmd_tso_mss |= (cd_cmd << I40E_TXD_CTX_QW1_CMD_SHIFT) |\n+\t\t\t\t(cd_tso_len << I40E_TXD_CTX_QW1_TSO_LEN_SHIFT) |\n+\t\t\t\t(cd_mss << I40E_TXD_CTX_QW1_MSS_SHIFT);\n \treturn 1;\n }\n \ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex f7ac254b79f0..07d6b5d5a2ae 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -1527,7 +1527,7 @@ out:\n static int i40e_tso(struct i40e_ring *tx_ring, struct sk_buff *skb,\n \t\t u8 *hdr_len, u64 *cd_type_cmd_tso_mss)\n {\n-\tu32 cd_cmd, cd_tso_len, cd_mss;\n+\tu64 cd_cmd, cd_tso_len, cd_mss;\n \tstruct ipv6hdr *ipv6h;\n \tstruct tcphdr *tcph;\n \tstruct iphdr *iph;\n@@ -1569,10 +1569,9 @@ static int i40e_tso(struct i40e_ring *tx_ring, struct sk_buff *skb,\n \tcd_cmd = I40E_TX_CTX_DESC_TSO;\n \tcd_tso_len = skb->len - *hdr_len;\n \tcd_mss = skb_shinfo(skb)->gso_size;\n-\t*cd_type_cmd_tso_mss |= ((u64)cd_cmd << I40E_TXD_CTX_QW1_CMD_SHIFT) |\n-\t\t\t\t((u64)cd_tso_len <<\n-\t\t\t\t I40E_TXD_CTX_QW1_TSO_LEN_SHIFT) |\n-\t\t\t\t((u64)cd_mss << I40E_TXD_CTX_QW1_MSS_SHIFT);\n+\t*cd_type_cmd_tso_mss |= (cd_cmd << I40E_TXD_CTX_QW1_CMD_SHIFT) |\n+\t\t\t\t(cd_tso_len << I40E_TXD_CTX_QW1_TSO_LEN_SHIFT) |\n+\t\t\t\t(cd_mss << I40E_TXD_CTX_QW1_MSS_SHIFT);\n \treturn 1;\n }\n \n", "prefixes": [ "next", "v3", "02/15" ] }