Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/568505/?format=api
{ "id": 568505, "url": "http://patchwork.ozlabs.org/api/patches/568505/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1452897202-15204-8-git-send-email-joshua.a.hay@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1452897202-15204-8-git-send-email-joshua.a.hay@intel.com>", "list_archive_url": null, "date": "2016-01-15T22:33:14", "name": "[next,S28,07/15] i40e: Removal of code which relies on BASE VEB SEID", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "987eedd38b6e7f3d9ea8fdf2c5c56a28f0e2a278", "submitter": { "id": 19461, "url": "http://patchwork.ozlabs.org/api/people/19461/?format=api", "name": "Joshua Hay", "email": "joshua.a.hay@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1452897202-15204-8-git-send-email-joshua.a.hay@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/568505/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/568505/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id C54C4140BA4\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 16 Jan 2016 09:33:30 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 14BC991A00;\n\tFri, 15 Jan 2016 22:33:29 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id vDV+kbag20Rw; Fri, 15 Jan 2016 22:33:27 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 778D291A4D;\n\tFri, 15 Jan 2016 22:33:25 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id E51C61C2189\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Jan 2016 22:33:24 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E03358B14E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Jan 2016 22:33:24 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Rv8jQCFcsPcI for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Jan 2016 22:33:24 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DBB588B1EC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Jan 2016 22:33:23 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga103.fm.intel.com with ESMTP; 15 Jan 2016 14:33:23 -0800", "from jahay1-mobl2.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([134.134.176.81])\n\tby fmsmga002.fm.intel.com with ESMTP; 15 Jan 2016 14:33:22 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.22,302,1449561600\"; d=\"scan'208\";a=\"894132182\"", "From": "Joshua Hay <joshua.a.hay@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 15 Jan 2016 14:33:14 -0800", "Message-Id": "<1452897202-15204-8-git-send-email-joshua.a.hay@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1452897202-15204-1-git-send-email-joshua.a.hay@intel.com>", "References": "<1452897202-15204-1-git-send-email-joshua.a.hay@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S28 07/15] i40e: Removal of code\n\twhich relies on BASE VEB SEID", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Kiran Patil <kiran.patil@intel.com>\n\nFixed mapping of SEID is removed from specification. Hence\nthis patch removes code which was using hardcoded base VEB SEID.\n\nChanged FCoE code to use \"hw->pf_id\" to obtain correct \"idx\"\nand verified.\n\nRemoved defines for BASE VSI/VEB SEID and BASE_PF_SEID since it\nis not used anymore.\n\nSigned-off-by: Kiran Patil <kiran.patil@intel.com>\nChange-ID: Id507cf4b1fae1c0145e3f08ae9ea5846ea5840de\n---\nTesting Hints:\n\tPlease test using debugfs hook for \"dump veb <seid>\".\n\t\techo \"dump veb [seid]\" > command\n\tHere \"seid\" is VEB seid and it is optional argument. If \"seid\"\n\tis not specified, it dumps all VEBs.\n\n\tAfter this patch, user shall see output in dmesg. Without this patch,\n\tif SEID is not in range, user will see error like\n\t\t\"<seid>: bad seid\"\n\n drivers/net/ethernet/intel/i40e/i40e.h | 3 ---\n drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 16 +++-------------\n drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-\n 3 files changed, 4 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex e37af29..ceb72d8 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -64,9 +64,6 @@\n #include \"i40e_dcb.h\"\n \n /* Useful i40e defaults */\n-#define I40E_BASE_PF_SEID 16\n-#define I40E_BASE_VSI_SEID 512\n-#define I40E_BASE_VEB_SEID 288\n #define I40E_MAX_VEB 16\n \n #define I40E_MAX_NUM_DESCRIPTORS 4096\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\nindex 631c2d6..2a44f2e 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n@@ -61,13 +61,9 @@ static struct i40e_veb *i40e_dbg_find_veb(struct i40e_pf *pf, int seid)\n {\n \tint i;\n \n-\tif ((seid < I40E_BASE_VEB_SEID) ||\n-\t (seid > (I40E_BASE_VEB_SEID + I40E_MAX_VEB)))\n-\t\tdev_info(&pf->pdev->dev, \"%d: bad seid\\n\", seid);\n-\telse\n-\t\tfor (i = 0; i < I40E_MAX_VEB; i++)\n-\t\t\tif (pf->veb[i] && pf->veb[i]->seid == seid)\n-\t\t\t\treturn pf->veb[i];\n+\tfor (i = 0; i < I40E_MAX_VEB; i++)\n+\t\tif (pf->veb[i] && pf->veb[i]->seid == seid)\n+\t\t\treturn pf->veb[i];\n \treturn NULL;\n }\n \n@@ -691,12 +687,6 @@ static void i40e_dbg_dump_veb_seid(struct i40e_pf *pf, int seid)\n {\n \tstruct i40e_veb *veb;\n \n-\tif ((seid < I40E_BASE_VEB_SEID) ||\n-\t (seid >= (I40E_MAX_VEB + I40E_BASE_VEB_SEID))) {\n-\t\tdev_info(&pf->pdev->dev, \"%d: bad seid\\n\", seid);\n-\t\treturn;\n-\t}\n-\n \tveb = i40e_dbg_find_veb(pf, seid);\n \tif (!veb) {\n \t\tdev_info(&pf->pdev->dev, \"can't find veb %d\\n\", seid);\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 4f4262e..90e37f4 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -768,7 +768,7 @@ static void i40e_update_fcoe_stats(struct i40e_vsi *vsi)\n \tif (vsi->type != I40E_VSI_FCOE)\n \t\treturn;\n \n-\tidx = (pf->pf_seid - I40E_BASE_PF_SEID) + I40E_FCOE_PF_STAT_OFFSET;\n+\tidx = hw->pf_id + I40E_FCOE_PF_STAT_OFFSET;\n \tfs = &vsi->fcoe_stats;\n \tofs = &vsi->fcoe_stats_offsets;\n \n", "prefixes": [ "next", "S28", "07/15" ] }