Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/567216/?format=api
{ "id": 567216, "url": "http://patchwork.ozlabs.org/api/patches/567216/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1452732712-12248-6-git-send-email-joshua.a.hay@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1452732712-12248-6-git-send-email-joshua.a.hay@intel.com>", "list_archive_url": null, "date": "2016-01-14T00:51:42", "name": "[v2,next,S27,05/15] i40e: use new add_veb calling with veb stats control", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "baec73e3b0297b7bd65f33dee21f362b33a7844c", "submitter": { "id": 19461, "url": "http://patchwork.ozlabs.org/api/people/19461/?format=api", "name": "Joshua Hay", "email": "joshua.a.hay@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1452732712-12248-6-git-send-email-joshua.a.hay@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/567216/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/567216/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 9C3EF140662\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Jan 2016 11:52:04 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C5184A5947;\n\tThu, 14 Jan 2016 00:52:03 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AHmDTdQ1Utx9; Thu, 14 Jan 2016 00:52:02 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 457FBA5938;\n\tThu, 14 Jan 2016 00:52:01 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 52B7D1C0F4A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jan 2016 00:51:55 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4CDB48A7BC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jan 2016 00:51:55 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tawMfzl9F-sv for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jan 2016 00:51:53 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 24EB98B3A3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jan 2016 00:51:53 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 13 Jan 2016 16:51:52 -0800", "from jahay1-mobl2.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([134.134.176.160])\n\tby orsmga002.jf.intel.com with ESMTP; 13 Jan 2016 16:51:52 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.22,291,1449561600\"; d=\"scan'208\";a=\"890056920\"", "From": "Joshua Hay <joshua.a.hay@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 13 Jan 2016 16:51:42 -0800", "Message-Id": "<1452732712-12248-6-git-send-email-joshua.a.hay@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1452732712-12248-1-git-send-email-joshua.a.hay@intel.com>", "References": "<1452732712-12248-1-git-send-email-joshua.a.hay@intel.com>", "Subject": "[Intel-wired-lan] [v2 next PATCH S27 05/15] i40e: use new add_veb\n\tcalling with veb stats control", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Shannon Nelson <shannon.nelson@intel.com>\n\nThe new parameters for add_veb allow us to enable and disable VEB stats,\nso let's use them.\n\nUpdate copyright year.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@intel.com>\nChange-ID: Ie6e68c68e2d1d459e42168eda661051b56bf0a65\n---\nTesting Hints: These commands should now do something useful:\n\tethtool --set-priv-flags eth0 veb-stats on\n\tethtool --set-priv-flags eth0 veb-stats off\n\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 11 ++++++++---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--\n 2 files changed, 10 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex f49f224..40a52b8 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -1,7 +1,7 @@\n /*******************************************************************************\n *\n * Intel Ethernet Controller XL710 Family Linux Driver\n- * Copyright(c) 2013 - 2015 Intel Corporation.\n+ * Copyright(c) 2013 - 2016 Intel Corporation.\n *\n * This program is free software; you can redistribute it and/or modify it\n * under the terms and conditions of the GNU General Public License,\n@@ -2785,10 +2785,15 @@ static int i40e_set_priv_flags(struct net_device *dev, u32 flags)\n \t\tpf->auto_disable_flags |= I40E_FLAG_FD_ATR_ENABLED;\n \t}\n \n-\tif (flags & I40E_PRIV_FLAGS_VEB_STATS)\n+\tif ((flags & I40E_PRIV_FLAGS_VEB_STATS) &&\n+\t !(pf->flags & I40E_FLAG_VEB_STATS_ENABLED)) {\n \t\tpf->flags |= I40E_FLAG_VEB_STATS_ENABLED;\n-\telse\n+\t\treset_required = true;\n+\t} else if (!(flags & I40E_PRIV_FLAGS_VEB_STATS) &&\n+\t\t (pf->flags & I40E_FLAG_VEB_STATS_ENABLED)) {\n \t\tpf->flags &= ~I40E_FLAG_VEB_STATS_ENABLED;\n+\t\treset_required = true;\n+\t}\n \n \tif ((flags & I40E_PRIV_FLAGS_HW_ATR_EVICT) &&\n \t\t\t\t (pf->flags & I40E_FLAG_HW_ATR_EVICT_CAPABLE))\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex ce8651a..1c03ff6 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -10067,13 +10067,13 @@ static int i40e_add_veb(struct i40e_veb *veb, struct i40e_vsi *vsi)\n {\n \tstruct i40e_pf *pf = veb->pf;\n \tbool is_default = veb->pf->cur_promisc;\n-\tbool is_cloud = false;\n+\tbool enable_stats = !!(pf->flags & I40E_FLAG_VEB_STATS_ENABLED);\n \tint ret;\n \n \t/* get a VEB from the hardware */\n \tret = i40e_aq_add_veb(&pf->hw, veb->uplink_seid, vsi->seid,\n \t\t\t veb->enabled_tc, is_default,\n-\t\t\t &veb->seid, is_cloud, NULL);\n+\t\t\t &veb->seid, enable_stats, NULL);\n \tif (ret) {\n \t\tdev_info(&pf->pdev->dev,\n \t\t\t \"couldn't add VEB, err %s aq_err %s\\n\",\n", "prefixes": [ "v2", "next", "S27", "05/15" ] }