Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/567213/?format=api
{ "id": 567213, "url": "http://patchwork.ozlabs.org/api/patches/567213/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1452732712-12248-12-git-send-email-joshua.a.hay@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1452732712-12248-12-git-send-email-joshua.a.hay@intel.com>", "list_archive_url": null, "date": "2016-01-14T00:51:48", "name": "[v2,next,S27,11/15] i40e/i40evf: use __GFP_NOWARN", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9429c2884cbd2dd99f3aa17305440f50078d46cd", "submitter": { "id": 19461, "url": "http://patchwork.ozlabs.org/api/people/19461/?format=api", "name": "Joshua Hay", "email": "joshua.a.hay@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1452732712-12248-12-git-send-email-joshua.a.hay@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/567213/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/567213/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 226D5140187\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Jan 2016 11:52:03 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6EED4A596E;\n\tThu, 14 Jan 2016 00:52:02 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id v_QGp--cm22c; Thu, 14 Jan 2016 00:52:00 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9EF7DA592C;\n\tThu, 14 Jan 2016 00:52:00 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6CEB21C0F4A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jan 2016 00:51:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 690438A7BC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jan 2016 00:51:54 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xm6UmyYYysZb for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jan 2016 00:51:54 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 86CD18AEB9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jan 2016 00:51:53 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 13 Jan 2016 16:51:52 -0800", "from jahay1-mobl2.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([134.134.176.160])\n\tby orsmga002.jf.intel.com with ESMTP; 13 Jan 2016 16:51:52 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.22,291,1449561600\"; d=\"scan'208\";a=\"890056926\"", "From": "Joshua Hay <joshua.a.hay@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 13 Jan 2016 16:51:48 -0800", "Message-Id": "<1452732712-12248-12-git-send-email-joshua.a.hay@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1452732712-12248-1-git-send-email-joshua.a.hay@intel.com>", "References": "<1452732712-12248-1-git-send-email-joshua.a.hay@intel.com>", "Subject": "[Intel-wired-lan] [v2 next PATCH S27 11/15] i40e/i40evf: use\n\t__GFP_NOWARN", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nThe i40e and i40evf drivers now cleanly handle allocation\nfailures and can avoid kernel log spew from the memory allocator\nwhen allocations fail, so set __GFP_NOWARN on rx buffer alloc.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nChange-ID: Ic9e1b83c495e2a3ef6b069ba7fb6e52ce134cd23\n---\nTesting Hints: compile everywhere\n\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 12 ++++++++----\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 12 ++++++++----\n 2 files changed, 16 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex 692e723..9efd988 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -1292,8 +1292,10 @@ bool i40e_alloc_rx_buffers_1buf(struct i40e_ring *rx_ring, u16 cleaned_count)\n \t\tskb = bi->skb;\n \n \t\tif (!skb) {\n-\t\t\tskb = netdev_alloc_skb_ip_align(rx_ring->netdev,\n-\t\t\t\t\t\t\trx_ring->rx_buf_len);\n+\t\t\tskb = __netdev_alloc_skb_ip_align(rx_ring->netdev,\n+\t\t\t\t\t\t\t rx_ring->rx_buf_len,\n+\t\t\t\t\t\t\t GFP_ATOMIC |\n+\t\t\t\t\t\t\t __GFP_NOWARN);\n \t\t\tif (!skb) {\n \t\t\t\trx_ring->rx_stats.alloc_buff_failed++;\n \t\t\t\tgoto no_buffers;\n@@ -1571,8 +1573,10 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, const int budget)\n \t\trx_bi = &rx_ring->rx_bi[i];\n \t\tskb = rx_bi->skb;\n \t\tif (likely(!skb)) {\n-\t\t\tskb = netdev_alloc_skb_ip_align(rx_ring->netdev,\n-\t\t\t\t\t\t\trx_ring->rx_hdr_len);\n+\t\t\tskb = __netdev_alloc_skb_ip_align(rx_ring->netdev,\n+\t\t\t\t\t\t\t rx_ring->rx_hdr_len,\n+\t\t\t\t\t\t\t GFP_ATOMIC |\n+\t\t\t\t\t\t\t __GFP_NOWARN);\n \t\t\tif (!skb) {\n \t\t\t\trx_ring->rx_stats.alloc_buff_failed++;\n \t\t\t\tfailure = true;\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex 0f9442e..d3ec3b2 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -764,8 +764,10 @@ bool i40evf_alloc_rx_buffers_1buf(struct i40e_ring *rx_ring, u16 cleaned_count)\n \t\tskb = bi->skb;\n \n \t\tif (!skb) {\n-\t\t\tskb = netdev_alloc_skb_ip_align(rx_ring->netdev,\n-\t\t\t\t\t\t\trx_ring->rx_buf_len);\n+\t\t\tskb = __netdev_alloc_skb_ip_align(rx_ring->netdev,\n+\t\t\t\t\t\t\t rx_ring->rx_buf_len,\n+\t\t\t\t\t\t\t GFP_ATOMIC |\n+\t\t\t\t\t\t\t __GFP_NOWARN);\n \t\t\tif (!skb) {\n \t\t\t\trx_ring->rx_stats.alloc_buff_failed++;\n \t\t\t\tgoto no_buffers;\n@@ -1034,8 +1036,10 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, const int budget)\n \t\trx_bi = &rx_ring->rx_bi[i];\n \t\tskb = rx_bi->skb;\n \t\tif (likely(!skb)) {\n-\t\t\tskb = netdev_alloc_skb_ip_align(rx_ring->netdev,\n-\t\t\t\t\t\t\trx_ring->rx_hdr_len);\n+\t\t\tskb = __netdev_alloc_skb_ip_align(rx_ring->netdev,\n+\t\t\t\t\t\t\t rx_ring->rx_hdr_len,\n+\t\t\t\t\t\t\t GFP_ATOMIC |\n+\t\t\t\t\t\t\t __GFP_NOWARN);\n \t\t\tif (!skb) {\n \t\t\t\trx_ring->rx_stats.alloc_buff_failed++;\n \t\t\t\tfailure = true;\n", "prefixes": [ "v2", "next", "S27", "11/15" ] }