Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/567209/?format=api
{ "id": 567209, "url": "http://patchwork.ozlabs.org/api/patches/567209/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1452732712-12248-5-git-send-email-joshua.a.hay@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1452732712-12248-5-git-send-email-joshua.a.hay@intel.com>", "list_archive_url": null, "date": "2016-01-14T00:51:41", "name": "[v2,next,S27,04/15] i40e: add VEB stat control and remove L2 cloud filter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5745ba9146c88b63d527ab4fece6803715e99d97", "submitter": { "id": 19461, "url": "http://patchwork.ozlabs.org/api/people/19461/?format=api", "name": "Joshua Hay", "email": "joshua.a.hay@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1452732712-12248-5-git-send-email-joshua.a.hay@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/567209/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/567209/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id E98C9140187\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Jan 2016 11:51:57 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 927CFA5939;\n\tThu, 14 Jan 2016 00:51:56 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iROAHMYk_EP4; Thu, 14 Jan 2016 00:51:55 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5372CA593A;\n\tThu, 14 Jan 2016 00:51:55 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id C636B1C0F4A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jan 2016 00:51:53 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C29D293636\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jan 2016 00:51:53 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Y4IVOc8IQ2Vg for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jan 2016 00:51:53 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 166C68B18D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jan 2016 00:51:53 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 13 Jan 2016 16:51:52 -0800", "from jahay1-mobl2.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([134.134.176.160])\n\tby orsmga002.jf.intel.com with ESMTP; 13 Jan 2016 16:51:52 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.22,291,1449561600\"; d=\"scan'208\";a=\"890056919\"", "From": "Joshua Hay <joshua.a.hay@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 13 Jan 2016 16:51:41 -0800", "Message-Id": "<1452732712-12248-5-git-send-email-joshua.a.hay@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1452732712-12248-1-git-send-email-joshua.a.hay@intel.com>", "References": "<1452732712-12248-1-git-send-email-joshua.a.hay@intel.com>", "Subject": "[Intel-wired-lan] [v2 next PATCH S27 04/15] i40e: add VEB stat\n\tcontrol and remove L2 cloud filter", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Shannon Nelson <shannon.nelson@intel.com>\n\nWith the latest firmware, statistics gathering can now be enabled and\ndisabled in the HW switch, so we need to add a parameter to allow the\ndriver to set it as desired. At the same time, the L2 cloud filtering\nparameter has been removed as it was never used.\n\nOlder drivers working with the newer firmware and newer drivers working\nwith older firmware will not run into problems with these bits as the\ndefaults are reasonable and there is no overlap in the bit definitions.\nAlso, newer drivers will be forced to update because of the change in\nfunction call parameters, a reminder that the functionality exists.\n\nAlso update copyright year.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@intel.com>\nChange-ID: I9acb9160b892ca3146f2f11a88fdcd86be3cadcc\n---\nTesting Hints: Testing hints will be driver dependent, see the related\nbase driver changes.\n\n drivers/net/ethernet/intel/i40e/i40e_common.c | 11 ++++++-----\n drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-\n drivers/net/ethernet/intel/i40e/i40e_prototype.h | 6 +++---\n 3 files changed, 10 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex e41c8af..a9302d3 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -2308,8 +2308,8 @@ i40e_status i40e_update_link_info(struct i40e_hw *hw)\n * @downlink_seid: the VSI SEID\n * @enabled_tc: bitmap of TCs to be enabled\n * @default_port: true for default port VSI, false for control port\n- * @enable_l2_filtering: true to add L2 filter table rules to regular forwarding rules for cloud support\n * @veb_seid: pointer to where to put the resulting VEB SEID\n+ * @enable_stats: true to turn on VEB stats\n * @cmd_details: pointer to command details structure or NULL\n *\n * This asks the FW to add a VEB between the uplink and downlink\n@@ -2317,8 +2317,8 @@ i40e_status i40e_update_link_info(struct i40e_hw *hw)\n **/\n i40e_status i40e_aq_add_veb(struct i40e_hw *hw, u16 uplink_seid,\n \t\t\t\tu16 downlink_seid, u8 enabled_tc,\n-\t\t\t\tbool default_port, bool enable_l2_filtering,\n-\t\t\t\tu16 *veb_seid,\n+\t\t\t\tbool default_port, u16 *veb_seid,\n+\t\t\t\tbool enable_stats,\n \t\t\t\tstruct i40e_asq_cmd_details *cmd_details)\n {\n \tstruct i40e_aq_desc desc;\n@@ -2345,8 +2345,9 @@ i40e_status i40e_aq_add_veb(struct i40e_hw *hw, u16 uplink_seid,\n \telse\n \t\tveb_flags |= I40E_AQC_ADD_VEB_PORT_TYPE_DATA;\n \n-\tif (enable_l2_filtering)\n-\t\tveb_flags |= I40E_AQC_ADD_VEB_ENABLE_L2_FILTER;\n+\t/* reverse logic here: set the bitflag to disable the stats */\n+\tif (!enable_stats)\n+\t\tveb_flags |= I40E_AQC_ADD_VEB_ENABLE_DISABLE_STATS;\n \n \tcmd->veb_flags = cpu_to_le16(veb_flags);\n \ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex f29c3bc..ce8651a 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -10073,7 +10073,7 @@ static int i40e_add_veb(struct i40e_veb *veb, struct i40e_vsi *vsi)\n \t/* get a VEB from the hardware */\n \tret = i40e_aq_add_veb(&pf->hw, veb->uplink_seid, vsi->seid,\n \t\t\t veb->enabled_tc, is_default,\n-\t\t\t is_cloud, &veb->seid, NULL);\n+\t\t\t &veb->seid, is_cloud, NULL);\n \tif (ret) {\n \t\tdev_info(&pf->pdev->dev,\n \t\t\t \"couldn't add VEB, err %s aq_err %s\\n\",\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_prototype.h b/drivers/net/ethernet/intel/i40e/i40e_prototype.h\nindex 45af29b..e8deabd 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_prototype.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_prototype.h\n@@ -1,7 +1,7 @@\n /*******************************************************************************\n *\n * Intel Ethernet Controller XL710 Family Linux Driver\n- * Copyright(c) 2013 - 2015 Intel Corporation.\n+ * Copyright(c) 2013 - 2016 Intel Corporation.\n *\n * This program is free software; you can redistribute it and/or modify it\n * under the terms and conditions of the GNU General Public License,\n@@ -138,8 +138,8 @@ i40e_status i40e_aq_update_vsi_params(struct i40e_hw *hw,\n \t\t\t\tstruct i40e_asq_cmd_details *cmd_details);\n i40e_status i40e_aq_add_veb(struct i40e_hw *hw, u16 uplink_seid,\n \t\t\t\tu16 downlink_seid, u8 enabled_tc,\n-\t\t\t\tbool default_port, bool enable_l2_filtering,\n-\t\t\t\tu16 *pveb_seid,\n+\t\t\t\tbool default_port, u16 *pveb_seid,\n+\t\t\t\tbool enable_stats,\n \t\t\t\tstruct i40e_asq_cmd_details *cmd_details);\n i40e_status i40e_aq_get_veb_parameters(struct i40e_hw *hw,\n \t\t\t\tu16 veb_seid, u16 *switch_id, bool *floating,\n", "prefixes": [ "v2", "next", "S27", "04/15" ] }