Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/566206/?format=api
{ "id": 566206, "url": "http://patchwork.ozlabs.org/api/patches/566206/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1452554307-20937-4-git-send-email-joshua.a.hay@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1452554307-20937-4-git-send-email-joshua.a.hay@intel.com>", "list_archive_url": null, "date": "2016-01-11T23:18:15", "name": "[next,S27,03/15] i40e: set shared bit for multicast filters", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "4cd4ef1337718bfa6fa4cd0152212485400ba963", "submitter": { "id": 19461, "url": "http://patchwork.ozlabs.org/api/people/19461/?format=api", "name": "Joshua Hay", "email": "joshua.a.hay@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1452554307-20937-4-git-send-email-joshua.a.hay@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/566206/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/566206/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id E2A6E140291\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 12 Jan 2016 10:18:35 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 44BF089FFD;\n\tMon, 11 Jan 2016 23:18:35 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3CDKbtnHlEWp; Mon, 11 Jan 2016 23:18:34 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9796D89FF2;\n\tMon, 11 Jan 2016 23:18:33 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3B8491C0CA9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Jan 2016 23:18:32 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 828408AC70\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Jan 2016 23:18:31 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MZ71brSeDn1M for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Jan 2016 23:18:29 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 434AC8A92A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Jan 2016 23:18:29 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 11 Jan 2016 15:18:30 -0800", "from jahay1-mobl2.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([134.134.176.82])\n\tby orsmga002.jf.intel.com with ESMTP; 11 Jan 2016 15:18:29 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,555,1444719600\"; d=\"scan'208\";a=\"888496202\"", "From": "Joshua Hay <joshua.a.hay@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 11 Jan 2016 15:18:15 -0800", "Message-Id": "<1452554307-20937-4-git-send-email-joshua.a.hay@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1452554307-20937-1-git-send-email-joshua.a.hay@intel.com>", "References": "<1452554307-20937-1-git-send-email-joshua.a.hay@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S27 03/15] i40e: set shared bit for\n\tmulticast filters", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Shannon Nelson <shannon.nelson@intel.com>\n\nAdd the use of the new Shared MAC filter bit for multicast and broadcast\nfilters in order to make better use of the filters available from the\ndevice. The FW folks have assured me that setting this bit on older FW\nwill have no affect, so we don't need a version check.\n\nAlso fixed a stray indent problem nearby.\n\nAlso update copyright year.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@intel.com>\nChange-ID: I4c5826a32594382a7937a592a24d228588cee7aa\n---\nTesting Hints (required if no HSD):\n\tDisable link polling: ethtool --set-priv-flags p261p1 LinkPolling off\n\tEanble AQ debug: ethtool -s p261p1 msglvl 0xff00000f\n\tAdd a new vlan: ip link add link p261p1 name p261p1.v10 type vlan id 10\n\t\tThis will generate an add macvlan request and dump the trace\n\t\tin dmesg. Make sure that the value in byte 8 for multicast\n\t\tand broadcast addresses is '11' as shown here:\n 14594.033921] i40e 00.0 0x0010 FF FF FF FF FF FF 0A 00 11 00 00 00 00 00 00 00\n \t\tand should be '01' for unicast address. If running on older\n\t\tfirmware, e.g. FVL4, this byte will always be '01'.\n\n drivers/net/ethernet/intel/i40e/i40e_common.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex 66fc5a8..b103a92 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -1,7 +1,7 @@\n /*******************************************************************************\n *\n * Intel Ethernet Controller XL710 Family Linux Driver\n- * Copyright(c) 2013 - 2015 Intel Corporation.\n+ * Copyright(c) 2013 - 2016 Intel Corporation.\n *\n * This program is free software; you can redistribute it and/or modify it\n * under the terms and conditions of the GNU General Public License,\n@@ -2463,6 +2463,7 @@ i40e_status i40e_aq_add_macvlan(struct i40e_hw *hw, u16 seid,\n \t\t(struct i40e_aqc_macvlan *)&desc.params.raw;\n \ti40e_status status;\n \tu16 buf_size;\n+\tint i;\n \n \tif (count == 0 || !mv_list || !hw)\n \t\treturn I40E_ERR_PARAM;\n@@ -2476,12 +2477,17 @@ i40e_status i40e_aq_add_macvlan(struct i40e_hw *hw, u16 seid,\n \tcmd->seid[1] = 0;\n \tcmd->seid[2] = 0;\n \n+\tfor (i = 0; i < count; i++)\n+\t\tif (is_multicast_ether_addr(mv_list[i].mac_addr))\n+\t\t\tmv_list[i].flags |=\n+\t\t\t cpu_to_le16(I40E_AQC_MACVLAN_ADD_USE_SHARED_MAC);\n+\n \tdesc.flags |= cpu_to_le16((u16)(I40E_AQ_FLAG_BUF | I40E_AQ_FLAG_RD));\n \tif (buf_size > I40E_AQ_LARGE_BUF)\n \t\tdesc.flags |= cpu_to_le16((u16)I40E_AQ_FLAG_LB);\n \n \tstatus = i40e_asq_send_command(hw, &desc, mv_list, buf_size,\n-\t\t\t\t cmd_details);\n+\t\t\t\t cmd_details);\n \n \treturn status;\n }\n", "prefixes": [ "next", "S27", "03/15" ] }