Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/566204/?format=api
{ "id": 566204, "url": "http://patchwork.ozlabs.org/api/patches/566204/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1452554307-20937-15-git-send-email-joshua.a.hay@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1452554307-20937-15-git-send-email-joshua.a.hay@intel.com>", "list_archive_url": null, "date": "2016-01-11T23:18:26", "name": "[next,S27,14/15] i40e: properly show packet split status in debugfs", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "319bee176ca579e44efcc4ad4c92a788ff20bd1d", "submitter": { "id": 19461, "url": "http://patchwork.ozlabs.org/api/people/19461/?format=api", "name": "Joshua Hay", "email": "joshua.a.hay@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1452554307-20937-15-git-send-email-joshua.a.hay@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/566204/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/566204/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 235F31402C4\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 12 Jan 2016 10:18:35 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4D49989FFB;\n\tMon, 11 Jan 2016 23:18:34 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1Qauzr7_wl_f; Mon, 11 Jan 2016 23:18:33 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5857A89FE9;\n\tMon, 11 Jan 2016 23:18:33 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id EB43F1C0CA9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Jan 2016 23:18:31 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E80D987F6D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Jan 2016 23:18:31 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jC3ijpGmMkSh for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Jan 2016 23:18:30 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AA5B18B00F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Jan 2016 23:18:30 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 11 Jan 2016 15:18:30 -0800", "from jahay1-mobl2.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([134.134.176.82])\n\tby orsmga002.jf.intel.com with ESMTP; 11 Jan 2016 15:18:30 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,555,1444719600\"; d=\"scan'208\";a=\"888496226\"", "From": "Joshua Hay <joshua.a.hay@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 11 Jan 2016 15:18:26 -0800", "Message-Id": "<1452554307-20937-15-git-send-email-joshua.a.hay@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1452554307-20937-1-git-send-email-joshua.a.hay@intel.com>", "References": "<1452554307-20937-1-git-send-email-joshua.a.hay@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S27 14/15] i40e: properly show packet\n\tsplit status in debugfs", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nGet rid of the unused hsplit field in the ring struct and use the\nexisting macro to detect packet split enablement. This allows debugfs\ndumps of the VSI to properly show which rx routine is in use.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-ID: Ic4e9589e6a788ab196ed0850703f704e30c03781\n---\nTesting Hints: Enable/disable packet split and\ndump the VSI through debugfs. Note the output.\n\n drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 6 +++---\n drivers/net/ethernet/intel/i40e/i40e_txrx.h | 1 -\n drivers/net/ethernet/intel/i40evf/i40e_txrx.h | 1 -\n 3 files changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\nindex bdac691..34da53b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n@@ -521,7 +521,7 @@ static void i40e_dbg_dump_vsi_seid(struct i40e_pf *pf, int seid)\n \t\t\t rx_ring->dtype);\n \t\tdev_info(&pf->pdev->dev,\n \t\t\t \" rx_rings[%i]: hsplit = %d, next_to_use = %d, next_to_clean = %d, ring_active = %i\\n\",\n-\t\t\t i, rx_ring->hsplit,\n+\t\t\t i, ring_is_ps_enabled(rx_ring),\n \t\t\t rx_ring->next_to_use,\n \t\t\t rx_ring->next_to_clean,\n \t\t\t rx_ring->ring_active);\n@@ -572,8 +572,8 @@ static void i40e_dbg_dump_vsi_seid(struct i40e_pf *pf, int seid)\n \t\t\t \" tx_rings[%i]: dtype = %d\\n\",\n \t\t\t i, tx_ring->dtype);\n \t\tdev_info(&pf->pdev->dev,\n-\t\t\t \" tx_rings[%i]: hsplit = %d, next_to_use = %d, next_to_clean = %d, ring_active = %i\\n\",\n-\t\t\t i, tx_ring->hsplit,\n+\t\t\t \" tx_rings[%i]: next_to_use = %d, next_to_clean = %d, ring_active = %i\\n\",\n+\t\t\t i,\n \t\t\t tx_ring->next_to_use,\n \t\t\t tx_ring->next_to_clean,\n \t\t\t tx_ring->ring_active);\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.h b/drivers/net/ethernet/intel/i40e/i40e_txrx.h\nindex e538b40..fd72182 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.h\n@@ -256,7 +256,6 @@ struct i40e_ring {\n #define I40E_RX_DTYPE_NO_SPLIT 0\n #define I40E_RX_DTYPE_HEADER_SPLIT 1\n #define I40E_RX_DTYPE_SPLIT_ALWAYS 2\n-\tu8 hsplit;\n #define I40E_RX_SPLIT_L2 0x1\n #define I40E_RX_SPLIT_IP 0x2\n #define I40E_RX_SPLIT_TCP_UDP 0x4\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.h b/drivers/net/ethernet/intel/i40evf/i40e_txrx.h\nindex 595cd8b..062bd0c 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.h\n@@ -255,7 +255,6 @@ struct i40e_ring {\n #define I40E_RX_DTYPE_NO_SPLIT 0\n #define I40E_RX_DTYPE_HEADER_SPLIT 1\n #define I40E_RX_DTYPE_SPLIT_ALWAYS 2\n-\tu8 hsplit;\n #define I40E_RX_SPLIT_L2 0x1\n #define I40E_RX_SPLIT_IP 0x2\n #define I40E_RX_SPLIT_TCP_UDP 0x4\n", "prefixes": [ "next", "S27", "14/15" ] }