Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/564182/?format=api
{ "id": 564182, "url": "http://patchwork.ozlabs.org/api/patches/564182/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160107071126.13648.59051.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160107071126.13648.59051.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2016-01-07T07:11:26", "name": "[next,09/11] igb: Drop unnecessary checks in transmit path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f6c7229cea87bf999f9ae776faec11aeb74c7020", "submitter": { "id": 67293, "url": "http://patchwork.ozlabs.org/api/people/67293/?format=api", "name": "Alexander Duyck", "email": "aduyck@mirantis.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160107071126.13648.59051.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/564182/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/564182/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 155DE1402E2\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 7 Jan 2016 18:11:32 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 41C9132D9E;\n\tThu, 7 Jan 2016 07:11:32 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MqOrvU9O6QrS; Thu, 7 Jan 2016 07:11:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2315332D95;\n\tThu, 7 Jan 2016 07:11:31 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id B81C31C09CE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Jan 2016 07:11:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B3E8D32D9D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Jan 2016 07:11:29 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qjADqy-3cJwb for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Jan 2016 07:11:29 +0000 (UTC)", "from mail-pa0-f44.google.com (mail-pa0-f44.google.com\n\t[209.85.220.44])\n\tby silver.osuosl.org (Postfix) with ESMTPS id E28C532D9A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Jan 2016 07:11:28 +0000 (UTC)", "by mail-pa0-f44.google.com with SMTP id yy13so159037097pab.3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 06 Jan 2016 23:11:28 -0800 (PST)", "from localhost.localdomain\n\t(static-50-53-29-36.bvtn.or.frontiernet.net. [50.53.29.36])\n\tby smtp.gmail.com with ESMTPSA id\n\ttm4sm149615000pab.3.2016.01.06.23.11.27\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 06 Jan 2016 23:11:28 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mirantis.com header.i=@mirantis.com\n\theader.b=FtESkIVh; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com;\n\ts=google; \n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-type:content-transfer-encoding;\n\tbh=cFJ6Dy1JateMdZHPntDig5UiuEZzfR78h1ZnpObrixs=;\n\tb=FtESkIVh9BlplX/zNVdiV/4L0eOgjWgMPKGmjLlrLCXbLBedWxsTAGbd/gT07zV4ia\n\t83Q9fmaP16+thv1AbAEz47cbRAYTRTjLCfuW8joRymIQYr1+oMj0wMa2pFWPX4kR1Jnx\n\tTvoRC3xPHoMFEaqb62lvYU/JdNlKImQ5mosqQ=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-type\n\t:content-transfer-encoding;\n\tbh=cFJ6Dy1JateMdZHPntDig5UiuEZzfR78h1ZnpObrixs=;\n\tb=UIRvD0gahBGMOc6hohS0LjNgoj6FaisxapK3KBsfaDUViyvIg/K2+JYKo1m7jRuRDJ\n\t4qV+McWt2r+oY3r129RqT8wGDwHRHBF2RNT6PulKjrPrT/JpjBffv4JVpBoHBHlHKX9z\n\tgwwR5UAKdosFMviqeLybxVasWI37tprvwxOqvHwMNOfe3depAnvAKKksTf/8iJd8TbAA\n\tv45bVJwnlbq2ml1wc3IhCKNZfmjFHrnsgen0ym6qSl/KpZEIxzwSArRkzuy0oxffKA49\n\tlbJaIXeXpt5q+WVSf+JZzqyRsFWWONO+nYpz/av2vPQ5U18F68MHQR6KQrpEtD2oJZly\n\tfw5w==", "X-Gm-Message-State": "ALoCoQlAQUvp5zzc+2XMUevsI342JyMUNqFQKI/uinIr/3zsED0bcVXFBR0/GsLDKAwH6Q7ZYMSJ6CPvap0Blec5gNPeZFj8iw==", "X-Received": "by 10.67.15.73 with SMTP id fm9mr116500315pad.130.1452150688658; \n\tWed, 06 Jan 2016 23:11:28 -0800 (PST)", "From": "Alexander Duyck <aduyck@mirantis.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 06 Jan 2016 23:11:26 -0800", "Message-ID": "<20160107071126.13648.59051.stgit@localhost.localdomain>", "In-Reply-To": "<20160107070850.13648.21033.stgit@localhost.localdomain>", "References": "<20160107070850.13648.21033.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH 09/11] igb: Drop unnecessary checks\n\tin transmit path", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "This patch drops several checks that we dropped from ixgbe some ago. It\nshould not be possible for us to be called with either of the conditional\nstatements returning true so we can just drop them from the hot-path.\n\nSigned-off-by: Alexander Duyck <aduyck@mirantis.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 10 ----------\n 1 file changed, 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 04a23230c4dc..49daac3bb051 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -5317,16 +5317,6 @@ static netdev_tx_t igb_xmit_frame(struct sk_buff *skb,\n {\n \tstruct igb_adapter *adapter = netdev_priv(netdev);\n \n-\tif (test_bit(__IGB_DOWN, &adapter->state)) {\n-\t\tdev_kfree_skb_any(skb);\n-\t\treturn NETDEV_TX_OK;\n-\t}\n-\n-\tif (skb->len <= 0) {\n-\t\tdev_kfree_skb_any(skb);\n-\t\treturn NETDEV_TX_OK;\n-\t}\n-\n \t/* The minimum packet size with TCTL.PSP set is 17 so pad the skb\n \t * in order to meet this minimum size requirement.\n \t */\n", "prefixes": [ "next", "09/11" ] }