Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/564175/?format=api
{ "id": 564175, "url": "http://patchwork.ozlabs.org/api/patches/564175/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160107071023.13648.94040.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160107071023.13648.94040.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2016-01-07T07:10:23", "name": "[next,01/11] igb: clean up code for setting MAC address", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1e6d590b40d953602fd6ac843bfca3c8e6a429a6", "submitter": { "id": 67293, "url": "http://patchwork.ozlabs.org/api/people/67293/?format=api", "name": "Alexander Duyck", "email": "aduyck@mirantis.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160107071023.13648.94040.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/564175/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/564175/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id DC69A1402C0\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 7 Jan 2016 18:10:29 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1BE5E8B10E;\n\tThu, 7 Jan 2016 07:10:29 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wERvCd41wIha; Thu, 7 Jan 2016 07:10:27 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E04E58B0ED;\n\tThu, 7 Jan 2016 07:10:27 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0B09C1C09CE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Jan 2016 07:10:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C85869339A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Jan 2016 07:10:26 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bxLjiLYoHoWL for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Jan 2016 07:10:25 +0000 (UTC)", "from mail-pa0-f45.google.com (mail-pa0-f45.google.com\n\t[209.85.220.45])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id D7C779338B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Jan 2016 07:10:25 +0000 (UTC)", "by mail-pa0-f45.google.com with SMTP id cy9so251579162pac.0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 06 Jan 2016 23:10:25 -0800 (PST)", "from localhost.localdomain\n\t(static-50-53-29-36.bvtn.or.frontiernet.net. [50.53.29.36])\n\tby smtp.gmail.com with ESMTPSA id\n\th10sm149490485pat.7.2016.01.06.23.10.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 06 Jan 2016 23:10:24 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mirantis.com header.i=@mirantis.com\n\theader.b=g44nBjWF; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com;\n\ts=google; \n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-type:content-transfer-encoding;\n\tbh=U0TVAIA5pwGyqLlzIF60t4wi4qx0lghA4ls9kGMGC5A=;\n\tb=g44nBjWF2Gdxyw1ZREvyDtcVLMaMe284tglsqK/ukMkUebd720hqvvyI+HBCHCMSYf\n\tLdfW+7C/Tq/bobBziPaJiC0UkTtRKM3JH3ssLPd9v8mpDV96zhosn5L4wBwi2mUKOnN1\n\trun50TIUazVYlKG8tlm2vFhyVG2PumgrOPdvw=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-type\n\t:content-transfer-encoding;\n\tbh=U0TVAIA5pwGyqLlzIF60t4wi4qx0lghA4ls9kGMGC5A=;\n\tb=CGNjIoWkbcPPvrGDxZ+yj1lQ+gCR+jQiLOn2Fxhf0xfiKUzrWRwhKF14zGSBRk4EXv\n\tA2AHKceqFfvvIWuEG2fslHciNW8NIxq0/lXitI+JL2OpA+O40bz6gbm+O3KBLFMErcl2\n\ttL+hMu6S8buyq7bTfB6fRm3mxvOrmxpqpmng7HGXmwDu8Nd+N6E+SKLm23WK6KbKsesL\n\t5i6WjGU/CW3Mx6AUiJJk/yHOVbftxUKy18ChDfoSYdxe/CGAOjznViXJWO+k2yOxlo7D\n\tlUo1O/Xn4V6WKOBRUFw/ADr4DqF19h7VZ9O26H1iq4VPqsLEng+qKa0M0hnrQuRfS9Ao\n\tp7Ow==", "X-Gm-Message-State": "ALoCoQlOES/afvjXVs6h5ZXN/YoaUeR5NYziOQjo1AfQe4dAONjIHEpifw6mo7THrESc0vc6c+hOO3fnZjnXBPY3N0sdfKmI3w==", "X-Received": "by 10.66.218.170 with SMTP id\n\tph10mr149018168pac.58.1452150625387; \n\tWed, 06 Jan 2016 23:10:25 -0800 (PST)", "From": "Alexander Duyck <aduyck@mirantis.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 06 Jan 2016 23:10:23 -0800", "Message-ID": "<20160107071023.13648.94040.stgit@localhost.localdomain>", "In-Reply-To": "<20160107070850.13648.21033.stgit@localhost.localdomain>", "References": "<20160107070850.13648.21033.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH 01/11] igb: clean up code for setting\n\tMAC address", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Drop a bunch of hand written byte swapping code in favor of just doing the\nbyte swapping ourselves. The registers are little endian registers storing\na big endian value so if we read the MAC address array as little endian\nthen we will get the CPU registers into the proper layout.\n\nSigned-off-by: Alexander Duyck <aduyck@mirantis.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 637135e216e4..3b6d4e10d095 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -7834,15 +7834,14 @@ static void igb_io_resume(struct pci_dev *pdev)\n static void igb_rar_set_qsel(struct igb_adapter *adapter, u8 *addr, u32 index,\n \t\t\t u8 qsel)\n {\n-\tu32 rar_low, rar_high;\n \tstruct e1000_hw *hw = &adapter->hw;\n+\tu32 rar_low, rar_high;\n \n \t/* HW expects these in little endian so we reverse the byte order\n-\t * from network order (big endian) to little endian\n+\t * from network order (big endian) to CPU endian\n \t */\n-\trar_low = ((u32) addr[0] | ((u32) addr[1] << 8) |\n-\t\t ((u32) addr[2] << 16) | ((u32) addr[3] << 24));\n-\trar_high = ((u32) addr[4] | ((u32) addr[5] << 8));\n+\trar_low = le32_to_cpup((__be32 *)(addr));\n+\trar_high = le16_to_cpup((__be16 *)(addr + 4));\n \n \t/* Indicate to hardware the Address is Valid. */\n \trar_high |= E1000_RAH_AV;\n", "prefixes": [ "next", "01/11" ] }