Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/562655/?format=api
{ "id": 562655, "url": "http://patchwork.ozlabs.org/api/patches/562655/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1451932392-15538-12-git-send-email-deepthi.kavalur@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1451932392-15538-12-git-send-email-deepthi.kavalur@intel.com>", "list_archive_url": null, "date": "2016-01-04T18:33:11", "name": "[next,S26,11/12] i40e: avoid large memcpy by assigning struct", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6e31a6209770a7cbd7af528f34c1c45f07974c41", "submitter": { "id": 67654, "url": "http://patchwork.ozlabs.org/api/people/67654/?format=api", "name": "Deepthi Kavalur", "email": "deepthi.kavalur@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1451932392-15538-12-git-send-email-deepthi.kavalur@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/562655/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/562655/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id DB18B14016A\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Jan 2016 05:33:31 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DE17F883D0;\n\tMon, 4 Jan 2016 18:33:30 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xGNHFbPkm8SN; Mon, 4 Jan 2016 18:33:27 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8995A884B9;\n\tMon, 4 Jan 2016 18:33:19 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2D4F51C0FD9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:17 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 27DDA2324A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:17 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mdd8xtcPYc8g for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:15 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTP id DA8D132274\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:14 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP; 04 Jan 2016 10:33:14 -0800", "from kehelms-mobl.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([10.254.109.59])\n\tby orsmga003.jf.intel.com with ESMTP; 04 Jan 2016 10:33:14 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,521,1444719600\"; d=\"scan'208\";a=\"720053603\"", "From": "Deepthi Kavalur <deepthi.kavalur@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 4 Jan 2016 10:33:11 -0800", "Message-Id": "<1451932392-15538-12-git-send-email-deepthi.kavalur@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1451932392-15538-1-git-send-email-deepthi.kavalur@intel.com>", "References": "<1451932392-15538-1-git-send-email-deepthi.kavalur@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S26 11/12] i40e: avoid large memcpy\n\tby assigning struct", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nAssign the i40e_pf structure directly instead of using a large memcpy,\nwhich avoids a sparse warning and lets the compiler optimize the copy\nsince it knows the size of the structure in advance.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nReviewed-by: Brandeburg, Jesse <jesse.brandeburg@intel.com>\nChange-ID: I17604e23be2616521eb760290befcb767b52b3f7\n---\n drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\nindex 10744a6..2c0848f 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n@@ -185,9 +185,11 @@ static ssize_t i40e_dbg_dump_write(struct file *filp,\n \t\tif (i40e_dbg_prep_dump_buf(pf, buflen)) {\n \t\t\tp = i40e_dbg_dump_buf;\n \n-\t\t\tlen = sizeof(struct i40e_pf);\n-\t\t\tmemcpy(p, pf, len);\n-\t\t\tp += len;\n+\t\t\t/* avoid use of memcpy here due to sparse warning\n+\t\t\t * about copy size.\n+\t\t\t */\n+\t\t\t*((struct i40e_pf *)p) = *pf;\n+\t\t\tp += sizeof(struct i40e_pf);\n \n \t\t\tlen = (sizeof(struct i40e_aq_desc)\n \t\t\t\t\t* pf->hw.aq.num_asq_entries);\n", "prefixes": [ "next", "S26", "11/12" ] }