Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/562650/?format=api
{ "id": 562650, "url": "http://patchwork.ozlabs.org/api/patches/562650/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1451932392-15538-6-git-send-email-deepthi.kavalur@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1451932392-15538-6-git-send-email-deepthi.kavalur@intel.com>", "list_archive_url": null, "date": "2016-01-04T18:33:05", "name": "[next,S26,05/12] i40e: allocate memory safer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d2f38ec1b94da06eb00b2c71ef2ce360639aa48b", "submitter": { "id": 67654, "url": "http://patchwork.ozlabs.org/api/people/67654/?format=api", "name": "Deepthi Kavalur", "email": "deepthi.kavalur@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1451932392-15538-6-git-send-email-deepthi.kavalur@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/562650/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/562650/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 431AE140BC9\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Jan 2016 05:33:25 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4511F8867A;\n\tMon, 4 Jan 2016 18:33:24 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6aseh2CkoB3N; Mon, 4 Jan 2016 18:33:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3B2A087ED9;\n\tMon, 4 Jan 2016 18:33:16 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 47A8D1C0FD9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:14 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4372D32226\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:14 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Y4V0RepLRFS5 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:13 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4AA8332050\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:13 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP; 04 Jan 2016 10:33:13 -0800", "from kehelms-mobl.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([10.254.109.59])\n\tby orsmga003.jf.intel.com with ESMTP; 04 Jan 2016 10:33:12 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,521,1444719600\"; d=\"scan'208\";a=\"720053584\"", "From": "Deepthi Kavalur <deepthi.kavalur@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 4 Jan 2016 10:33:05 -0800", "Message-Id": "<1451932392-15538-6-git-send-email-deepthi.kavalur@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1451932392-15538-1-git-send-email-deepthi.kavalur@intel.com>", "References": "<1451932392-15538-1-git-send-email-deepthi.kavalur@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S26 05/12] i40e: allocate memory safer", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nThe sync_vsi_filter function was allocating memory in such\na way that it could sleep (GFP_KERNEL) which was causing a problem\nwhen called by the team driver under rcu_read_lock(), which cannot\nbe held while sleeping. Found with lockdep.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nChange-ID: I4e59053cb5eedcf3d0ca151715be3dc42a94bdd5\n---\nTesting-Hints:\nRun lockdep enabled kernel and try these steps:\n teamd -t team0 -rd -c '{\"runner\":{\"name\":\"activebackup\"}}'\n teamdctl team0 port add ens3f0\n teamdctl team0 port add ens3f0\n teamdctl team0 port add ens3f1\n ip link set team0 up\n ip link add link team0 name team0.3 type vlan id 3\n ip l set team0.3 up\n ip link del team0.3\n\n drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex cbbe2f9..052314c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1937,7 +1937,7 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\t sizeof(struct i40e_aqc_remove_macvlan_element_data);\n \t\tdel_list_size = filter_list_len *\n \t\t\t sizeof(struct i40e_aqc_remove_macvlan_element_data);\n-\t\tdel_list = kzalloc(del_list_size, GFP_KERNEL);\n+\t\tdel_list = kzalloc(del_list_size, GFP_ATOMIC);\n \t\tif (!del_list) {\n \t\t\ti40e_cleanup_add_list(&tmp_add_list);\n \n@@ -2015,7 +2015,7 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\t sizeof(struct i40e_aqc_add_macvlan_element_data),\n \t\tadd_list_size = filter_list_len *\n \t\t\t sizeof(struct i40e_aqc_add_macvlan_element_data);\n-\t\tadd_list = kzalloc(add_list_size, GFP_KERNEL);\n+\t\tadd_list = kzalloc(add_list_size, GFP_ATOMIC);\n \t\tif (!add_list) {\n \t\t\t/* Purge element from temporary lists */\n \t\t\ti40e_cleanup_add_list(&tmp_add_list);\n", "prefixes": [ "next", "S26", "05/12" ] }