Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/562646/?format=api
{ "id": 562646, "url": "http://patchwork.ozlabs.org/api/patches/562646/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1451932392-15538-4-git-send-email-deepthi.kavalur@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1451932392-15538-4-git-send-email-deepthi.kavalur@intel.com>", "list_archive_url": null, "date": "2016-01-04T18:33:03", "name": "[next,S26,03/12] i40e: fix bug in dma sync", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ece73b3b4646af6255a861e5d2d631333b617453", "submitter": { "id": 67654, "url": "http://patchwork.ozlabs.org/api/people/67654/?format=api", "name": "Deepthi Kavalur", "email": "deepthi.kavalur@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1451932392-15538-4-git-send-email-deepthi.kavalur@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/562646/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/562646/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id D14F7140BC8\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Jan 2016 05:33:20 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D03398874F;\n\tMon, 4 Jan 2016 18:33:19 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VhMMu6rIzbci; Mon, 4 Jan 2016 18:33:17 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5B5B3884D4;\n\tMon, 4 Jan 2016 18:33:16 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id EA3BF1C0FD9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:14 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E2016322C0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:14 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HKj1ZJh5MhVP for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:12 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTP id DC23932066\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:12 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP; 04 Jan 2016 10:33:12 -0800", "from kehelms-mobl.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([10.254.109.59])\n\tby orsmga003.jf.intel.com with ESMTP; 04 Jan 2016 10:33:12 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,521,1444719600\"; d=\"scan'208\";a=\"720053575\"", "From": "Deepthi Kavalur <deepthi.kavalur@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 4 Jan 2016 10:33:03 -0800", "Message-Id": "<1451932392-15538-4-git-send-email-deepthi.kavalur@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1451932392-15538-1-git-send-email-deepthi.kavalur@intel.com>", "References": "<1451932392-15538-1-git-send-email-deepthi.kavalur@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S26 03/12] i40e: fix bug in dma sync", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nDriver was using an offset based off a dma handle while mapping and\nunmapping using sync_single_range_for[cpu|device], where it should\nbe using dma handle (returned from alloc_coherent) and the offset of the\nmemory to be sync'd.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nReviewed-by: Nelson, Shannon <shannon.nelson@intel.com>\nReviewed-by: Williams, Mitch A <mitch.a.williams@intel.com>\nChange-ID: I208256565b1595ff0e9171ab852de06b997917c6\n---\nTesting-Hints:\nTest traffic, test with DMA API debugging enabled.\n\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 8 ++++----\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 8 ++++----\n 2 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex 7ea2689..7d81c1f 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -1218,8 +1218,8 @@ void i40e_alloc_rx_buffers_ps(struct i40e_ring *rx_ring, u16 cleaned_count)\n \t\t}\n \n \t\tdma_sync_single_range_for_device(rx_ring->dev,\n-\t\t\t\t\t\t bi->dma,\n-\t\t\t\t\t\t 0,\n+\t\t\t\t\t\t rx_ring->rx_bi[0].dma,\n+\t\t\t\t\t\t i * rx_ring->rx_hdr_len,\n \t\t\t\t\t\t rx_ring->rx_hdr_len,\n \t\t\t\t\t\t DMA_FROM_DEVICE);\n \t\t/* Refresh the desc even if buffer_addrs didn't change\n@@ -1534,8 +1534,8 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, int budget)\n \t\t\tskb_record_rx_queue(skb, rx_ring->queue_index);\n \t\t\t/* we are reusing so sync this buffer for CPU use */\n \t\t\tdma_sync_single_range_for_cpu(rx_ring->dev,\n-\t\t\t\t\t\t rx_bi->dma,\n-\t\t\t\t\t\t 0,\n+\t\t\t\t\t\t rx_ring->rx_bi[0].dma,\n+\t\t\t\t\t\t i * rx_ring->rx_hdr_len,\n \t\t\t\t\t\t rx_ring->rx_hdr_len,\n \t\t\t\t\t\t DMA_FROM_DEVICE);\n \t\t}\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex 0e2c627..a1d907c 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -699,8 +699,8 @@ void i40evf_alloc_rx_buffers_ps(struct i40e_ring *rx_ring, u16 cleaned_count)\n \t\t}\n \n \t\tdma_sync_single_range_for_device(rx_ring->dev,\n-\t\t\t\t\t\t bi->dma,\n-\t\t\t\t\t\t 0,\n+\t\t\t\t\t\t rx_ring->rx_bi[0].dma,\n+\t\t\t\t\t\t i * rx_ring->rx_hdr_len,\n \t\t\t\t\t\t rx_ring->rx_hdr_len,\n \t\t\t\t\t\t DMA_FROM_DEVICE);\n \t\t/* Refresh the desc even if buffer_addrs didn't change\n@@ -1006,8 +1006,8 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, int budget)\n \t\t\tskb_record_rx_queue(skb, rx_ring->queue_index);\n \t\t\t/* we are reusing so sync this buffer for CPU use */\n \t\t\tdma_sync_single_range_for_cpu(rx_ring->dev,\n-\t\t\t\t\t\t rx_bi->dma,\n-\t\t\t\t\t\t 0,\n+\t\t\t\t\t\t rx_ring->rx_bi[0].dma,\n+\t\t\t\t\t\t i * rx_ring->rx_hdr_len,\n \t\t\t\t\t\t rx_ring->rx_hdr_len,\n \t\t\t\t\t\t DMA_FROM_DEVICE);\n \t\t}\n", "prefixes": [ "next", "S26", "03/12" ] }