Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/562645/?format=api
{ "id": 562645, "url": "http://patchwork.ozlabs.org/api/patches/562645/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1451932392-15538-7-git-send-email-deepthi.kavalur@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1451932392-15538-7-git-send-email-deepthi.kavalur@intel.com>", "list_archive_url": null, "date": "2016-01-04T18:33:06", "name": "[next,S26,06/12] i40e: fix: do not sleep in netdev_ops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "67cb3250a594129fa7f9bc672a0f417fddcf0085", "submitter": { "id": 67654, "url": "http://patchwork.ozlabs.org/api/people/67654/?format=api", "name": "Deepthi Kavalur", "email": "deepthi.kavalur@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1451932392-15538-7-git-send-email-deepthi.kavalur@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/562645/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/562645/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 349F514016A\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Jan 2016 05:33:20 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 11DEC88690;\n\tMon, 4 Jan 2016 18:33:19 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bBFlGTrYjDWw; Mon, 4 Jan 2016 18:33:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1729688030;\n\tMon, 4 Jan 2016 18:33:16 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2D6071C0FD9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:14 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 280E63229E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:14 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ltf4rPH9iKgV for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:13 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7CF6A32226\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Jan 2016 18:33:13 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP; 04 Jan 2016 10:33:13 -0800", "from kehelms-mobl.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([10.254.109.59])\n\tby orsmga003.jf.intel.com with ESMTP; 04 Jan 2016 10:33:13 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,521,1444719600\"; d=\"scan'208\";a=\"720053588\"", "From": "Deepthi Kavalur <deepthi.kavalur@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 4 Jan 2016 10:33:06 -0800", "Message-Id": "<1451932392-15538-7-git-send-email-deepthi.kavalur@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1451932392-15538-1-git-send-email-deepthi.kavalur@intel.com>", "References": "<1451932392-15538-1-git-send-email-deepthi.kavalur@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S26 06/12] i40e: fix: do not sleep in\n\tnetdev_ops", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nThe driver was being called by vlan, bonding, teaming operations\nthat expected to be able to hold locks like rcu_read_lock().\n\nThis causes the driver to be held to the requirement to not sleep,\nand was found by the kernel debug options for checking sleep\ninside critical section, and the locking validator.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nReviewed-by: Nelson, Shannon <shannon.nelson@intel.com>\nChange-ID: Ibc68c835f5ffa8ffe0638ffe910a66fc5649a7f7\n---\nTesting-Hints:\nAdd and remove vlan, over and under bonding and teaming driver,\nadd and delete mac address, run debug kernel with lock validator.\n\n drivers/net/ethernet/intel/i40e/i40e_main.c | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 052314c..37d6979 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1542,7 +1542,11 @@ static int i40e_set_mac(struct net_device *netdev, void *p)\n \n \tether_addr_copy(netdev->dev_addr, addr->sa_data);\n \n-\treturn i40e_sync_vsi_filters(vsi);\n+\t/* schedule our worker thread which will take care of\n+\t * applying the new filter changes\n+\t */\n+\ti40e_service_event_schedule(vsi->back);\n+\treturn 0;\n }\n \n /**\n@@ -1766,6 +1770,11 @@ bottom_of_search_loop:\n \t\tvsi->flags |= I40E_VSI_FLAG_FILTER_CHANGED;\n \t\tvsi->back->flags |= I40E_FLAG_FILTER_SYNC;\n \t}\n+\n+\t/* schedule our worker thread which will take care of\n+\t * applying the new filter changes\n+\t */\n+\ti40e_service_event_schedule(vsi->back);\n }\n \n /**\n", "prefixes": [ "next", "S26", "06/12" ] }