Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/561847/?format=api
{ "id": 561847, "url": "http://patchwork.ozlabs.org/api/patches/561847/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1451541494-64693-1-git-send-email-t.ueba11@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1451541494-64693-1-git-send-email-t.ueba11@gmail.com>", "list_archive_url": null, "date": "2015-12-31T05:58:14", "name": "igb: When GbE link up, wait for Remote receiver status condition.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "583ffec593cc9e319b9730ced17ca62276e2a5cc", "submitter": { "id": 67975, "url": "http://patchwork.ozlabs.org/api/people/67975/?format=api", "name": "Takuma Ueba", "email": "t.ueba11@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1451541494-64693-1-git-send-email-t.ueba11@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/561847/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/561847/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 1BBDD140BAD\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Dec 2015 18:24:15 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 529589564C;\n\tThu, 31 Dec 2015 07:24:14 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6FtlZ46pvOhU; Thu, 31 Dec 2015 07:24:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4298394D32;\n\tThu, 31 Dec 2015 07:24:13 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id B844F1C0F12\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 31 Dec 2015 05:58:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B140BA5D39\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 31 Dec 2015 05:58:51 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TkrNEt6Mpj2H for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 31 Dec 2015 05:58:50 +0000 (UTC)", "from mail-pa0-f48.google.com (mail-pa0-f48.google.com\n\t[209.85.220.48])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id AC4B2A5D26\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 31 Dec 2015 05:58:50 +0000 (UTC)", "by mail-pa0-f48.google.com with SMTP id do7so148654pab.2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 30 Dec 2015 21:58:50 -0800 (PST)", "from localhost.localdomain (pl930.nas81u.p-kanagawa.nttpc.ne.jp.\n\t[219.102.195.162]) by smtp.gmail.com with ESMTPSA id\n\tr14sm84493652pfi.8.2015.12.30.21.58.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 30 Dec 2015 21:58:49 -0800 (PST)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=Zr/memvw;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:cc:subject:date:message-id;\n\tbh=4e3Ja+UGaEagpLY2pMBbV3rHKg8vZnShBAd6FHSKfiU=;\n\tb=Zr/memvwahpQvz2joXT5cMP+FdAx/85ZzIQB7s4BtgqIswLyr30dlaGF2PcazMBPaU\n\tzfeT314gUa3PQkmbPDxvcO6MTCudM7yAjtpIXWU0UuEGYwsXvlNqdjbWFeR8rcASgh1a\n\tknge+bILuQK2ClESa1/wiUTyYHlztrL6H94BSCq8v29snRfQKJKYKdkyrOc5+HwJFSzA\n\tmwNTNFnTxW99m5C00+aFD5v+mKaKwD1e+LmUC3JuU0xRJNbWkB1CRY0t5B+CybXae6tG\n\tvNHFKVXhds9ukpiCF+yGyT30doTKDAHwqh5Oe3KZ3DZLC/hE+jyTlk7p52G9n1uih3sS\n\ts5MQ==", "X-Received": "by 10.66.253.97 with SMTP id zz1mr56327020pac.106.1451541530427; \n\tWed, 30 Dec 2015 21:58:50 -0800 (PST)", "From": "Takuma Ueba <t.ueba11@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 31 Dec 2015 14:58:14 +0900", "Message-Id": "<1451541494-64693-1-git-send-email-t.ueba11@gmail.com>", "X-Mailer": "git-send-email 1.9.1", "X-Mailman-Approved-At": "Thu, 31 Dec 2015 07:24:11 +0000", "Cc": "Takuma Ueba <t.ueba11@gmail.com>", "Subject": "[Intel-wired-lan] [PATCH] igb: When GbE link up,\n\twait for Remote receiver status condition.", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "I210 device IPv6 autoconf test sometimes fails,\nbecause DAD NS for link-local is not transmitted.\nThis packet is silently dropped.\nThis problem is seen only GbE environment.\n\nigb_watchdog_task link up detection continues to the following process.\nThe following cases are observed:\n1.PHY 1000BASE-T Status Register Remote receiver status bit is NG.\n(NG status becomes OK after about 200 - 700ms)\n2.In this case, the transfer packet is silently dropped.\n\n1000BASE-T Status register\n[Expected]: 0x3800 or 0x7800\n[problem occurred]: 0x2800 or 0x6800\nFrequency of occurrence: approx 1/10 - 1/40 observed\n\nIn order to avoid this problem,\nwait until 1000BASE-T Status register \"Remote receiver status OK\"\n\nAfter applying this patch, at least 400 runs succeed with no problems.\n\nSigned-off-by: Takuma Ueba <t.ueba11@gmail.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 20 ++++++++++++++++++++\n 1 file changed, 20 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 31e5f39..bc1e83d 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -4227,6 +4227,7 @@ static void igb_watchdog_task(struct work_struct *work)\n \tu32 link;\n \tint i;\n \tu32 connsw;\n+\tu16 phy_data, retry_count = 20;\n \n \tlink = igb_has_link(adapter);\n \n@@ -4305,6 +4306,25 @@ static void igb_watchdog_task(struct work_struct *work)\n \t\t\t\tbreak;\n \t\t\t}\n \n+\t\t\tif (adapter->link_speed != SPEED_1000)\n+\t\t\t\tgoto no_wait;\n+\n+\t\t\t/* wait for Remote receiver status OK */\n+retry_read_status:\n+\t\t\tif (!igb_read_phy_reg(hw, PHY_1000T_STATUS,\n+\t\t\t\t\t &phy_data)) {\n+\t\t\t\tif (!(phy_data & SR_1000T_REMOTE_RX_STATUS) &&\n+\t\t\t\t retry_count) {\n+\t\t\t\t\tmsleep(100);\n+\t\t\t\t\tretry_count--;\n+\t\t\t\t\tgoto retry_read_status;\n+\t\t\t\t} else if (!retry_count) {\n+\t\t\t\t\tdev_err(&adapter->pdev->dev, \"exceed max 2 second\\n\");\n+\t\t\t\t}\n+\t\t\t} else {\n+\t\t\t\tdev_err(&adapter->pdev->dev, \"read 1000Base-T Status Reg\\n\");\n+\t\t\t}\n+no_wait:\n \t\t\tnetif_carrier_on(netdev);\n \n \t\t\tigb_ping_all_vfs(adapter);\n", "prefixes": [] }