Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/560710/?format=api
{ "id": 560710, "url": "http://patchwork.ozlabs.org/api/patches/560710/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1450901156-30904-11-git-send-email-deepthi.kavalur@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1450901156-30904-11-git-send-email-deepthi.kavalur@intel.com>", "list_archive_url": null, "date": "2015-12-23T20:05:50", "name": "[next,S25,10/16] i40e: refactor dcb function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "329ba3c8b1daf5c4c56990986264d637e3b4df3d", "submitter": { "id": 67654, "url": "http://patchwork.ozlabs.org/api/people/67654/?format=api", "name": "Deepthi Kavalur", "email": "deepthi.kavalur@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1450901156-30904-11-git-send-email-deepthi.kavalur@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/560710/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/560710/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id A1A30140BA2\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 24 Dec 2015 07:06:17 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 515F995AA0;\n\tWed, 23 Dec 2015 20:06:17 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id QgUVfzhY6Xai; Wed, 23 Dec 2015 20:06:14 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id EF1CC95AAE;\n\tWed, 23 Dec 2015 20:06:10 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8FCCD1C11CD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 23 Dec 2015 20:06:00 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6C6AB268F9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 23 Dec 2015 20:06:00 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ntvaKyUGxYF4 for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 23 Dec 2015 20:05:59 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6818633B3F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 23 Dec 2015 20:05:58 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP; 23 Dec 2015 12:05:58 -0800", "from dkavalur-mobl.amr.corp.intel.com (HELO\n\tlocalhost.localdomain.localdomain) ([134.134.176.72])\n\tby FMSMGA003.fm.intel.com with ESMTP; 23 Dec 2015 12:05:58 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,470,1444719600\"; d=\"scan'208\";a=\"622911060\"", "From": "Deepthi Kavalur <deepthi.kavalur@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 23 Dec 2015 12:05:50 -0800", "Message-Id": "<1450901156-30904-11-git-send-email-deepthi.kavalur@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1450901156-30904-1-git-send-email-deepthi.kavalur@intel.com>", "References": "<1450901156-30904-1-git-send-email-deepthi.kavalur@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S25 10/16] i40e: refactor dcb function", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nThis is a simple refactor suggested by the community\nto change a multi-level if statement into a switch.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nAcked-by: Shannon Nelson <shannon.nelson@intel.com>\nSigned-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\nChange-ID: I831cf3c40426022220aa9b43990022d22dfd50db\n---\nTesting-Hints:\nVerify if function still works.\n\n drivers/net/ethernet/intel/i40e/i40e_dcb.c | 15 +++++++++++----\n 1 file changed, 11 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_dcb.c b/drivers/net/ethernet/intel/i40e/i40e_dcb.c\nindex 582daa7..0fab3a9 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_dcb.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_dcb.c\n@@ -380,17 +380,20 @@ static void i40e_parse_cee_app_tlv(struct i40e_cee_feat_tlv *tlv,\n {\n \tu16 length, typelength, offset = 0;\n \tstruct i40e_cee_app_prio *app;\n-\tu8 i, up, selector;\n+\tu8 i;\n \n \ttypelength = ntohs(tlv->hdr.typelen);\n \tlength = (u16)((typelength & I40E_LLDP_TLV_LEN_MASK) >>\n \t\t I40E_LLDP_TLV_LEN_SHIFT);\n \n \tdcbcfg->numapps = length / sizeof(*app);\n+\n \tif (!dcbcfg->numapps)\n \t\treturn;\n \n \tfor (i = 0; i < dcbcfg->numapps; i++) {\n+\t\tu8 up, selector;\n+\n \t\tapp = (struct i40e_cee_app_prio *)(tlv->tlvinfo + offset);\n \t\tfor (up = 0; up < I40E_MAX_USER_PRIORITY; up++) {\n \t\t\tif (app->prio_map & BIT(up))\n@@ -400,13 +403,17 @@ static void i40e_parse_cee_app_tlv(struct i40e_cee_feat_tlv *tlv,\n \n \t\t/* Get Selector from lower 2 bits, and convert to IEEE */\n \t\tselector = (app->upper_oui_sel & I40E_CEE_APP_SELECTOR_MASK);\n-\t\tif (selector == I40E_CEE_APP_SEL_ETHTYPE)\n+\t\tswitch (selector) {\n+\t\tcase I40E_CEE_APP_SEL_ETHTYPE:\n \t\t\tdcbcfg->app[i].selector = I40E_APP_SEL_ETHTYPE;\n-\t\telse if (selector == I40E_CEE_APP_SEL_TCPIP)\n+\t\t\tbreak;\n+\t\tcase I40E_CEE_APP_SEL_TCPIP:\n \t\t\tdcbcfg->app[i].selector = I40E_APP_SEL_TCPIP;\n-\t\telse\n+\t\t\tbreak;\n+\t\tdefault:\n \t\t\t/* Keep selector as it is for unknown types */\n \t\t\tdcbcfg->app[i].selector = selector;\n+\t\t}\n \n \t\tdcbcfg->app[i].protocolid = ntohs(app->protocol);\n \t\t/* Move to next app */\n", "prefixes": [ "next", "S25", "10/16" ] }