Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/560315/?format=api
{ "id": 560315, "url": "http://patchwork.ozlabs.org/api/patches/560315/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1450827283-34667-2-git-send-email-mitch.a.williams@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1450827283-34667-2-git-send-email-mitch.a.williams@intel.com>", "list_archive_url": null, "date": "2015-12-22T23:34:43", "name": "[next,2/2] i40e: allow zero MAC address for VFs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c5e06c683855de767d269231dc57ccd6c906d917", "submitter": { "id": 967, "url": "http://patchwork.ozlabs.org/api/people/967/?format=api", "name": "Mitch Williams", "email": "mitch.a.williams@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1450827283-34667-2-git-send-email-mitch.a.williams@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/560315/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/560315/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 11E8B14030F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 23 Dec 2015 10:33:08 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 513019254B;\n\tTue, 22 Dec 2015 23:33:07 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iahgGEkncFGk; Tue, 22 Dec 2015 23:33:06 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4647692586;\n\tTue, 22 Dec 2015 23:33:06 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 502561C1064\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Dec 2015 23:33:05 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4970EA55C7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Dec 2015 23:33:05 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id EmCmSGATWx1w for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Dec 2015 23:33:03 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id AAA22A55E1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 Dec 2015 23:33:03 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga102.fm.intel.com with ESMTP; 22 Dec 2015 15:33:03 -0800", "from mawilli1-mobl.jf.intel.com ([10.166.12.51])\n\tby orsmga001.jf.intel.com with ESMTP; 22 Dec 2015 15:33:03 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,466,1444719600\"; d=\"scan'208\";a=\"846761445\"", "From": "Mitch Williams <mitch.a.williams@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 22 Dec 2015 15:34:43 -0800", "Message-Id": "<1450827283-34667-2-git-send-email-mitch.a.williams@intel.com>", "X-Mailer": "git-send-email 2.5.0", "In-Reply-To": "<1450827283-34667-1-git-send-email-mitch.a.williams@intel.com>", "References": "<1450827283-34667-1-git-send-email-mitch.a.williams@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH 2/2] i40e: allow zero MAC address for\n\tVFs", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Allow the user to specify a zero MAC address for VFs. This removes the\nexisting MAC address and allows the VF to use a random address. Libvirt\ndoes this normally when removing a VF from a VM.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex b8deb50..63e62f9 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -2084,9 +2084,9 @@ int i40e_ndo_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac)\n \t\tgoto error_param;\n \t}\n \n-\tif (!is_valid_ether_addr(mac)) {\n+\tif (is_multicast_ether_addr(mac)) {\n \t\tdev_err(&pf->pdev->dev,\n-\t\t\t\"Invalid VF ethernet address\\n\");\n+\t\t\t\"Invalid Ethernet address %pM for VF %d\\n\", mac, vf_id);\n \t\tret = -EINVAL;\n \t\tgoto error_param;\n \t}\n@@ -2097,9 +2097,10 @@ int i40e_ndo_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac)\n \tspin_lock_bh(&vsi->mac_filter_list_lock);\n \n \t/* delete the temporary mac address */\n-\ti40e_del_filter(vsi, vf->default_lan_addr.addr,\n-\t\t\tvf->port_vlan_id ? vf->port_vlan_id : -1,\n-\t\t\ttrue, false);\n+\tif (!is_zero_ether_addr(vf->default_lan_addr.addr))\n+\t\ti40e_del_filter(vsi, vf->default_lan_addr.addr,\n+\t\t\t\tvf->port_vlan_id ? vf->port_vlan_id : -1,\n+\t\t\t\ttrue, false);\n \n \t/* Delete all the filters for this VSI - we're going to kill it\n \t * anyway.\n", "prefixes": [ "next", "2/2" ] }